Salman Alshamrani
855fa4e658
Merge branch 'master' into mania-hp-bar-position
2024-12-24 08:32:59 -05:00
Joseph Madamba
e95dc2b308
Add FormatStarRating() method util
2024-12-12 15:23:00 -08:00
Salman Alshamrani
8c238dd624
Merge branch 'master' into mania-hp-bar-position
2024-12-11 05:13:42 -05:00
Salman Alshamrani
b08a4179eb
Exclude skins that contain health display on playfield target
2024-12-11 05:07:21 -05:00
Salman Alshamrani
a2c57ee418
Fix osu! and osu!catch no longer displaying a health display
2024-12-04 03:36:35 -05:00
Salman Alshamrani
45101b5790
Merge branch 'master' into mania-hp-bar-position
2024-12-04 03:23:28 -05:00
Bartłomiej Dach
c12cb2582e
Document & reduce visibility of GetInstanceType()
2024-12-02 10:03:19 +01:00
Huo Yaoyuan
fa3c95c296
Merge branch 'master'
2024-11-30 01:07:08 +08:00
Bartłomiej Dach
110e4fbb30
Centralise supported file extensions to one helper class
...
As proposed in
https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837 .
2024-11-29 08:42:45 +01:00
Huo Yaoyuan
f5a7716509
Apply minor performance rules
2024-11-28 20:41:44 +08:00
Salman Alshamrani
01f3a2dd14
Move non-legacy conditional reasoning to migration code
2024-11-27 06:12:52 -05:00
Salman Alshamrani
0e920a61da
Use type equality
2024-11-25 23:49:55 -05:00
Salman Alshamrani
fcbfbd02fd
Add migration logic for legacy health displays
2024-11-25 23:39:37 -05:00
Salman Alshamrani
c2215b10cf
Add extensive test scene for skin migrations
...
This is different from `SkinDeserialisationTest` in that layouts can be written programmatically with as much ease, allowing to test migration logic with different scenarios without running the game and exporting skins and attaching them to tests.
2024-11-25 23:23:39 -05:00
Salman Alshamrani
83ecfbd155
Revert "Refactor skin migration to allow mutating multiple layouts at once"
...
This reverts commit f1b5686904
2024-11-25 23:23:39 -05:00
Salman Alshamrani
7df7727591
Revert "Migrate legacy health bar display to per-ruleset target"
...
This reverts commit 76f79ce083
2024-11-25 23:23:38 -05:00
Salman Alshamrani
76f79ce083
Migrate legacy health bar display to per-ruleset target
2024-11-25 00:02:27 -05:00
Salman Alshamrani
f1b5686904
Refactor skin migration to allow mutating multiple layouts at once
2024-11-25 00:02:10 -05:00
Cadence Ember
37394a5027
Use consistent decimal places in BeatmapAttributeText
2024-11-21 14:04:42 +13:00
Dan Balasescu
ef22b6b1a8
Round to integral units
...
The rounding matches the implementation of `PerformancePointsCounter`.
2024-11-01 22:43:52 +09:00
Bartłomiej Dach
3dc2408965
Merge branch 'master' into bat-max-performance
2024-11-01 13:13:20 +01:00
Bartłomiej Dach
1b5d1347aa
Merge branch 'master' into bat-mods
2024-11-01 11:27:06 +01:00
Bartłomiej Dach
5f63950598
Add missing disposal
2024-11-01 11:26:59 +01:00
Bartłomiej Dach
1008d32ddb
Fix old looping samples not stopping when replacing a SkinnableSound's Samples
...
Closes https://github.com/ppy/osu/issues/30365 .
2024-10-22 14:35:21 +02:00
Dan Balasescu
def499e7cb
Merge branch 'master' into bat-mods
2024-10-18 18:58:45 +09:00
Dan Balasescu
e27aa0c761
Return empty strings rather than erroring
...
Preventing malicious actors from permanently destroying games via skins.
2024-10-18 17:18:01 +09:00
Dan Balasescu
2de5e3392e
Only add as many values as are replaced
2024-10-18 17:16:42 +09:00
Bartłomiej Dach
8804769da1
Use better exception messaging
2024-10-18 08:51:01 +02:00
Bartłomiej Dach
b455b9ad09
Discard unused argument
2024-10-18 08:39:23 +02:00
Dan Balasescu
0473f0b60a
Use stored difficulty to reduce flickering
2024-10-17 20:39:50 +09:00
Dan Balasescu
2ce1475303
Merge branch 'bat-mods' into bat-max-performance
2024-10-17 20:38:29 +09:00
Dan Balasescu
b40c31af3a
Store difficulty to reduce flickering
...
The computation usually finishes in a few milliseconds anyway.
2024-10-17 20:37:37 +09:00
Dan Balasescu
6749768b9e
Add max performance beatmap attribute text
2024-10-17 20:00:18 +09:00
Dan Balasescu
f9a9ceb41c
Also bind to mod setting changes
2024-10-17 17:57:49 +09:00
Dan Balasescu
9ea15a3961
Show bpm and length inclusive of mods
2024-10-17 17:57:49 +09:00
Dan Balasescu
400142545d
Show difficulty values inclusive of mods
2024-10-17 17:57:49 +09:00
Dan Balasescu
1e2c1323ff
Show star difficulty attribute inclusive of mods
2024-10-17 17:57:49 +09:00
Dan Balasescu
102f55a213
Refactor BeatmapAttributeText to compute values on the fly
2024-10-17 16:10:06 +09:00
Dean Herbert
5efdc6cdd7
Merge pull request #29936 from u4vh3/skinning-colour-customisation
...
Add colour customisation to layout editor
2024-09-27 14:20:58 +09:00
Dean Herbert
89e8baf1d3
Add inline comments for iOS locals
2024-09-26 16:48:42 +09:00
Dan Balasescu
3ab04d98f6
Fix Realm-related iOS crashes by removing object references
2024-09-25 16:45:37 +09:00
Bartłomiej Dach
9f4e48dde7
Actually use bindables rather than stick things in Update()
2024-09-24 15:15:28 +02:00
Daniel Cios
73b6744a97
Rename FontColour to TextColour
2024-09-20 16:50:17 +02:00
Daniel Cios
ec575e9de4
Rename Colour to AccentColour
2024-09-20 16:38:26 +02:00
Daniel Cios
e81e356d59
Add colour customisation to skin components
2024-09-19 17:27:25 +02:00
Bartłomiej Dach
0e663d1801
Revert default combo counter code to pre-abstractification (and nuke eldritch abstract entity)
2024-09-11 11:44:59 +02:00
Dean Herbert
885d832e98
Fix deserialise failing with some old skins
2024-08-23 20:44:45 +09:00
Dean Herbert
48cfd77ee8
Component -> Lookup
2024-08-23 14:48:50 +09:00
Dean Herbert
46d55d5e61
Remove remaining early base lookup calls which were missed
2024-08-22 20:13:28 +09:00
Dean Herbert
1435fe24ae
Remove requirement of base calls to ensure user skin container layouts are retrieved
2024-08-22 19:14:30 +09:00
