71393 Commits

This Branch

This Branch

All Branches

• Do not double up first control point of path
  Bartłomiej Dach · 2025-01-31 09:01:42 +01:00
  20280cd195
• Move control point double-up logic to LegacyBeatmapExporter

  Done for two reasons:
  
  - During review it was requested for the logic to be moved out of
    `BezierConverter` as `BezierConverter` was intended to produce
    "lazer style" sliders with per-control-point curve types,
    as a future usability / code layering concern.
  
  - It is also relevant for encode-decode stability. With how the logic
    was structured between the Bezier converter and the legacy beatmap
    encoder, the encoder would leave behind per-control-point Bezier curve
    specs that stable ignored, but subsequent encodes and decodes in lazer
    would end up multiplying the doubled-up control points ad nauseam.
    Instead, it is sufficient to only specify the curve type for the
    head control point as Bezier, not specify any further curve types
    later on, and instead just keep the double-up-control-point for new
    implicit segment logic which is enough to make stable cooperate
    (and also as close to outputting the slider exactly as stable would
    have produced it as we've ever been)

  Bartłomiej Dach · 2025-01-30 15:28:47 +01:00
  b4f63da048
• Move implicit slider path segment handling logic to Bezier converter

  The logic in `LegacyBeatmapEncoder` that was supposed to handle
  the lazer-exclusive feature of supporting multiple slider segment types
  in a single slider was interfering rather badly with the Bezier
  converter. Generally it was a bit difficult to follow, too.
  
  The nice thing about `BezierConverter` is that it is *guaranteed* to
  only output Bezier control points. In light of this, the same double-up-
  -the-control-point logic that was supposed to make multiple slider
  segment types backwards-compatible with stable can be placed in
  the Bezier conversion logic, and be *much* more understandable, too.

  Bartłomiej Dach · 2025-01-30 14:03:51 +01:00
  749704344c
• Merge pull request #31663 from nekodex/friend-notification-samples

  Add unique samples for friend online/offline notifications

  Dean Herbert · 2025-01-30 19:45:30 +09:00
  8a887abe51
• Merge pull request #31685 from frenzibyte/two-factor-authentication-code

  Do not display autocorrect suggestions in two factor verification code text box

  Bartłomiej Dach · 2025-01-30 11:15:09 +01:00
  d8c63a443f
• Merge branch 'master' into friend-notification-samples
  Dean Herbert · 2025-01-30 18:29:26 +09:00
  5f2532932e
• Merge pull request #31655 from bdach/deabstractify-editor-snap

  Refactor editor object snapping to remove bad abstractions

  Dan Balasescu · 2025-01-30 01:38:42 +09:00
  48b1c7398e
• Merge pull request #31726 from peppy/room-settings-button

  Make multiplayer change room settings more obvious as to what it does

  Dan Balasescu · 2025-01-30 00:42:00 +09:00
  7750468e31
• Merge pull request #31723 from peppy/fix-unstable-rate-incrementatl

  Fix incremental unstable rate calculation not matching expectations

  Dan Balasescu · 2025-01-29 23:54:59 +09:00
  007bf87a6b
• Remove unused usings
  Dan Balasescu · 2025-01-29 23:32:44 +09:00
  ca7a36d3d6
• Merge branch 'master' into two-factor-authentication-code
  Bartłomiej Dach · 2025-01-29 13:15:30 +01:00
  75ef67e959
• Merge pull request #31590 from frenzibyte/fix-editor-textbox-regressions

  Fix recent editor textbox regressions

  Bartłomiej Dach · 2025-01-29 12:08:42 +01:00
  9a9f42c3ff
• Make multiplayer change room settings more obvious as to what it does

  "Edit" felt really weird.

  Dean Herbert · 2025-01-29 19:48:04 +09:00
  a6814d1a8a
• Merge branch 'master' into fix-editor-textbox-regressions
  Bartłomiej Dach · 2025-01-29 11:25:16 +01:00
  d87720da1b
• Merge pull request #31417 from peppy/enable-sentry-caching

  Enable sentry caching to avoid sentry writing outside of game directory

  Bartłomiej Dach · 2025-01-29 11:19:56 +01:00
  c079969e72
• Fix reference hashsets getting emptied before used
  Dean Herbert · 2025-01-29 19:15:28 +09:00
  facc9a4dc3
• Merge branch 'master' into friend-notification-samples
  Dean Herbert · 2025-01-29 17:43:56 +09:00
  9db8e0b7ac
• Code quality pass
  Dean Herbert · 2025-01-29 17:43:49 +09:00
  bf40f071eb
• Update resources
  Dean Herbert · 2025-01-29 17:34:03 +09:00
  4c83ef83ee
• Update framework

  Update framework

  Dean Herbert · 2025-01-29 17:32:05 +09:00
  fd1d90cbd9
• Fix incremental unstable rate calculation not matching expectations

  The `EventCount` variable wasn't factoring in that some results do not
  affect unstable rate. It would therefore become more incorrect as the
  play continued.
  
  Closes https://github.com/ppy/osu/issues/31712.

  Dean Herbert · 2025-01-29 17:11:12 +09:00
  d8ec3b77e4
• Add fail cases to unstable rate incremental testing
  Dean Herbert · 2025-01-29 17:10:05 +09:00
  6c4b4166ac
• Merge branch 'master' into enable-sentry-caching
  Dean Herbert · 2025-01-29 11:55:23 +09:00
  a3685da250
• Merge pull request #31711 from peppy/change-friend-notification-icons

  Change friend online notifications' icon and colours

  Bartłomiej Dach · 2025-01-28 15:38:27 +01:00
  b84a9f7820
• Merge pull request #31709 from peppy/catch-od-hide

  Remove "Accuracy" from osu!catch editor setup

  Bartłomiej Dach · 2025-01-28 15:33:50 +01:00
  99d898326c
• Add keywords to make lighten-during-breaks setting discoverable to stable users

  See https://github.com/ppy/osu/discussions/31671.

  Dean Herbert · 2025-01-28 21:31:51 +09:00
  a3a08832b4
• Change friend online notifications' icon and colours

  The previous choices made it seem like potentially destructive actions
  were being performed. I've gone with neutral colours and more suiting
  icons to attempt to avoid this.
  
  ---
  
  Addresses concerns in
  https://github.com/ppy/osu/discussions/31621#discussioncomment-11948377.
  
  I chose this design even though it wasn't the #1 most popular because I
  personally feel that using green/red doesn't work great for these.

  Dean Herbert · 2025-01-28 21:29:17 +09:00
  017d38af3d
• Remove "Accuracy" and "Stack Leniency" from osu!catch editor setup
  Dean Herbert · 2025-01-28 21:22:51 +09:00
  1aa1137b09
• Merge pull request #31696 from bdach/do-not-bundle-explicit-beatmaps

  Do not bundle explicit beatmaps

  Dean Herbert · 2025-01-28 20:39:21 +09:00
  6d39ee2918
• Merge pull request #31697 from bdach/corrupt-mp3s-should-not-crash-game

  Catch and display user-friendly errors regarding corrupted audio files

  Dan Balasescu · 2025-01-28 14:00:01 +09:00
  a863230983
• Merge pull request #31698 from bdach/weird-zips

  Work around rare sharpcompress failure to extract certain archives

  Dan Balasescu · 2025-01-28 13:21:58 +09:00
  a075f76344
• Work around rare sharpcompress failure to extract certain archives

  Closes https://github.com/ppy/osu/issues/31667.
  
  See https://github.com/ppy/osu/issues/31667#issuecomment-2615483900 for
  explanation.
  
  For whatever it's worth, I see rejecting this change and telling
  upstream to fix it as an equally agreeable outcome, but after I spent an
  hour+ tracking this down, writing this diff was nothing in comparison.

  Bartłomiej Dach · 2025-01-27 12:28:53 +01:00
  bb8f58f6d6
• Fix infinite loop when switching audio tracks fails on an existing beatmap

  Bit ugly, but appears to work in practice...

  Bartłomiej Dach · 2025-01-27 10:27:06 +01:00
  be9c96c041
• Catch and display user-friendly errors regarding corrupted audio files

  Addresses lack of user feedback as indicated by
  https://github.com/ppy/osu/issues/31693.

  Bartłomiej Dach · 2025-01-27 10:25:22 +01:00
  01ae1a58f1
• Add inline comments for sets that are not marked FA but should be
  Bartłomiej Dach · 2025-01-27 09:40:53 +01:00
  e24af4b341
• Remove explicit beatmap set from list of bundled beatmap sets
  Bartłomiej Dach · 2025-01-27 09:40:20 +01:00
  836a9e5c25
• Specifiy second-factor authentication code text box with Code type
  Salman Alshamrani · 2025-01-25 23:58:56 -05:00
  4d7b071027
• Merge pull request #31664 from ThePooN/ios-non-exempt-encryption

  🔧 Specify we're not using non-exempt encryption

  Salman Alshamrani · 2025-01-24 13:00:08 -05:00
  129ab03ec4
• 🔧 Specify we're not using non-exempt encryption
  ThePooN · 2025-01-24 18:14:55 +01:00
  354126b7f7
• Merge pull request #31652 from peppy/beatmap-carousel-v2-split-panels

  Split out beatmap and set panels in  beatmap carousel v2

  Bartłomiej Dach · 2025-01-24 16:00:04 +01:00
  3c763971ff
• Add unique samples for friend online/offline notifications
  Jamie Taylor · 2025-01-24 23:20:04 +09:00
  79df094f17
• Merge branch 'master' into beatmap-carousel-v2-split-panels
  Bartłomiej Dach · 2025-01-24 15:16:23 +01:00
  092c7b4253
• Remove unused field
  Bartłomiej Dach · 2025-01-24 15:15:50 +01:00
  55ab3c72f6
• Remove selection animation on set panel
  Dean Herbert · 2025-01-24 22:45:08 +09:00
  82c5f37c2c
• Fix test failures
  Bartłomiej Dach · 2025-01-24 14:24:16 +01:00
  b0136f98a9
• Merge pull request #31645 from peppy/offset-adjust-more-lenience

  Make offset adjust more lenient

  Bartłomiej Dach · 2025-01-24 14:01:25 +01:00
  7845c5cfb7
• Refactor further to avoid weird non-virtual common method
  Bartłomiej Dach · 2025-01-24 13:14:31 +01:00
  daec91f61d
• Fix behavioural change in interaction between grid & distance snap
  Bartłomiej Dach · 2025-01-24 13:14:26 +01:00
  b04144df54
• Simplify code
  Bartłomiej Dach · 2025-01-24 13:14:06 +01:00
  589035c534
• Merge pull request #31623 from Layendan/room-context-menu

  Add view in browser context menu functionality to multiplayer/playlist rooms

  Dean Herbert · 2025-01-24 20:31:49 +09:00
  a94681158d