Dean Herbert
4983e5f33e
Merge pull request #29039 from bdach/multiple-selection-sample-popover
...
Make sample popover change properties of all samples in multiple selection
2024-07-24 22:49:20 +09:00
Bartłomiej Dach
087dd759be
Adjust layout to ballpark-match stable
...
I dunno what the wiki is claiming with the "24px" figure or why
but I'm not playing conversion games either. Dimensions ballparked
via screenshots captured at x768 resolution.
Also removes a weird homebrew method to keep the text upright.
There is one canonical way to do this, namely
`UprightAspectMaintainingContainer`. And the other key counters
were already using it.
2024-07-24 14:52:56 +02:00
Bartłomiej Dach
ace5071d88
Add better test scene
2024-07-24 14:25:51 +02:00
Bartłomiej Dach
55382a4ba6
Add test coverage for expected sample popover behaviour
2024-07-24 12:08:13 +02:00
normalid
0306ef4096
Update test assets
2024-07-24 14:13:45 +08:00
normalid
95f287104e
Add visual test seane
2024-07-24 12:24:58 +08:00
normalid
661f58a397
Add test coverage
2024-07-24 12:18:05 +08:00
Bartłomiej Dach
c2fa30bf81
Add test coverage for break generation respecting pre-empt time
2024-07-23 13:38:25 +02:00
Bartłomiej Dach
25d63ac6a5
Move editor beatmap processor test cases off of OsuHitObjects
...
Most of them are about to become obsolete once consideration for
`TimePreempt` is re-added.
2024-07-23 13:28:49 +02:00
Bartłomiej Dach
dd8be62d07
Merge pull request #28849 from frenzibyte/custom-profile-colour
...
Add custom hue support to user profile overlay
2024-07-22 09:41:32 +02:00
Bartłomiej Dach
088b8aff11
Merge pull request #28881 from smoogipoo/fix-judgement-cut
...
Fix judgement animation getting cut early
2024-07-22 09:24:57 +02:00
Layendan
6a4872faa8
Remove nullable disable
2024-07-21 23:56:47 -07:00
Layendan
e4cccb5e31
Fix lint errors
2024-07-22 12:22:52 +09:00
Layendan
a575566638
Add tests
2024-07-22 12:22:51 +09:00
Salman Ahmed
d7651ef387
Add extensive test cases for correct input handling while paused in osu! & non-osu!
2024-07-19 18:48:35 +03:00
Dean Herbert
d9297438ba
Merge pull request #28900 from smoogipoo/fix-more-tests
...
Fix more test failures
2024-07-19 19:38:52 +09:00
Dan Balasescu
7a4758d8cc
Attempt to fix TestSelectableMouseHandling test failure
...
https://github.com/ppy/osu/pull/28900/checks?check_run_id=27652166871
This is an attempt. Going frame-by-frame I noticed that there's one
frame in which the text is loaded but the
FillFlowContainer/GridContainer haven't properly validated so the text
is not positioned correctly (it's overflowing the panel to the left). If
the cursor is moved at this exact time, then it may not be properly
positioned for the following assertion, even though it is _somewhere_ on
the panel.
If the above is the case, then this is a known o!f issue, but not a
simple one to solve.
I haven't reproed this locally.
2024-07-19 17:49:16 +09:00
Dan Balasescu
d7ae9505b2
Fix TestCancelNavigationToEditor test failure
...
https://github.com/ppy/osu/actions/runs/10002179087/job/27648253709
The editor could be pushed before the exit actually
occurs.
2024-07-19 15:04:21 +09:00
Bartłomiej Dach
79cf644b8d
Enable NRT while we're here
2024-07-19 07:34:00 +02:00
Bartłomiej Dach
73edb32440
Add failing test coverage
2024-07-19 07:30:57 +02:00
Dan Balasescu
3f4e56be3c
Fix TestPostAsOwner test failure
...
https://github.com/smoogipoo/osu/actions/runs/9990112749/job/27610257309
Comments are loaded asynchronously, both from the initial request and
the following message-post request. By sheer timing luck, these could be
out of order and the assertion on the posted message could fail.
2024-07-18 20:54:05 +09:00
Dan Balasescu
33a81d8181
Use constraint to improve assertion message
2024-07-18 18:34:08 +09:00
Dan Balasescu
f3cd3d7d3b
Fix TestAllSamplesStopDuringSeek test failure
...
https://github.com/smoogipoo/osu/actions/runs/9986761756/job/27599851263
This is a bit of a workaround, likely timing related. I don't foresee an
until step in this case to cause false-passes.
2024-07-18 16:26:42 +09:00
Dan Balasescu
1906c2f725
Fix TestTouchScreenDetectionAtSongSelect test failure
...
https://github.com/ppy/osu/actions/runs/9985890747/job/27597501295
In this case, the settings overlay is taking a very long time to load
(on a background thread), and pops in when it finishes loading because
it's been requested to open.
The opens the settings overlay, closes it (by pressing escape, this does
not actually close it because it's not loaded yet), and then enters song
select by pressing 'P' 3 times. The settings overlay finishes loading at
just the right opportune moment to eat one of the 'P' key presses.
2024-07-18 16:26:16 +09:00
Salman Ahmed
7a39435017
Fix intermitent test failure in TestSceneArgonHealthDisplay
2024-07-18 01:20:50 +03:00
Bartłomiej Dach
53b6f9e385
Fix test not waiting properly for background processing to complete
2024-07-16 14:04:51 +02:00
Bartłomiej Dach
6db135279f
Restore test coverage of original fail case
2024-07-16 14:04:50 +02:00
Dan Balasescu
ae5b0aa54b
Fix BackgroundDataStoreProcessor test failure
2024-07-16 19:59:13 +09:00
Bartłomiej Dach
76d016df34
Fix code inspection
2024-07-16 11:31:16 +02:00
Dan Balasescu
d4ea604ad0
Add test
2024-07-16 18:19:00 +09:00
Dean Herbert
2c102fc9d0
Fix test failure in TestMetadataTransferred
2024-07-14 01:36:51 +09:00
Salman Ahmed
be1d3c0ea4
Add test coverage
2024-07-13 11:58:54 +03:00
Dean Herbert
eb3f480a2a
Merge pull request #28683 from frenzibyte/footer-v2-integration
...
Replace local footer in existing sheared overlays (e.g. mod select & first-run setup) with `ScreenFooter`
2024-07-12 22:45:06 +09:00
Bartłomiej Dach
518dc17518
Merge pull request #28788 from bdach/timeline-redesign
...
Redesign editor timelines to address most frequent user complaints
2024-07-12 10:58:59 +02:00
Bartłomiej Dach
452fbed681
Merge pull request #28808 from frenzibyte/fix-all-notifications
...
Fix confirm exit dialog potentially showing incorrect number of ongoing operations
2024-07-12 10:56:29 +02:00
Dean Herbert
43addc8400
Fix test regression
2024-07-12 16:29:41 +09:00
Salman Ahmed
3ea0f58daa
Update TestSceneFreeModSelectOverlay to work again
2024-07-11 15:31:23 +03:00
Salman Ahmed
7a5624fd0e
Add screen footer to ScreenTestScene
2024-07-11 15:30:07 +03:00
Bartłomiej Dach
f1fa34e5d5
Merge pull request #28800 from peppy/file-mounting-v3
...
Add ability to edit beatmap content externally
2024-07-11 10:47:36 +02:00
Dean Herbert
c139478aa2
Merge pull request #28805 from frenzibyte/select-all-on-focus
...
Select all text when focusing sample bank/volume textboxes in editor (and number boxes in general)
2024-07-11 17:33:30 +09:00
Bartłomiej Dach
a859978efd
Add failing test steps for locally modified state not being set
2024-07-11 09:43:00 +02:00
Dean Herbert
b5bb94e4ec
Merge branch 'master' into file-mounting-v3
2024-07-11 15:54:54 +09:00
Bartłomiej Dach
a9c8c6e74d
Attempt to fix test failures by forcing refresh
2024-07-11 08:18:16 +02:00
Salman Ahmed
8ca8648a09
Add failing test case
2024-07-10 16:14:12 +03:00
Salman Ahmed
7d667ac46b
Fix confirm exit dialog overflowing from too many ongoing operations
2024-07-10 16:06:53 +03:00
Salman Ahmed
94f51c92e0
Select all text when focusing a number box
2024-07-10 15:16:10 +03:00
Dean Herbert
106d558147
Add test coverage of difficulty being retained
2024-07-10 18:34:47 +09:00
Dean Herbert
aa16c72e06
Add test coverage of external editing
2024-07-10 18:34:47 +09:00
Dean Herbert
72091b43df
Simplify editor navigation tests
2024-07-10 18:34:47 +09:00
Salman Ahmed
f0a7a3f856
Add failing test case for edge case
2024-07-10 11:51:49 +03:00
