61410 Commits

This Branch

This Branch

All Branches

• Fix utterly broken test

  - Was on wrong ruleset, so the mod/free mod sets did literally nothing
  - `assertHasFreeModButton` had a param that did nothing
  - Was checking `MatchingFilter` rather than `Visible`

  Bartłomiej Dach · 2023-06-18 14:16:38 +02:00
  9758e5f840
• Remove obvious comment
  Bartłomiej Dach · 2023-06-18 14:04:00 +02:00
  4c78144d10
• Fix duplicate linq and reword comment
  Bartłomiej Dach · 2023-06-18 14:03:26 +02:00
  64e96c6d82
• Remove duplicated xmldoc and move into relevant region
  Bartłomiej Dach · 2023-06-18 13:59:36 +02:00
  a1015b4145
• Remove redundant guard

  `Bindable` has one of those already.

  Bartłomiej Dach · 2023-06-18 13:58:25 +02:00
  1b4d7db1e6
• Remove unused property
  Bartłomiej Dach · 2023-06-18 13:58:25 +02:00
  c7e8990576
• Rename ModState members to better convey what's what
  Bartłomiej Dach · 2023-06-18 13:58:25 +02:00
  62f01e4f40
• Update framework
  Dean Herbert · 2023-06-18 20:57:43 +09:00
  d9c00fc4be
• Apply osu! side changes in line with FocusedOverlayContainer.PopIn abstract change

  See https://github.com/ppy/osu-framework/pull/5834

  Dean Herbert · 2023-06-18 20:57:32 +09:00
  eb31fdecee
• Merge pull request #23954 from Joehuu/fix-drain-length-tooltip

  Fix beatmap info length tooltip not showing actual drain length

  Dean Herbert · 2023-06-18 15:20:45 +09:00
  ba8ca3facf
• Merge pull request #23952 from frenzibyte/ios-file-import-support

  Add back support for importing beatmaps/skins/replays on iOS via "Files" app

  Dean Herbert · 2023-06-18 15:14:50 +09:00
  66f33b4f8c
• Fix beatmap info length tooltip not showing actual drain length
  Joseph Madamba · 2023-06-17 15:00:32 -07:00
  9ae864c219
• Fix incorrect xmldoc of IBeatmapInfo.Length
  Joseph Madamba · 2023-06-17 14:55:27 -07:00
  fdebf93ae4
• Merge pull request #23951 from peppy/avoid-humanizer-song-select-overhead

  Avoid humanizer regex compilation overhead when opening song select for the first time

  Bartłomiej Dach · 2023-06-17 20:39:40 +02:00
  fc07705809
• Bring back old formatting spec
  Bartłomiej Dach · 2023-06-17 20:03:24 +02:00
  eafd774044
• Move DragDrop handling to base game implementation for iOS support
  Salman Ahmed · 2023-06-17 20:30:22 +03:00
  25fa4a2eb5
• Avoid humanizer regex compilation overhead when opening song select for the first time
  Dean Herbert · 2023-06-18 02:19:03 +09:00
  4919069ea6
• Merge pull request #23946 from FrBst/mania-triangles-fix

  Fix column colours not being correctly applied on Triangles skin with Dual Stages mod active

  Bartłomiej Dach · 2023-06-17 11:11:04 +02:00
  822c556c5a
• Add better test coverage of dual stages in skinnable tests
  Bartłomiej Dach · 2023-06-17 10:27:43 +02:00
  688e65475d
• Fix Triangle skin colors with Dual Stage mod
  Maksim Kan · 2023-06-17 10:12:26 +03:00
  f70342bd67
• Merge pull request #23937 from peppy/order-by-total-score-extension

  Move `OrderByTotalScore()` to an extension method

  Bartłomiej Dach · 2023-06-16 22:18:27 +02:00
  2976145150
• Merge pull request #23936 from peppy/fix-mania-hold-note-rewind-visuals

  Fix osu!mania hold notes sometimes looking incorrect after rewind

  Bartłomiej Dach · 2023-06-16 20:45:40 +02:00
  b36ded0ba9
• Merge pull request #23837 from peppy/limited-distance-spacing

  Add setting to limit distance snapping to current time

  Bartłomiej Dach · 2023-06-16 20:36:08 +02:00
  26a36a023e
• Merge pull request #23943 from peppy/fps-nan

  Attempt to fix rare NaN fps display

  Salman Ahmed · 2023-06-16 21:00:13 +03:00
  e77cbc395c
• test: fix KeyCounterController not provided as a dependency
  tsrk · 2023-06-16 19:00:09 +02:00
  61101335cc
• test: adapt touch input test to changes
  tsrk · 2023-06-16 18:54:19 +02:00
  b960741ff7
• Fix fix logic causing further regression on release
  Dean Herbert · 2023-06-17 01:37:09 +09:00
  3b1f92d8b8
• Attempt to fix NaN fps display

  The only thing I can see which could cause this is reading from the `drawClock.ElapsedFrameTime` after the `isSpike` read causing a div-by-zero. Reading the values once at the start should avoid this.

  Dean Herbert · 2023-06-17 01:32:45 +09:00
  a62b11606e
• test: add skin deserialisation test resource
  tsrk · 2023-06-16 18:26:30 +02:00
  b9d6ba1934
• Merge branch 'master' into hud/kc-skinnable
  Ruki · 2023-06-16 17:30:33 +02:00
  66f44452d2
• test: change hideTarget drawable and testing logic

  Doesn't change what it needs to test conceptually

  tsrk · 2023-06-16 17:24:40 +02:00
  f9321a24d9
• Merge pull request #23922 from smoogipoo/optimise-mania-density-calc

  Optimise mania density calculation during beatmap conversion

  Bartłomiej Dach · 2023-06-16 16:56:24 +02:00
  0ee9bcfea1
• Privatise setter
  Bartłomiej Dach · 2023-06-16 16:24:07 +02:00
  28696f595f
• Merge pull request #23934 from peppy/fix-score-conversion-failures

  Fix score migration not migrating all scores properly

  Bartłomiej Dach · 2023-06-16 16:16:09 +02:00
  f79c9d711d
• Fix distance snap grid circles not correctly being centered on snap point
  Dean Herbert · 2023-06-16 17:21:32 +09:00
  d965d39c44
• Fix incorrect mapping when distance spacing is not 1.0x
  Dean Herbert · 2023-06-16 17:15:45 +09:00
  36954e55ad
• Merge branch 'master' into limited-distance-spacing
  Dean Herbert · 2023-06-16 16:56:22 +09:00
  003949ac4e
• Also move GetMaxAchievableCombo
  Dean Herbert · 2023-06-16 15:26:13 +09:00
  362aa4b376
• Move OrderByTotalScore() to an extension method
  Dean Herbert · 2023-06-16 15:24:30 +09:00
  ce41ef6e5d
• Fix osu!mania hold notes sometimes looking incorrect after rewind
  Dean Herbert · 2023-06-16 14:54:19 +09:00
  b5de109cb3
• Force migration of old-new standardised scores to run once more
  Dean Herbert · 2023-06-16 14:04:18 +09:00
  1f17f416a4
• Fix old-new standardised score conversion missing some scores due to not rounding correctly
  Dean Herbert · 2023-06-16 14:01:56 +09:00
  94b7de4b3f
• Merge pull request #23930 from bdach/fix-old-lazer-score-reimport

  Fix reimporting old lazer scores undoing standardised score recalculation

  Dean Herbert · 2023-06-16 12:47:55 +09:00
  f5eb629709
• Apply migration to new standardised score on normal reimport too
  Bartłomiej Dach · 2023-06-15 21:53:15 +02:00
  51b5a0863f
• Fix thing
  Dean Herbert · 2023-06-15 21:43:41 +02:00
  d83bf02923
• Merge pull request #23906 from Joehuu/truncate-room-name

  Truncate online play drawable room name text

  Dean Herbert · 2023-06-16 00:22:04 +09:00
  6f0c8c286b
• Merge pull request #22239 from Feodor0090/registration-loc

  Login and registration localisation

  Dean Herbert · 2023-06-15 23:58:22 +09:00
  e587d3f4f2
• Merge branch 'master' into hud/kc-skinnable
  Ruki · 2023-06-15 15:48:43 +02:00
  aba8219d06
• fix: correct key counter position in Triangles and Legacy skins
  tsrk · 2023-06-15 14:37:38 +02:00
  9d688733ac
• Optimise mania density calculation during beatmap conversion
  Dan Balasescu · 2023-06-15 20:00:15 +09:00
  145530035c