51150 Commits

This Branch

This Branch

All Branches

• Remove unused params from BDL methods
  Susko3 · 2022-01-15 01:06:39 +01:00
  19467e58c1
• Merge pull request #16452 from Susko3/tcs-xamarin

  Fix `osu.Game.Tests.Android` not building

  Dean Herbert · 2022-01-15 03:52:00 +09:00
  48498cf8a1
• Fix osu.Game.Tests.Android not building
  Susko3 · 2022-01-14 17:37:58 +01:00
  9af9155e66
• Fix custom keybindings not working due to incorrect use of IsManaged flag
  Dean Herbert · 2022-01-15 01:22:48 +09:00
  2984f2f6c4
• Fix importer not considering that some EF beatmaps have no local metadata
  Dean Herbert · 2022-01-14 23:31:42 +09:00
  2f2c498477
• Remove pointless Metadata set
  Dean Herbert · 2022-01-14 23:27:33 +09:00
  8d4a3cc569
• Remove unnecessary null check and associated comment
  Dean Herbert · 2022-01-14 23:26:29 +09:00
  e558fd69d2
• Remove outdated comment
  Dean Herbert · 2022-01-14 21:40:35 +09:00
  9900a3f408
• Update one more mismatched test implementation
  Dean Herbert · 2022-01-14 21:39:42 +09:00
  289ae7c72f
• Add local ContextFactory caching to all remaining test scenes that create local managers
  Dean Herbert · 2022-01-14 19:59:21 +09:00
  a59dcccab7
• Remove left-over methods in MusicController
  Dean Herbert · 2022-01-14 19:55:49 +09:00
  3a95425a9e
• Remove unnecessary Live conversion in IntroScreen (handled by GetWorkingBeatmap)
  Dean Herbert · 2022-01-14 19:55:09 +09:00
  7acd1b545f
• Only copy across Hash and ID so statistics aren't lost
  Dean Herbert · 2022-01-14 18:22:52 +09:00
  34dbde6023
• Add audio feedback for host change in multiplayer
  Jamie Taylor · 2022-01-14 18:11:00 +09:00
  7e9b5dd150
• Fix watch replay button not working immediately after playing
  Dean Herbert · 2022-01-14 18:03:06 +09:00
  916b591b1b
• Reduce number of redundant control points displayed on summary timeline

  As pointed out in https://github.com/ppy/osu/discussions/16435, beatmaps
  with too many control points (usually added via external automation
  apps) could cause the lazer editor to grind to a halt.
  
  The overheads here are mostly from the GL side. An eventual goal would
  be to render this in a smarter way, rather than using thousands of
  drawables. Until that, this optimisation should help reduce the overhead
  by omitting control points in close proximity that are redundant for
  display purposes.
  
  I've tried to contain this in the display logic directly, with the goal
  that it can be ripped out as fast as it was added. Certainly required
  more changes than I hoped for, but I don't think it's too ugly.

  Dean Herbert · 2022-01-14 17:13:26 +09:00
  c64a919a9d
• Merge pull request #16442 from peppy/fix-multiplayer-chat-polling

  Fix chat poll rate being too low in multiplayer lobby and gameplay

  Dan Balasescu · 2022-01-14 13:52:37 +09:00
  70f56cd0c9
• Return immediately on failed web request in synchronous BeatmapOnlineLookupQueue flow
  Dean Herbert · 2022-01-14 13:20:51 +09:00
  dea2e1fac0
• Remove unused cancellationToken parameter in synchronous BeatmapOnlineLookupQueue flow
  Dean Herbert · 2022-01-14 13:19:00 +09:00
  8424d86e9a
• Ensure detached when performing model Clone operations on BeatmapInfo/ScoreInfo
  Dean Herbert · 2022-01-14 13:08:20 +09:00
  9b33fbbee5
• Merge pull request #16443 from nekodex/fail-volume-dip

  Add volume dip to track during fail sequence

  Dean Herbert · 2022-01-14 12:31:22 +09:00
  9936cdbd65
• Update resources
  Dean Herbert · 2022-01-14 11:54:50 +09:00
  55b027228f
• Merge pull request #16420 from bdach/slider-paste-parsing-failures-2

  Fix pasted sliders having sample points with time at infinity

  Dean Herbert · 2022-01-13 23:28:49 +09:00
  eb5f15a77e
• Fix delete/clear scores buttons not working
  Dean Herbert · 2022-01-13 18:38:38 +09:00
  54804ebfbd
• Remove one more unnecessary Detach operation
  Dean Herbert · 2022-01-13 18:32:59 +09:00
  c33fe7bcc6
• Add volume dip to track during fail sequence
  Jamie Taylor · 2022-01-13 18:31:32 +09:00
  c6ae255326
• Uncomment EF deletion lines in migrations
  Dean Herbert · 2022-01-13 18:28:00 +09:00
  2840a71dda
• Merge branch 'master' into realm-integration/score-and-beatmaps
  Dean Herbert · 2022-01-13 18:25:09 +09:00
  4f8d29c1c0
• Add EF to realm beatmap migration
  Dean Herbert · 2022-01-13 18:23:18 +09:00
  b610d2db12
• Add EF to realm score migration
  Dean Herbert · 2022-01-13 18:23:18 +09:00
  45a23e5a43
• Move RulesetStore construction earlier in process so rulesets are available for EF migration
  Dean Herbert · 2022-01-13 18:23:18 +09:00
  ded1d87739
• Remove pointless compatibility parameter BeatmapSetInfoID
  Dean Herbert · 2022-01-13 18:02:10 +09:00
  069d6d2954
• Reduce polling rate when idle even if HighPollRate is requested
  Dean Herbert · 2022-01-13 17:33:55 +09:00
  4012ef7e7b
• Log chat polling rate changes
  Dean Herbert · 2022-01-13 17:31:59 +09:00
  46d2f305b5
• Increase chat polling rate during multiplayer lobby / games
  Dean Herbert · 2022-01-13 17:31:49 +09:00
  0bd34253e7
• Reduce exposure of ChannelManager
  Dean Herbert · 2022-01-13 17:10:48 +09:00
  2de0c34bc9
• Merge pull request #16273 from Joehuu/fix-remaining-identifier-names

  Normalise more identifier names

  Dean Herbert · 2022-01-13 17:06:57 +09:00
  7147799895
• Fix scores not using correct filename/display strings

  I've updated all cases where we should have been using
  `GetDisplayString()` anyway, but left the `ToString()` implementations
  in place for safety. They should probably be removed in the future.

  Dean Herbert · 2022-01-13 16:56:11 +09:00
  c61419dfe5
• Add synchronous fetch flow to BeatmapOnlineLookupQueue

  The async flow doesn't work great with the realm import process. We
  might be able to improve on this going forward, but for the time being
  adding a synchronous path seems safest.
  
  After all, we are already an an asynchronous (dedicated) thread pool at
  this point.

  Dean Herbert · 2022-01-13 16:36:54 +09:00
  93c78253d6
• Remove async from Populate method
  Dean Herbert · 2022-01-13 16:36:54 +09:00
  bdb2979b2e
• Remove pointless override method in RealmArchiveModelManager
  Dean Herbert · 2022-01-13 16:27:12 +09:00
  70c107b434
• Remove oudated comments
  Dean Herbert · 2022-01-13 15:27:43 +09:00
  88145dedf1
• Fix filter criteria not being applied after carousel loads new beatmap sets
  Dean Herbert · 2022-01-13 15:08:51 +09:00
  6025fe325d
• Fix typo in comment in IntroScreen
  Dean Herbert · 2022-01-13 13:47:23 +09:00
  0a133c7e97
• Fix deleted scores not being cleaned up on next startup
  Dean Herbert · 2022-01-13 13:40:09 +09:00
  dcc354aa7c
• Bump realm schema version to allow upgrades
  Dean Herbert · 2022-01-13 13:28:46 +09:00
  7a81fe19f6
• Use ctor rather than MemberwiseClone to guarantee a safer clone of BeatmapDifficulty
  Dean Herbert · 2022-01-13 13:23:41 +09:00
  b77cb344d5
• Remove unnecessary Ruleset null check in BeatmapDifficultyCache
  Dean Herbert · 2022-01-13 13:19:49 +09:00
  86b2ac3217
• Add back PerformRead return safety by checking IsManaged status of returned data
  Dean Herbert · 2022-01-13 13:14:44 +09:00
  7baff18764
• Fix stray bracket
  Dean Herbert · 2022-01-13 13:03:57 +09:00
  085893c9b4