1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-15 02:08:21 +08:00
Commit Graph

10236 Commits

Author SHA1 Message Date
Bartłomiej Dach
a42992d3fd
Remove unused local variable 2023-07-16 17:10:26 +02:00
Bartłomiej Dach
72bf43e297
Add failing test covering exit dialog crash 2023-07-16 16:55:20 +02:00
Bartłomiej Dach
cdbb6f90be
Merge pull request #24199 from peppy/revert-to-default-design-change
Update design of "revert to default" button
2023-07-13 23:44:24 +02:00
Bartłomiej Dach
ff56e35093
Merge pull request #24197 from peppy/allow-autoplay-failure
Allow autoplay to fail
2023-07-13 23:44:07 +02:00
Bartłomiej Dach
e7dbe3c938
Fix broken test 2023-07-13 22:28:26 +02:00
Bartłomiej Dach
cef0dd1d61
Merge pull request #24190 from novialriptide/emoji-fix
Replace emoji unicode with `[emoji]`
2023-07-13 22:05:12 +02:00
Bartłomiej Dach
6b9dabbd3c
Rewrite test scene to show non-themed and themed variants 2023-07-13 21:54:30 +02:00
Bartłomiej Dach
ae7ed697ec
Adjust failing test after permitting autoplay and no fail combo 2023-07-13 21:22:48 +02:00
Bartłomiej Dach
4859b8c994
Add some extra text coverage against potential emoji-to-link misparses 2023-07-13 20:51:52 +02:00
Bartłomiej Dach
9b771ee798
Merge pull request #24202 from peppy/save-preset-on-select
Allow saving changes to mod presets using enter key
2023-07-13 19:50:16 +02:00
Bartłomiej Dach
4b06b6f34e
Crudely fix crashes when switching between TestResultsWithPlayer cases
In the visual test browser, if two `TestResultsWithPlayer` test cases
are ran consecutively, the second would die on `SoloStatisticsWatcher`
seeing duplicated online score IDs. This surfaced after
6ef39b87fe, which changed
`TestResultsScreen` to inherit `SoloResultsScreen` rather than
`ResultsScreen`.

This is probably _not_ a very good fix, but I'm trying to be pragmatic
for now. `SoloStatisticsWatcher` should probably not live in
`OsuGameBase`.
2023-07-13 19:06:02 +02:00
Dean Herbert
6ef39b87fe Reorder tests for testability 2023-07-13 18:12:46 +09:00
Dean Herbert
654a7057fc Add actual statistics changes to better visualise layout 2023-07-13 18:12:46 +09:00
Dean Herbert
aebbffacf2 Show online stats on TestSceneStatisticsPanel
Fix test regression
2023-07-13 18:12:37 +09:00
Dean Herbert
b7ab46d87b Add full statistics score to TestSceneResultsScreen 2023-07-13 18:12:35 +09:00
Dean Herbert
6529c810fa Change order and test population in TestSceneStatisticsPanel to give better visible results 2023-07-13 18:12:19 +09:00
Andrew Hong
71351d8982 I forgor to remove these 2023-07-13 05:06:23 -04:00
Dean Herbert
db37de45ac Allow saving changes to presets in popover using "select" binding 2023-07-13 17:53:26 +09:00
Dean Herbert
f5c472c0fe Don't hide mod select overlay when pressing select binding with no search 2023-07-13 17:50:07 +09:00
Andrew Hong
403a7aa000 0 links are expected 2023-07-13 04:28:35 -04:00
Andrew Hong
3d17a03dc6 Emojis now represented as "[emoji]" 2023-07-13 03:52:22 -04:00
Dean Herbert
94201579f6 Update design of "revert to default" button
I keep getting feedback that the old design looked like anything *but* a
button to revert defaults. Including people clicking it expecting
opposite behaviour.

This is intended to be a temporary design until we get the full new UI
components online (where this is moved to the right-hand-side).
2023-07-13 14:26:03 +09:00
Dean Herbert
1bfe5a18cb Rename RestoreDefaultValueButton to RevertToDefaultButton
Because I can't find it every time I search.
2023-07-13 13:46:50 +09:00
Andrew Hong
f44e6e510d 5 -> 4 2023-07-12 22:42:12 -04:00
Andrew Hong
3d256acfef Delete emoji test in TestLinkComplex 2023-07-12 21:40:49 -04:00
Andrew Hong
5a43de1ace Update test cases 2023-07-12 21:13:10 -04:00
Bartłomiej Dach
851e6d111a
Merge branch 'master' into verify-drain-time 2023-07-11 23:29:18 +02:00
Bartłomiej Dach
a1da0b58db
Improve negative test case without breaks too 2023-07-11 23:22:37 +02:00
Bartłomiej Dach
d927cb3f1c
Actually cover cases with breaks in tests 2023-07-11 23:21:03 +02:00
Bartłomiej Dach
9a3cb624a8
Rewrite tests to be less aggressively DRY
Four of six helper methods defined in the test were used exactly once;
the remaining two were used two times. Splitting helpers there is just
too much.
2023-07-11 23:18:52 +02:00
NiceAesth
d75887bb3b Apply feedback to tests 2023-07-11 13:40:27 +03:00
Zyf
82364b4f9f Use OsuScoreProcessor in the scoring test scene 2023-07-11 02:46:32 +02:00
NiceAesth
c972a4195c Add tests 2023-07-10 17:29:59 +03:00
Bartłomiej Dach
2af8c7bc24
Add failing test case for chat message length limit enforcement 2023-07-09 21:40:27 +02:00
Bartłomiej Dach
055e4a78f0
Merge branch 'master' into taiko-hitsounding-final-attempt 2023-07-08 18:10:04 +02:00
Bartłomiej Dach
e2aaef6663
Merge branch 'master' into no-dismiss-all-progress-notifications 2023-07-08 14:19:57 +02:00
Bartłomiej Dach
832c1c0009
Merge branch 'master' into fix-gameplay-samepl-trigger-source-rewind 2023-07-08 13:33:04 +02:00
Dean Herbert
ba0ab7383d Fix broken test nullability 2023-07-07 16:28:49 +09:00
Dean Herbert
d72765b6f8
Merge pull request #24114 from peppy/editor-save-local-score-management
Ensure scores always have the correct linked `BeatmapInfo`
2023-07-07 15:40:54 +09:00
Dean Herbert
f8be6d41f7 Play basic notification test first 2023-07-07 13:23:45 +09:00
Dean Herbert
8978f2ddd8 Remove all usage of !something!.something
aka don't mix NRT forgiving syntax with not syntax
2023-07-07 10:15:33 +09:00
Bartłomiej Dach
ae2896ba7e
Sprinkle some more null-forgiving operators 2023-07-06 22:08:48 +02:00
Dean Herbert
2e98ab0a48 Expose rewinding state of IGameplayClocks
The implementation of this requires a bit of a special case
for 0, so makes sense to implement in a central place.
2023-07-06 19:08:42 +09:00
Dean Herbert
7a3a14e50d Add sample trigger tests covering rewinding of gameplay 2023-07-06 19:08:42 +09:00
Dean Herbert
af3f9086e5 Expose rewinding state of IGameplayClocks
The implementation of this requires a bit of a special case
for 0, so makes sense to implement in a central place.
2023-07-06 14:16:31 +09:00
Dean Herbert
a98a36872e Bring realm library up-to-date 2023-07-06 13:37:43 +09:00
Dean Herbert
9ff6b3fcd3 Merge branch 'master' into editor-save-local-score-management 2023-07-06 12:28:44 +09:00
Dean Herbert
c5b949154c Merge branch 'fix-judged-fallback' into taiko-hitsounding-final-attempt 2023-07-05 18:44:27 +09:00
Dean Herbert
51b0d18c04 Fix weird test assertion output 2023-07-05 18:44:27 +09:00
Dean Herbert
7355a6a66b Add test coverage of Judged state 2023-07-05 18:44:27 +09:00