Bartłomiej Dach
71b1fbb9d0
Merge pull request #27383 from Detze/slider-border-thickness
...
Rewrite legacy slider path rendering to match stable better
2024-02-28 10:02:46 +01:00
Sheepposu
7687ab63ed
fix code formatting
2024-02-27 22:03:45 -05:00
Sheepposu
29e5f409ba
remove skinnable
...
better to add skinnable elements later
2024-02-27 21:51:54 -05:00
Salman Ahmed
b3aa9e25d2
Disable legacy slider AA for now
2024-02-27 23:18:29 +03:00
Bartłomiej Dach
bbdd85020c
Fix slider tails sometimes not dimming correctly
...
Originally noticed during review of another change:
https://github.com/ppy/osu/pull/27369#issuecomment-1966140198 .
`DrawableOsuHitObject` tries to solve the initial dimming of objects
by applying transform to a list of dimmable parts. For plain drawables
this is safe, but if one of the parts is a DHO, it is not safe,
because drawable transforms can be cleared at will.
In particular, on first use of a drawable slider,
`UpdateInitialTransforms()` would fire via `LoadComplete()` on the
`DrawableSlider`, but *then*, also via `LoadComplete()`,
the `DrawableSliderTail` would update its own state and by doing so
inadvertently clear the dim transform just added by the slider.
To fix, ensure dim transforms are applied to DHOs
via `ApplyCustomUpdateState`.
2024-02-27 11:45:03 +01:00
Bartłomiej Dach
087a2a741a
Merge pull request #27369 from Detze/incorrect-slider-head-dim
...
Fix slider head being incorrectly dimmed twice
2024-02-27 11:17:34 +01:00
Salman Ahmed
83af9dfb39
Fix aa_width being incorrect
2024-02-27 02:43:02 +03:00
Salman Ahmed
18e26e39fe
Remove SliderBorderSize for simplicity
2024-02-27 02:20:34 +03:00
Salman Ahmed
2f54775182
Add stable code references
2024-02-27 02:17:02 +03:00
Salman Ahmed
81e6a6d96a
Rewrite LegacySliderBody rendering to perfectly match stable
2024-02-27 02:11:32 +03:00
Salman Ahmed
e01722a266
Revert "Match stable's slider border thickness more closely"
...
This reverts commit 3502ec456d0131f4f6c1c9faabf01e6197a16ee1.
2024-02-27 01:30:20 +03:00
Salman Ahmed
8363c39da8
Revert "Match stable's slider border thickness perfectly"
...
This reverts commit 8032ce9225950f5fc5d6dba911833e9b3f8afa93.
2024-02-27 01:30:20 +03:00
Detze
8032ce9225
Match stable's slider border thickness perfectly
2024-02-26 18:37:27 +01:00
Detze
3502ec456d
Match stable's slider border thickness more closely
2024-02-26 04:36:09 +01:00
Dean Herbert
e8d2abc4f7
Merge pull request #27364 from EVAST9919/spinner-alloc
...
Reduce osu spinner allocations
2024-02-25 09:36:02 +08:00
Dean Herbert
e12f8c03ee
Reset lastRecord on resetState for good measure
2024-02-25 08:18:19 +08:00
Detze
91d7bd1026
Don't dim slider head in DrawableSlider
2024-02-24 21:56:44 +01:00
Andrei Zavatski
9e90f7fb0d
Store last enqueued RotationRecord in SpinnerSpmCalculator
2024-02-24 20:36:06 +03:00
Andrei Zavatski
1fb19e7129
Reduce allocations in DrawableSpinner
2024-02-24 20:18:30 +03:00
Dean Herbert
a3429986bc
Merge branch 'master' into spinner-stutter
2024-02-25 00:13:48 +08:00
Dean Herbert
824d671cce
Simplify implementation
2024-02-25 00:12:20 +08:00
Andrei Zavatski
2696620d12
Completely remove transform flow for spm counter
2024-02-24 17:09:49 +03:00
Andrei Zavatski
4bba0eaf4b
Remove repeated TimeStarted check
2024-02-24 16:42:44 +03:00
Andrei Zavatski
9b526912e9
Fix incorrect operator
2024-02-24 16:41:53 +03:00
Andrei Zavatski
e7d8ca3292
Fix Argon and Trianles spinner stutter
2024-02-24 14:22:34 +03:00
Sheepposu
822ecb7106
remove unnecessary changes
2024-02-23 23:52:17 -05:00
Sheepposu
8cdd9c9ddc
skinning changes
...
improve default design
2024-02-23 23:46:50 -05:00
Sheepposu
c95e85368f
remove old files
2024-02-23 23:45:58 -05:00
Sheepposu
4d669c56a2
implement pooling
...
Uses pooling for all analysis objects and creates the lifetime entries from replay data when the analysis container is constructed.
2024-02-23 23:32:35 -05:00
Andrei Zavatski
31dabaefaa
Reduce smoke allocations
2024-02-23 18:21:11 +03:00
Sheepposu
2a1fa8ccac
fix OsuAnalysisSettings text not updating
2024-02-22 22:34:38 -05:00
Sheepposu
45444b39d4
fix formatting issues
2024-02-22 19:01:52 -05:00
Salman Ahmed
bbf3f6b56c
Fix old-style legacy spinner fade in not matching stable
2024-02-22 16:31:13 +03:00
Sheepposu
af13389a9e
fix hit marker skinnables
2024-02-22 07:31:56 -05:00
Sheepposu
35b89966bc
revert mod visibility toggle
2024-02-21 23:23:40 -05:00
TextAdventurer12
0db910deb9
cap each note at adding 1 difficult strain count
2024-02-22 15:20:32 +13:00
TextAdventurer12
7d34542c12
use difficulty instead of topstrain
2024-02-22 15:14:56 +13:00
Dean Herbert
1f4ab7a0e8
Merge branch 'slider-input-alloc' into update-framework
2024-02-21 21:45:14 +08:00
Bartłomiej Dach
cd1acf1ef9
Merge pull request #27288 from peppy/fix-follow-circle-animation
...
Fix classic skin follow circles animating from incorrect starting point
2024-02-21 10:53:56 +01:00
Dean Herbert
a137fa5480
Fix classic skin follow circles animating from incorrect starting point
2024-02-21 15:43:53 +08:00
Dean Herbert
a11a83ac48
Improve comment regarding scale adjust of approach circles
2024-02-21 13:44:04 +08:00
Dean Herbert
86e3b597b4
Fix LegacyApproachCircle incorrectly applying scaling factor
2024-02-21 13:18:51 +08:00
Sheepposu
1d552e7c90
move skin component logic
2024-02-20 22:28:25 -05:00
Andrei Zavatski
3791ab30c4
Reduce allocations in HitCircleOverlapMarker
2024-02-19 20:55:43 +03:00
Andrei Zavatski
29900353d9
Reduce allocations in SliderSelectionBlueprint
2024-02-19 20:26:15 +03:00
Andrei Zavatski
3059ddf3b2
Fix allocations in SliderInputManager
2024-02-19 01:08:40 +03:00
Andrei Zavatski
572f693eec
Fix failing tests related to slider ticks
2024-02-17 23:28:35 +03:00
Dean Herbert
0df6e8f595
Remove list allocations in UpdateNestedSamples
2024-02-18 03:23:34 +08:00
Dean Herbert
0714a4fc1e
Revert sample lookup logic that was not allocating anything
2024-02-18 03:18:50 +08:00
Andrei Zavatski
22f5a66c02
Reduce allocations during beatmap selection
2024-02-17 15:46:38 +03:00
