75266 Commits

This Branch

This Branch

All Branches

• Revert unnecessary inheritance

  Everyone is right, too much inheritance and polymorphism backfires very badly.

  Salman Alshamrani · 2025-01-25 19:12:37 -05:00
  8151c3095d
• Be explicit on nullability in RequiresPortraitOrientation

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Alshamrani · 2025-01-25 19:12:36 -05:00
  dac7d21302
• Various refactorings and cleanups
  Dan Balasescu · 2025-01-25 19:32:59 +09:00
  ab4162e2aa
• Merge pull request #31664 from ThePooN/ios-non-exempt-encryption

  🔧 Specify we're not using non-exempt encryption

  Salman Alshamrani · 2025-01-24 13:00:08 -05:00
  129ab03ec4
• 🔧 Specify we're not using non-exempt encryption
  ThePooN · 2025-01-24 18:14:55 +01:00
  354126b7f7
• Merge pull request #31652 from peppy/beatmap-carousel-v2-split-panels

  Split out beatmap and set panels in  beatmap carousel v2

  Bartłomiej Dach · 2025-01-24 16:00:04 +01:00
  3c763971ff
• Add unique samples for friend online/offline notifications
  Jamie Taylor · 2025-01-24 23:20:04 +09:00
  79df094f17
• Merge branch 'master' into beatmap-carousel-v2-split-panels
  Bartłomiej Dach · 2025-01-24 15:16:23 +01:00
  092c7b4253
• Remove unused field
  Bartłomiej Dach · 2025-01-24 15:15:50 +01:00
  55ab3c72f6
• Remove selection animation on set panel
  Dean Herbert · 2025-01-24 22:45:08 +09:00
  82c5f37c2c
• Fix test failures
  Bartłomiej Dach · 2025-01-24 14:24:16 +01:00
  b0136f98a9
• Merge pull request #31645 from peppy/offset-adjust-more-lenience

  Make offset adjust more lenient

  Bartłomiej Dach · 2025-01-24 14:01:25 +01:00
  7845c5cfb7
• Refactor further to avoid weird non-virtual common method
  Bartłomiej Dach · 2025-01-24 13:14:31 +01:00
  daec91f61d
• Fix behavioural change in interaction between grid & distance snap
  Bartłomiej Dach · 2025-01-24 13:14:26 +01:00
  b04144df54
• Simplify code
  Bartłomiej Dach · 2025-01-24 13:14:06 +01:00
  589035c534
• Merge pull request #31623 from Layendan/room-context-menu

  Add view in browser context menu functionality to multiplayer/playlist rooms

  Dean Herbert · 2025-01-24 20:31:49 +09:00
  a94681158d
• Fix breakage from reordering co-reliant variable sets (and guard against it)
  Dean Herbert · 2025-01-24 20:20:18 +09:00
  da762384f8
• Split out beatmaps and set panels into two separate classes
  Dean Herbert · 2025-01-24 20:10:41 +09:00
  175eb82ccf
• Move pool item preparation / cleanup duties to Carousel
  Dean Herbert · 2025-01-24 20:10:41 +09:00
  0164a2e4dc
• Fix tests
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  269ade178e
• Remove IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  32d341a468
• Remove dependence of placement blueprints on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  a6987f5c95
• Remove dependence of blueprint containers on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:05 +01:00
  15b6e28ebe
• Merge pull request #31634 from peppy/beatmap-carousel-v2-selection

  Add selection support to beatmap carousel v2

  Bartłomiej Dach · 2025-01-24 11:43:17 +01:00
  2d46da1520
• Move activation drawable flow portion to ICarouselPanel
  Dean Herbert · 2025-01-24 18:40:48 +09:00
  9366bfbf0d
• Adjust comments on ICarouselPanel to imply external use
  Dean Herbert · 2025-01-24 18:34:04 +09:00
  92429b2ed9
• Merge pull request #31644 from peppy/fix-beatmap-offset-crash

  Fix potential crash when adjusting offset

  Bartłomiej Dach · 2025-01-24 10:20:29 +01:00
  2f84aec88d
• Combine countless update methods all called together into a single method
  Dean Herbert · 2025-01-24 18:00:05 +09:00
  17b1739ae4
• Merge branch 'master' into multiplayer-free-style
  Dean Herbert · 2025-01-24 17:23:35 +09:00
  1bfb4d4c2b
• Fix average button not correctly becoming disabled where it previously would
  Dean Herbert · 2025-01-24 17:17:34 +09:00
  721b2dfbba
• Merge branch 'master' into mobile-fix-mania
  Dean Herbert · 2025-01-24 17:03:00 +09:00
  56a611b47e
• Move line to correct location
  Dean Herbert · 2025-01-24 16:45:14 +09:00
  28a59f4e29
• Adjust layout and code quality slightly
  Dean Herbert · 2025-01-24 15:57:13 +09:00
  05b1002e9d
• Bypass offset disallowed status when handling realm callbacks

  Hopefully don't need to overthink this one.

  Dean Herbert · 2025-01-24 15:49:47 +09:00
  8f8a6455b4
• Add safeties against attempting to apply previous play while offset adjust is not allowed

  This should theoretically not be possible, but while we are sharing this
  control's implementation between gameplay and non-gameplay usages, let's
  ensure nothing weird can occur.

  Dean Herbert · 2025-01-24 15:49:47 +09:00
  ee78e1b223
• Consume GameplayStartTime for more lenient offset adjustments
  Dean Herbert · 2025-01-24 15:30:02 +09:00
  fb10996951
• Expose GameplayStartTime in IGameplayClock
  Dean Herbert · 2025-01-24 15:29:49 +09:00
  5cc8181bad
• Merge pull request #31640 from frenzibyte/discord-rpc-ux

  Hide Discord RPC error messages away from user attention

  Dean Herbert · 2025-01-24 14:36:13 +09:00
  4ae6dfd790
• Hide Discord RPC error messages away from user attention
  Salman Alshamrani · 2025-01-23 21:22:35 -05:00
  61a818e4ed
• Remove unused method
  Layendan · 2025-01-23 15:39:18 -07:00
  d326f23576
• Fix formatting
  Layendan · 2025-01-23 15:37:30 -07:00
  b0a7237fd6
• Inherit menu items from parent class
  Layendan · 2025-01-23 15:36:20 -07:00
  13c64b59af
• Merge pull request #31633 from bdach/thanks-for-nothing-github-actions

  Roll back windows build image to 2019 on android build job

  Dean Herbert · 2025-01-24 00:35:58 +09:00
  c3269013d9
• Simplify selection handling logic
  Dean Herbert · 2025-01-23 23:58:51 +09:00
  f4270ab3b9
• Add regions to BeatmapCarousel
  Dean Herbert · 2025-01-23 23:53:09 +09:00
  d5369d3508
• ActivateSelection -> TryActivateSelection
  Dean Herbert · 2025-01-23 22:44:39 +09:00
  0716b73d2a
• Adjust inline commentary based on review feedback
  Dean Herbert · 2025-01-23 22:41:20 +09:00
  2feab31426
• Remove unused default value
  tsunyoku · 2025-01-23 10:29:04 +00:00
  8f17a44976
• Clean up error handling
  Dan Balasescu · 2025-01-23 19:10:11 +09:00
  e9d6411e61
• Add test coverage of various selection examples

  Where possible I've tried to match the test and method names of
  `TestSceneBeatmapCarousel` for easy coverage comparison.

  Dean Herbert · 2025-01-23 18:51:25 +09:00
  eaea053c7d