75266 Commits

This Branch

This Branch

All Branches

• Fix sort direction being flipped
  Dean Herbert · 2025-01-23 18:51:24 +09:00
  ffca90779f
• Tidy up tests in preparation for adding more
  Dean Herbert · 2025-01-23 18:51:24 +09:00
  9ab045495d
• Add selection and activation flow
  Dean Herbert · 2025-01-23 18:51:24 +09:00
  2f94456a06
• Add set-difficulty tracking in BeatmapCarouselFilterGrouping

  Rather than tracking inside individual items, let's just maintain a
  single dictionary which is refreshed every time we regenerate filters.

  Dean Herbert · 2025-01-23 18:48:44 +09:00
  ecef5e5d71
• Make CarouselItem sealed and remove BeatmapCarouselItem concept

  Less abstraction is better. As far as I can tell, we don't need a custom
  model for this. If there's any tracking to be done, it should be done
  within `BeatmapCarousel`'s implementation (or a filter).

  Dean Herbert · 2025-01-23 18:48:44 +09:00
  980f6cf18e
• Move Selected status to drawables

  Basically, I don't want bindables in `CarouselItem`. It means there
  needs to be a bind-unbind process on pooling. By moving these to the
  drawable and just updating every frame, we can simplify things a lot.

  Dean Herbert · 2025-01-23 18:48:43 +09:00
  c67c0a7fc0
• Merge pull request #31632 from peppy/beatmap-carousel-v2-cleanups

  Initial carousel additions in preparation for selection logic

  Bartłomiej Dach · 2025-01-23 10:43:12 +01:00
  beaadfa1fa
• Fix incorrect exception handling

  In particular, when the exception is:
  `AggregateException { AggregateException { HubException } }`,
  then the existing code will only unwrap the first aggregate exception.
  
  The overlay's code was copied from the extension so both have been
  adjusted here.

  Dan Balasescu · 2025-01-23 18:32:19 +09:00
  6dbf466009
• Fix incorrect continuation
  Dan Balasescu · 2025-01-23 18:25:55 +09:00
  f2d8ea2997
• Roll back windows build image to 2019 on android build job

  Per workaround suggested in
  https://github.com/actions/runner-images/issues/11402#issuecomment-2596473501.
  
  Applying this now as my hopes for a swift resolution without changes on
  our side are slim to none (read thread linked above in full to learn
  why).

  Bartłomiej Dach · 2025-01-23 10:12:30 +01:00
  b4e8a17f03
• Add comment indicating RoomManager shouldn't exist
  Dan Balasescu · 2025-01-23 17:18:01 +09:00
  a198b0830a
• Rename methods
  Dan Balasescu · 2025-01-23 16:27:38 +09:00
  7c38089c75
• Adjust + fix tests
  Dan Balasescu · 2025-01-23 16:27:38 +09:00
  9a623257f5
• displayedCarouselItems -> carouselItems
  Dean Herbert · 2025-01-23 15:58:35 +09:00
  ded1d9f019
• Only show loading when doing a user triggered filter
  Dean Herbert · 2025-01-23 15:51:54 +09:00
  d526835627
• Reorder carousel methods into logical regions
  Dean Herbert · 2025-01-23 15:50:57 +09:00
  6ac2dbc818
• Show selection defaults in test scene (and make prettier)
  Dean Herbert · 2025-01-23 15:50:40 +09:00
  8657576210
• Fix formatting
  Layendan · 2025-01-22 11:42:11 -07:00
  f673d16a1f
• Merge pull request #31509 from bdach/local-metadata-cache-corruption

  Refetch local metadata cache if corruption is detected

  Dean Herbert · 2025-01-23 02:43:14 +09:00
  bf23c67603
• Keep old behaviour of double.PositiveInfinity being the default for Interval
  tsunyoku · 2025-01-22 13:26:12 +00:00
  753e9ef7c7
• Fix incorrect namespace
  tsunyoku · 2025-01-22 13:24:30 +00:00
  2c0d6b14c8
• Join/Leave rooms via multiplayer server

  Relevant functionality has been removed from `RoomManager` in the
  process.

  Dan Balasescu · 2025-01-22 21:44:45 +09:00
  02369baec4
• Merge pull request #31616 from bdach/fix-new-combo-button-crash

  Fix crash from new combo colour selector when there are no combo colours present

  Dan Balasescu · 2025-01-22 20:48:02 +09:00
  11e84f325c
• Fix crash from new combo colour selector when there are no combo colours present

  Closes https://github.com/ppy/osu/issues/31615.

  Bartłomiej Dach · 2025-01-22 11:39:32 +01:00
  3da220b8f6
• Merge pull request #31588 from minetoblend/feature/paste-snapped

  Snap to beat divisor when pasting hitobjects in editor

  Dean Herbert · 2025-01-22 18:38:12 +09:00
  218720bca5
• Apply NRT to new class
  Dean Herbert · 2025-01-22 18:36:13 +09:00
  c94b8bf051
• Adjust code again to avoid weird throw mishandling
  Dean Herbert · 2025-01-22 18:24:01 +09:00
  6ceb348cf6
• Merge pull request #31603 from peppy/input-amendments

  Tidy up various input handling anomalies

  Dan Balasescu · 2025-01-22 18:05:06 +09:00
  63e6b0e050
• Merge pull request #31604 from peppy/fix-song-select-right-click-handling

  Fix song select right click handling

  Bartłomiej Dach · 2025-01-22 10:00:03 +01:00
  2623d8dcac
• Merge pull request #31613 from peppy/friend-notifications-bug-less

  Make friend notifications less prominent

  Dan Balasescu · 2025-01-22 17:34:23 +09:00
  631ae90130
• Remove outdated ef related catch-when usage
  Dean Herbert · 2025-01-22 17:04:30 +09:00
  26ef23c9a9
• Adjust code style slightly
  Dean Herbert · 2025-01-22 17:03:01 +09:00
  910c0022e3
• Mark friend notifications as non-important
  Dean Herbert · 2025-01-22 16:41:27 +09:00
  9e023340b0
• Switch IsImportant to init property isntead of virtual
  Dean Herbert · 2025-01-22 16:41:26 +09:00
  4cf4b8c73d
• Add transient flag for notifications which shouldn't linger in history
  Dean Herbert · 2025-01-22 16:41:26 +09:00
  fde2b22bbc
• Add context menu to open in browser to rooms
  Layendan · 2025-01-21 12:45:23 -07:00
  2a5a2738e1
• Replace weird IntervalGroupedHitObjects inheritance layer
  tsunyoku · 2025-01-21 15:58:33 +00:00
  14c68bcc58
• Revert Precision.DefinitelyBigger usage
  tsunyoku · 2025-01-21 15:01:32 +00:00
  1c4bc6dffd
• Fix typo in ColourEvaluator
  tsunyoku · 2025-01-21 14:56:51 +00:00
  764b0001ef
• Make rescale a static method
  tsunyoku · 2025-01-21 14:33:40 +00:00
  e0882d2a53
• Rename rhythm preprocessing objects to be clearer with intent
  tsunyoku · 2025-01-21 14:29:07 +00:00
  20a76d832d
• Add xmldoc to explain IHasInterval.Interval
  tsunyoku · 2025-01-21 14:28:15 +00:00
  ef8867704a
• Refactor StaminaEvaluator
  tsunyoku · 2025-01-21 14:25:28 +00:00
  b8c79d58a7
• Format ReadingEvaluator
  tsunyoku · 2025-01-21 14:24:46 +00:00
  9919179b0b
• Refactor ColourEvaluator
  tsunyoku · 2025-01-21 14:24:27 +00:00
  dbe36887f6
• Remove EffectiveBPMPreprocessor
  tsunyoku · 2025-01-21 14:24:04 +00:00
  fa20bc6631
• Perform client side validation that the selected beatmap and ruleset have valid online IDs

  This is local to playlists, since in multiplayer the validation is
  already provided by `osu-server-spectator`.

  Dean Herbert · 2025-01-21 19:51:55 +09:00
  459847cb80
• Reapply "Fix triangles judgement mispositioned on a miss"

  This reverts commit 6ec718304e.

  Salman Alshamrani · 2025-01-21 05:45:37 -05:00
  b63d94101c
• Configure awaiters
  Dan Balasescu · 2025-01-21 19:31:51 +09:00
  001d9cacf2
• Add test scene for clipboard snapping
  Marvin Schürz · 2025-01-21 11:02:41 +01:00
  cc7c549468