75266 Commits

This Branch

This Branch

All Branches

• Merge pull request #33723 from peppy/loading-spinner-visual-pass

  Visual pass on loading spinner

  Dan Balasescu · 2025-06-16 22:04:01 +09:00
  4dc16736dd
• Merge pull request #33725 from peppy/fix-random-button-crash

  Fix crash when random and rewind are run on the same frame

  Dan Balasescu · 2025-06-16 22:01:08 +09:00
  999c08e377
• Change mod category to Conversion
  CloneWith · 2025-06-16 19:28:57 +08:00
  5a315a7f52
• Fix crash when random and rewind are run on the same frame
  Dean Herbert · 2025-06-16 20:17:07 +09:00
  10c07fdf50
• Add back random button tests
  Dean Herbert · 2025-06-16 19:59:30 +09:00
  05a50f523c
• Fix incorect masking when displayed at small sizes
  Dean Herbert · 2025-06-16 19:50:12 +09:00
  42e7a69db6
• Fix failing test
  Dean Herbert · 2025-06-16 19:39:37 +09:00
  13df477fc0
• Ensure editor is loaded in more places

  While I can't reproduce any test failures because of this, I can
  reproduce exceptions by simply running the tests with debugger attached.
  
  There's one other similar related test failure in `TestSingleAudioFile`
  but that appears to be an o!f issue.

  Dan Balasescu · 2025-06-16 16:29:10 +09:00
  18195120ae
• Adjust condition to be more thorough
  Dan Balasescu · 2025-06-16 16:21:27 +09:00
  54ef42a09e
• Visual pass on loading spinner

  Fixes regression mentioned
  [here](https://github.com/ppy/osu/pull/33509#issuecomment-2951271131).
  
  Adjust visuals and metrics slightly.

  Dean Herbert · 2025-06-16 15:47:57 +09:00
  c888431201
• Attempt to fix flaky editor test
  Dan Balasescu · 2025-06-16 15:36:55 +09:00
  74a173cdfd
• Merge pull request #33698 from frenzibyte/difficulty-slider-localisation

  Add localisation support to difficulty range slider

  Dean Herbert · 2025-06-15 23:49:14 +09:00
  2025.616.0-tachyon 1741b02dc2
• Merge pull request #33683 from bdach/blocking-not-terrible

  Add block / unblock options to chat and user profile overlay

  Salman Alshamrani · 2025-06-14 16:27:07 +03:00
  baab4479da
• Adjust user actions popover design
  Salman Alshamrani · 2025-06-14 15:46:10 +03:00
  32285f4560
• Remove unnecessary DI
  Salman Alshamrani · 2025-06-14 15:45:49 +03:00
  b2e936c430
• Add localisation support to difficulty range slider
  Salman Alshamrani · 2025-06-14 15:05:05 +03:00
  977c26d02f
• Concat incompatible mods list for Autoplay and Relax
  CloneWith · 2025-06-14 00:30:09 +08:00
  c0993f812e
• Add simple test scene for HoldToWalk mod
  CloneWith · 2025-06-13 23:58:31 +08:00
  2e9e39e123
• Don't check for updates in DEBUG
  Dan Balasescu · 2025-06-13 22:54:41 +09:00
  5ef3b372ae
• Dispose the last CTS
  Dan Balasescu · 2025-06-13 22:51:25 +09:00
  3be57b90db
• Resolve warnings in tests
  Dan Balasescu · 2025-06-13 22:36:32 +09:00
  4f5c9f9713
• Remove no-longer existing argument

  I'm not entirely sure how this works, but CI was testing against the
  updated Velopack package, whereas my local package was outdated and had
  4 args.
  
  Previous commit merges master to update the package version, this commit
  fixes the args.

  Dan Balasescu · 2025-06-13 22:13:07 +09:00
  819decde76
• Merge branch 'master' into package-manager-tachyon
  Dan Balasescu · 2025-06-13 22:11:30 +09:00
  1ba702b7ad
• Add block / unblock option to user profile overlay

  This is not doing the thing that the website does wherein the entire
  user profile is replaced by the message that the user is blocked if
  they're blocked. Someone else can try doing that.
  
  I'm also not adding report button to this because it's going to be
  annoying to make happen because currently reporting is only available as
  a popover and not as a dialog. Someone else can pick that up as well.

  Bartłomiej Dach · 2025-06-13 14:53:18 +02:00
  b47988e899
• Add block / unblock option to chat
  Bartłomiej Dach · 2025-06-13 14:53:07 +02:00
  7690d96b73
• Move blocking / unblocking logic to reusable location
  Bartłomiej Dach · 2025-06-13 14:52:56 +02:00
  101044d7d8
• Allow cancelling from initial notification
  Dan Balasescu · 2025-06-13 21:47:08 +09:00
  5f4a9d8e81
• Rewrite UpdateManager to handle cancellations
  Dan Balasescu · 2025-06-13 20:34:31 +09:00
  addd10f4c6
• Merge pull request #33680 from peppy/make-release-streams-work-in-version

  Add support for reading and displaying the release stream suffix

  Bartłomiej Dach · 2025-06-13 12:52:18 +02:00
  70db766c2a
• Transfer release stream setting from running build
  Dean Herbert · 2025-06-13 18:52:33 +09:00
  62ec0a15d8
• Add support for reading release stream from assembly version
  Dean Herbert · 2025-06-13 18:52:22 +09:00
  3291a4cb7b
• Fix SHOCKING test

  What the actual heck is that magic number stupidity.
  
  I'm not looking into why the test falls over so badly that it apparently
  dies on some main menu logic just because assertions fail, because the
  main menu logic is for hold-to-song-select-v2 and is thus temporary.

  Bartłomiej Dach · 2025-06-13 10:34:14 +02:00
  f4bf2ae7a5
• Fix code quality
  Bartłomiej Dach · 2025-06-13 10:06:44 +02:00
  dc38c190df
• Ensure partial failed replays are played to their end

  Closes https://github.com/ppy/osu/issues/24285.
  
  This is not a perfect solution, as it is still possible for a replay to
  play *beyond* its end if the HP system doesn't fail it after it runs out
  of frames, but it's probably the best that can be done at this time.
  
  Notably this removes existing F rank checks because they were really not
  reliable.
  
  - Scores coming from stable will never present F rank, because rank is
    not stored to the replay, and the lowest rank that can be produced by
    `StandardisedScoreMigrationTools` is D.
  
  - lazer scores set prior to https://github.com/ppy/osu/pull/28058 will
    present F rank as long as the user has kept them in their local
    database and never exported and reimported them, for the same reason
    as above (rank not stored to replay). Also there have been many
    mechanics changes since, so it's not impossible for the replay to fail
    *before* the user actually did even in this case.
  
  - lazer scores set after https://github.com/ppy/osu/pull/28058 could
    technically rely on F rank but making them rely on it is annoying for
    several reasons:
  
    - The PR in question didn't bump `LegacyScoreEncoder.LATEST_VERSION`,
      so any checks based on the replay version field would be
      half-reliable anyway.
  
    - *Even after* the above, the replay version is only stored to realm
      as `TotalScoreVersion`, which *then gets bumped* on score version
      upgrades. So it can't even be used for any checks from that angle,
      you'd have to decode it from the score.
  
    - You *could* use `ClientVersion` because that's somewhat reliable,
      but that's stored *as string*, so you'd have to do some snipping to
      split off the `-lazer` suffix, then parse the version, then compare
      it. I started going through the motions of that before deciding that
      this is an edge case of an edge case and probably not worth spending
      time over the simple and obvious solution of just doing away with
      the rank check. Until I'm proven wrong, I guess.

  Bartłomiej Dach · 2025-06-13 09:21:38 +02:00
  73a1f10daf
• Adjust implementation of star rating filtering in song select to new star rating flooring behaviour

  Required for things to not be broken after the previous change.

  Bartłomiej Dach · 2025-06-13 09:13:20 +02:00
  eda489b911
• Floor star rating to 2 decimal places rather than rounding

  Rounding semi-regularly confuses users who aim for star rating pass / FC
  medals and then feel they have been cheated out of a medal because they
  passed an "X-star beatmap", but the actual star rating of the beatmap is
  slightly under X.
  
  The latest instance of this can be found at
  https://osu.ppy.sh/community/forums/topics/2091333?n=2. The relevant
  beatmap there is https://osu.ppy.sh/beatmapsets/2162554#osu/4746232,
  whose raw star rating is 6.9976070253117344.
  
  The other direction would be to fix the star rating medals instead, but
  I think this is more reasonable given we already do similar things to
  accuracy displays.

  Bartłomiej Dach · 2025-06-13 09:11:06 +02:00
  4fd2a488b7
• Add failing test scene
  Bartłomiej Dach · 2025-06-12 14:03:52 +02:00
  e59f9b1aa7
• Add support for toggling current group expansion using shift-enter

  Closes https://github.com/ppy/osu/issues/33617.

  Dean Herbert · 2025-06-12 20:36:02 +09:00
  52ba22ca1f
• Fix textbox shift-left/right conflicting with new group changing bindings
  Dean Herbert · 2025-06-12 20:36:02 +09:00
  f82cb6d767
• Add support for traversing between groups using shift-left/right

  Closes https://github.com/ppy/osu/issues/33599.

  Dean Herbert · 2025-06-12 20:36:02 +09:00
  3816c5d95f
• Merge pull request #33667 from peppy/carousel-tests-better-wait

  Ensure filtering is always waited on after a sort/filter change in tests

  Bartłomiej Dach · 2025-06-12 13:29:13 +02:00
  d934e574b2
• Merge pull request #33666 from peppy/fix-carousel-test-failure

  Fix carousel tests failing randomly depending on order run

  Bartłomiej Dach · 2025-06-12 13:27:50 +02:00
  800af304e7
• Ensure filtering is always waited on after a sort/filter change in tests
  Dean Herbert · 2025-06-12 19:45:06 +09:00
  d592b984e3
• Add all beatmaps in one go in tests to avoid hundreds of callbacks

  Just makes debugging easier.

  Dean Herbert · 2025-06-12 19:45:06 +09:00
  054544818c
• Give better feedback from test assertion

  There's a flaky test and currently the fail output it not really
  helpful. This makes it slightly more relevant.

  Dean Herbert · 2025-06-12 19:45:06 +09:00
  7dba17f6b8
• Merge pull request #33657 from nekodex/legacy-rank-change-sfx

  Add support for rank change SFX to `LegacyRankDisplay`

  Dean Herbert · 2025-06-12 19:41:28 +09:00
  85f0e85718
• Fix carousel tests failing randomly depending on order run
  Dean Herbert · 2025-06-12 19:23:27 +09:00
  7e632193f8
• Merge pull request #33660 from peppy/more-robust-logo-operations

  Use `IDisposable` flow for common logo tracking/proxy operations for better robustness

  Bartłomiej Dach · 2025-06-12 12:03:17 +02:00
  e258244caf
• Merge pull request #33630 from peppy/leaderboard-always-expand-setting

  Add a skin-level setting to leaderboard to allow disabling automatic collapsing

  Bartłomiej Dach · 2025-06-12 11:16:17 +02:00
  d13676fcc6
• Delete redundant string interpolation
  Bartłomiej Dach · 2025-06-12 11:10:43 +02:00
  ee696e32f0