75266 Commits

This Branch

This Branch

All Branches

• Merge pull request #33629 from peppy/ssv2-reveal-background

  Add ability to reveal background when long pressing in empty space

  Bartłomiej Dach · 2025-06-12 11:09:01 +02:00
  66c80ccb16
• Pick better initial beatmap status when submitting

  Addresses https://github.com/ppy/osu/discussions/33291
  
  This is a half-baked RFC because things are awkward.
  
  For this to work correctly the submission flow has to do an API request,
  because one, the local beatmap status has been overwritten with "locally
  modified", and secondly, even if it *was* there, there's no guarantee
  that it was actually *up to date*.
  
  And if we have to do an API request then there are two choices:
  
  - Hard block on the API request and don't show anything until it
    completes which possibly means waiting at a spinner for several
    seconds if someone's on bad internet.
  
  - Don't block on the API request --- but then there's no guarantee
    what timing the API request completes at, which means that possibly the
    user could change the dropdown before the API request completes, and
    the API request will overwrite their choice, so to prevent that block
    the dropdown until the request completes. This is what this commit
    does.

  Bartłomiej Dach · 2025-06-12 10:38:22 +02:00
  a38e25115b
• Fix incorrect text spacing in skin editor toolbar

  Probably regressed with framework flow changes.

  Dean Herbert · 2025-06-12 17:33:23 +09:00
  ba31cb4786
• Localise new setting
  Dean Herbert · 2025-06-12 17:30:11 +09:00
  612f853baa
• Combine two similar flags into one
  Dean Herbert · 2025-06-12 17:27:23 +09:00
  ebfc3c9ccf
• Always return previous tracking state before taking out a new tracking operation
  Dean Herbert · 2025-06-12 17:13:35 +09:00
  7cdc296c9c
• Fix carousel drags being incorrectly handled as background reveal
  Dean Herbert · 2025-06-12 16:48:29 +09:00
  968b5b0082
• Remove leftover xmldoc
  Bartłomiej Dach · 2025-06-12 09:32:53 +02:00
  8c0e535d41
• Add missing last sample playback update
  Jamie Taylor · 2025-06-12 15:45:28 +09:00
  2b0f1bfc4b
• Merge pull request #33639 from peppy/ssv2-renames

  Move and rename next/previous "group" selection keybindings to make way for group-specific bindings

  Bartłomiej Dach · 2025-06-12 08:42:11 +02:00
  37e8cc9afc
• Update logo proxy operations to use IDisposable flow
  Dean Herbert · 2025-06-12 15:19:26 +09:00
  a8be9d7b64
• Update logo tracking operations to use IDisposable flow
  Dean Herbert · 2025-06-12 15:18:38 +09:00
  435128ebaa
• Merge pull request #33626 from peppy/offset-control-use-last-valid

  Allow using previous valid score for offset calibration when subsequent retries are too short

  Bartłomiej Dach · 2025-06-12 07:55:35 +02:00
  f1bd63769b
• Add support for rank change SFX to LegacyRankDisplay and debouncing
  Jamie Taylor · 2025-06-12 14:42:29 +09:00
  b729091244
• Merge pull request #33638 from frenzibyte/ssv2-leaderboard-masked-away

  Fix partially displayed leaderboard scores looking wrong when resizing game

  Dean Herbert · 2025-06-12 14:04:51 +09:00
  2db7d34a0b
• Adjust tests based on changed behaviour

  Calibration no longer goes away on missing / invalid scores.

  Dean Herbert · 2025-06-11 22:47:47 +09:00
  90877a079c
• Disable when using touch input
  Dean Herbert · 2025-06-11 22:28:50 +09:00
  fc5ea7f3f2
• Move and rename next/previous "group" selection keybindings to make way for group-specific bindings
  Dean Herbert · 2025-06-11 21:02:52 +09:00
  b9e1b6969e
• Remove outer grid container to avoid masked-away issues
  Salman Alshamrani · 2025-06-11 14:51:21 +03:00
  9a9cbcdd26
• Merge pull request #33632 from peppy/ssv2-back-button-clickability

  Fix corner clicks not activating back button at new song select

  Dan Balasescu · 2025-06-11 19:39:39 +09:00
  2b605c1d01
• Merge pull request #33634 from bdach/playlists-leaderboards

  Add support for showing gameplay leaderboard in playlists and daily challenge

  Dan Balasescu · 2025-06-11 19:25:07 +09:00
  0e37a563d4
• Merge pull request #33628 from peppy/ssv2-add-back-scrollbar-padding

  Add back scrollbar padding in new beatmap carousel

  Bartłomiej Dach · 2025-06-11 11:31:06 +02:00
  7a12a7c9a2
• Add support for showing leaderboard in playlists and daily challenge

  As touched on in https://github.com/ppy/osu/pull/33581.

  Bartłomiej Dach · 2025-06-11 11:21:26 +02:00
  4810c7c847
• Increase hitbox for footer back button

  Based on countless feedback of users wanting to be able to throw their
  mouse into the corner of the screen to go back. It makes sense.

  Dean Herbert · 2025-06-11 18:00:22 +09:00
  70a5474489
• Add setting to leaderboard to allow disabling automatic collapsing

  Was a 2 minute implementation, so why not?
  
  Addresses https://github.com/ppy/osu/discussions/33523.

  Dean Herbert · 2025-06-11 17:36:56 +09:00
  04871fe55a
• Add ability to reveal background when long pressing in empty space

  As touched on in https://github.com/ppy/osu/discussions/33624.
  
  Maybe fine as a bit of an easter egg?

  Dean Herbert · 2025-06-11 17:19:33 +09:00
  edf62baae8
• Move InternalChild assignment into BDL
  marvin · 2025-06-11 10:15:54 +02:00
  0cbc5e3593
• Make check task non-nullable

  Keeping unnecessary nullables around is a pet-peeve of mine. This
  simplifies things.

  Dan Balasescu · 2025-06-11 16:51:03 +09:00
  9f133ac997
• Remove per-frame check for transform
  marvin · 2025-06-11 09:48:51 +02:00
  e495843267
• Add comment explaining mouse position handling
  marvin · 2025-06-11 09:47:39 +02:00
  18979d0ed4
• Expand tests to perform a second check

  To ensure it doesn't get stuck in a state where new checks aren't
  performed.

  Dan Balasescu · 2025-06-11 16:47:05 +09:00
  359e3ac8a5
• Partial classes
  Dan Balasescu · 2025-06-11 16:43:32 +09:00
  981cf62c23
• Adjust UpdateManager to keep a check stream

  There are two primary paths here:
  1. A user requests an update. The existing request is used if it's in
  progress, or a new request is made and processed immediately.
  2. Something is changed (e.g. the release stream) that triggers a
  background request. A new request is made to run after the existing one.

  Dan Balasescu · 2025-06-11 16:40:23 +09:00
  e2d8c39388
• Add tests
  Dan Balasescu · 2025-06-11 16:37:31 +09:00
  41d4d55f22
• Add back scrollbar padding in new beatmap carousel

  Closes https://github.com/ppy/osu/issues/33447. Implementation copied
  from previous carousel.

  Dean Herbert · 2025-06-11 16:34:04 +09:00
  cfd73cc900
• Adjust commentary to not suck

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-06-11 15:55:08 +09:00
  38ad48bb35
• Merge pull request #33598 from peppy/ssv2-difficulty-traversal-selection

  Allow changing difficulties using up and down arrows when sets are grouped

  Bartłomiej Dach · 2025-06-11 08:34:10 +02:00
  932ba3d590
• Allow using previous valid score for offset calibration when subsequent retries are too short

  As proposed in https://github.com/ppy/osu/discussions/33572.
  
  Note that this won't work if you leave to song select. We could make
  that work but it would require further global faffing and I don't think
  it's worth the effort.

  Dean Herbert · 2025-06-11 15:26:02 +09:00
  cdb2f216f2
• Merge pull request #33625 from Joehuu/version-keyword-release-stream

  Add "version" keyword to release stream setting

  Dan Balasescu · 2025-06-11 14:04:52 +09:00
  4b8ac8a565
• Add "version" keyword to release stream setting
  Joseph Madamba · 2025-06-10 20:35:43 -07:00
  16f7140254
• Address review comments
  Tom Martin · 2025-06-11 04:34:13 +01:00
  33905f2e70
• Maintain scroll position relative to hovered drawable in ExpandingToolboxContainer
  marvin · 2025-06-10 21:31:32 +02:00
  cad389722e
• Merge pull request #33616 from bdach/fix-ticks-not-updating-again

  Fix timeline not updating ticks correctly after arbitrary timing control point changes (again)

  Dean Herbert · 2025-06-10 22:19:39 +09:00
  85eef1bc3a
• Fix incorrect equality check
  Dean Herbert · 2025-06-10 21:58:43 +09:00
  b16cb1ae58
• Merge pull request #33610 from bdach/solo-results-show-local

  Fix results screen not showing local scores on results screen for some beatmap statuses

  Dean Herbert · 2025-06-10 21:50:39 +09:00
  a5ad09385f
• Fix timeline not updating ticks correctly after arbitrary timing control point changes (again)

  Closes https://github.com/ppy/osu/issues/33393.
  
  This is admittedly a half-assed diff. This was apparently "fixed" once
  before, eons ago, in https://github.com/ppy/osu/pull/11032, but I'm not
  sure whether it regressed, or where, because I don't want to bisect four
  years back. (At that time `ControlPointInfo.ControlPointsChanged`
  did not exist yet.)
  
  Also there's the part where changes to control points do not undo or
  redo (see https://github.com/ppy/osu/issues/31942), but I'm not touching
  that *either*, because if I start touching that, then I will get yelled
  at for not reviewing the 2.5k line PR that rewrites the entirety of
  change handling in editor instead
  (https://github.com/ppy/osu/pull/30314). I will attempt to get through
  that mental block sometime within the year. Please do not rush me.
  
  The cheap cop-out argument is that hooking this up to `ControlPointInfo`
  specifically is probably "more efficient" anyway.

  Bartłomiej Dach · 2025-06-10 14:44:23 +02:00
  f5aeedc7e1
• Fix lack of slider encode-decode stability due to truncating control point coordinates

  Mostly closes https://github.com/ppy/osu/issues/33505.
  
  Compare
  
  	https://github.com/ppy/osu/blob/97e6187f0d7c3dbee896596a623e34627135bf0e/osu.Game/Rulesets/Objects/Legacy/ConvertHitObjectParser.cs#L56-L59
  
  I say "mostly" here because I'm rather skeptical that this is 100% rock
  solid still, for one reason - namely that the game stores path control
  point coordinates relative to the head, then turns them into absolute
  coordinates when encoding, and then on decoding turns them back into
  coordinates relative to the head, which in floating-point world is a Bad
  Idea because of round-off error. But I'm not fixing that without
  introducing a completely new beatmap format or rewriting half the
  editor to address that, so I'll just pretend that I don't know any
  of this until someone notices.

  Bartłomiej Dach · 2025-06-10 14:09:13 +02:00
  eab02a2aa5
• Add failing test case
  Bartłomiej Dach · 2025-06-10 13:49:09 +02:00
  26bbc3202a
• Do not attempt to add displayed score to list of sorted scores more than once

  This is a very dodgy fix, but it fixes an edge case that has so far - to
  my knowledge - not been reported by users in the wild, only by me trying
  to break things, so my hope is that we can do this and move on for now.

  Bartłomiej Dach · 2025-06-10 12:32:03 +02:00
  c84988a2ec
• Fix stable scores importing with a LegacyOnlineID of 0

  Closes https://github.com/ppy/osu/issues/33435.
  
  The root cause of the issue is that the user's database contained a
  whole lot of scores with `LegacyOnlineID` of 0, which would trip up
  
  	https://github.com/ppy/osu/blob/97e6187f0d7c3dbee896596a623e34627135bf0e/osu.Game/Extensions/ModelExtensions.cs#L128-L129
  
  as that method would thus consider scores that are not the same as the
  same because of the zero, which later trips up
  
  	https://github.com/ppy/osu/blob/97e6187f0d7c3dbee896596a623e34627135bf0e/osu.Game/Screens/Ranking/SoloResultsScreen.cs#L79
  
  which ends up inserting `Score` into the list several times, which
  causes the crash.
  
  You might remember that I tried to fix this once before in
  https://github.com/ppy/osu/pull/24794. What I did not realise, however,
  is that stable *can still produce replays* that have an online ID of
  zero in them, because zero *is just `default(long)`*:
  
  	https://github.com/peppy/osu-stable-reference/blob/7205341bb70000a87fa1bd54e7642772e2af85d7/osu!/GameplayElements/Scoring/Score.cs#L123
  	https://github.com/peppy/osu-stable-reference/blob/7205341bb70000a87fa1bd54e7642772e2af85d7/osu!/GameplayElements/Scoring/Score.cs#L350
  
  The alternative way of fixing this would be just to change
  `MatchesOnlineID` to reject zeroes, but I think this is a saner overall
  direction.

  Bartłomiej Dach · 2025-06-10 11:54:11 +02:00
  d4fc6693b4