h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-31 01:00:51 +08:00
Code Issues Releases Wiki Activity

Merge pull request #33616 from bdach/fix-ticks-not-updating-again

Browse Source 
Fix timeline not updating ticks correctly after arbitrary timing control point changes (again)
This commit is contained in:
Dean Herbert
2025-06-10 22:19:39 +09:00
committed by GitHub
Unverified
parent a5ad09385f f5aeedc7e1
commit 85eef1bc3a
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/Edit/Compose/Components/Timeline/TimelineTickDisplay.cs
+4 -8
View File
@@ -5,6 +5,7 @@ using System;
using osu.Framework.Allocation;
using osu.Framework.Bindables;
using osu.Framework.Caching;
using osu.Framework.Extensions.ObjectExtensions;
using osu.Framework.Graphics;
using osu.Game.Beatmaps;
using osu.Game.Configuration;
@@ -31,9 +32,6 @@ namespace osu.Game.Screens.Edit.Compose.Components.Timeline
[Resolved]
private BindableBeatDivisor beatDivisor { get; set; } = null!;
[Resolved]
private IEditorChangeHandler? changeHandler { get; set; }
[Resolved]
private OsuColour colours { get; set; } = null!;
@@ -51,9 +49,7 @@ namespace osu.Game.Screens.Edit.Compose.Components.Timeline
{
beatDivisor.BindValueChanged(_ => invalidateTicks());
if (changeHandler != null)
// currently this is the best way to handle any kind of timing changes.
changeHandler.OnStateChange += invalidateTicks;
beatmap.ControlPointInfo.ControlPointsChanged += invalidateTicks;
configManager.BindWith(OsuSetting.EditorTimelineShowTimingChanges, showTimingChanges);
showTimingChanges.BindValueChanged(_ => invalidateTicks());
@@ -194,8 +190,8 @@ namespace osu.Game.Screens.Edit.Compose.Components.Timeline
{
base.Dispose(isDisposing);
if (changeHandler != null)
changeHandler.OnStateChange -= invalidateTicks;
if (beatmap.IsNotNull())
beatmap.ControlPointInfo.ControlPointsChanged -= invalidateTicks;
}
}
}