75266 Commits

This Branch

This Branch

All Branches

• Merge pull request #30231 from SchiavoAnto/skin-editor-ui-localisation

  Allow more localisation in skin editor

  Bartłomiej Dach · 2024-10-16 09:17:45 +02:00
  5fff632c9f
• Fix migration not checking combination properly
  Bartłomiej Dach · 2024-10-16 08:17:22 +02:00
  f8a13b0beb
• Formatting
  jhk2601 · 2024-10-15 16:27:05 -04:00
  bf970afddb
• Fix an issue where changing the CircleSize wouldn't adjust the catcher size and represent hyperdashes incorrectly
  Darius Wattimena · 2024-10-15 21:47:22 +02:00
  b75437ee13
• Code quality touch-ups
  jhk2601 · 2024-10-15 15:37:05 -04:00
  f6566f9157
• Merge pull request #30219 from bdach/scale-with-no-axes-should-do-nothing

  Ensure at least one scale popover axis is active at any time

  Dean Herbert · 2024-10-16 04:31:45 +09:00
  8e76dd553e
• Merge branch 'master' into scale-with-no-axes-should-do-nothing
  Bartłomiej Dach · 2024-10-15 14:20:24 +02:00
  b92cbff81d
• Ensure at least scale popover axis toggle is active at any time

  As in, toggling off an axis if it is the only one enabled will enable
  the other one in turn.
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-10-15 14:12:17 +02:00
  634f20e8de
• Terminate existing anchor create operation when object is deselected
  Bartłomiej Dach · 2024-10-15 12:54:11 +02:00
  232301f27d
• Terminate existing anchor drag operations when object is deselected
  Bartłomiej Dach · 2024-10-15 12:53:40 +02:00
  1a7acbac33
• Add failing test case for second tool switching failure case

  Not exact (doesn't reproduce the crash), but will do.

  Bartłomiej Dach · 2024-10-15 12:53:38 +02:00
  2d0e98c951
• Add failing test case for first tool switch failure scenario
  Bartłomiej Dach · 2024-10-15 12:39:08 +02:00
  0cd352cdcb
• Remove handling for zero as MaxSizeComboCount, set lower limit as 5
  jhk2601 · 2024-10-15 02:23:41 -04:00
  86a5760ef4
• Merge https://github.com/ppy/osu into std_mod_bloom
  jhk2601 · 2024-10-15 02:15:46 -04:00
  28879529db
• Refactors handling of scale to a function
  jhk2601 · 2024-10-15 02:14:03 -04:00
  bd71da012a
• Add tests covering expected behaviour when going on/off compose area
  Salman Alshamrani · 2024-10-14 15:12:09 -04:00
  0fa1d22210
• Extend test cases to cover direct interaction (i.e. no touch-compose-area-first)
  Salman Alshamrani · 2024-10-14 15:12:09 -04:00
  14c6cfc365
• Fix coding mistake
  Salman Alshamrani · 2024-10-14 15:11:44 -04:00
  e151c0fab1
• Only keep track of the names of hit results to display in a ScoreTable
  Jonas Brandstötter · 2024-10-14 16:55:07 +02:00
  a007a81fe8
• Sum up totals for hit results with the same name
  Jonas Brandstötter · 2024-10-14 16:33:30 +02:00
  285756802c
• Correct typo
  Jonas Brandstötter · 2024-10-14 16:16:00 +02:00
  511f0e99b3
• Correct reference to hit result and link to them
  Jonas Brandstötter · 2024-10-14 16:14:29 +02:00
  25c0ff4168
• Revert 9cd7f2b and fc1ebfd
  schiavoanto · 2024-10-14 16:14:23 +02:00
  d7021f989b
• Use ChildrenOfType<> to get ScoreTable to test
  Jonas Brandstötter · 2024-10-14 16:11:58 +02:00
  750e0b29ca
• Merge pull request #30277 from bdach/fix-shuffle-more

  Fix shuffle not actually changing the track sometimes

  Dean Herbert · 2024-10-14 23:09:13 +09:00
  790f863e06
• migrate clearance of conflicting ToggleFPSDisplay keybind
  Leander Furumo · 2024-10-14 16:03:29 +02:00
  035e5a9613
• Move conditional
  Salman Alshamrani · 2024-10-14 09:55:24 -04:00
  40b98d4863
• Loop track even if shuffling if there is only one available

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-10-14 15:28:32 +02:00
  8cec318c1f
• Fix flip operations sometimes not preserving selection

  Closes https://github.com/ppy/osu/issues/30250.

  Bartłomiej Dach · 2024-10-14 14:50:01 +02:00
  59655a1830
• Add failing tests
  Bartłomiej Dach · 2024-10-14 14:48:07 +02:00
  98141430b0
• Remove no longer required nested object reposition hacks

  As touched on in
  https://github.com/ppy/osu/issues/30237#issuecomment-2408557766, these
  types of maneouvers are no longer required after
  https://github.com/ppy/osu/pull/30021 - although as it turns out on
  closer inspection, these things being there still *did not actually
  break anything*, because the `slider.Path` mutation at the end of
  `modifySlider()` causes `updateNestedPositions()` to be called
  eventually anyway. So this is at mostly a code quality upgrade.

  Bartłomiej Dach · 2024-10-14 14:26:27 +02:00
  1f1a174c50
• Fix strict tracking mod not populating path progress for ticks/repeats

  Closes https://github.com/ppy/osu/issues/30237.
  
  This is the root failure in the issue, and one that *only* presents when
  another conversion mod that repositions the objects is also active. That
  makes the `PathProgress` of the nesteds to be zero, therefore making
  them occupy the position of the slider head after any mutation to the
  path.

  Bartłomiej Dach · 2024-10-14 14:26:27 +02:00
  275b86cd3c
• Add test covering correct operation of mirror mod
  Bartłomiej Dach · 2024-10-14 14:21:00 +02:00
  945d907a3d
• Fix shuffle not actually changing the track sometimes

  See https://github.com/ppy/osu/pull/30215#issuecomment-2407775408 for
  context.
  
  Turns out the test failures were more correct than I'd thought. The
  long-and-short of it is that both in "pure random" mode and in
  "permutation" mode, when running out of track history to fall
  back on, it was possible for the random algorithm to pick the same song
  twice in a row - which is probably not desired, and which this explicit
  exclude should make impossible.

  Bartłomiej Dach · 2024-10-14 13:18:45 +02:00
  17aed26f85
• Merge pull request #30274 from shinmorisawa/master

  Respect "Prefer metadata in original language" toggle in beatmap deletion dialog

  Bartłomiej Dach · 2024-10-14 12:02:03 +02:00
  639eb7ae4a
• Merge branch 'master' into master
  Shin Morisawa · 2024-10-14 17:48:04 +09:00
  8ff86d560f
• Merge pull request #30261 from peppy/faster-quick-retry

  Decrease the time it takes to quick retry by ~650 ms

  Bartłomiej Dach · 2024-10-14 10:24:35 +02:00
  120eb9adea
• Merge branch 'master' into master
  Shin Morisawa · 2024-10-14 16:46:44 +09:00
  0664b185c3
• Merge branch 'master' into feat/optimize-polygon-tool
  Bartłomiej Dach · 2024-10-14 08:28:30 +02:00
  cd59b93cc9
• Merge pull request #30080 from OliBomby/clamp-scale2

  Clamp scale with lower and upper bounds

  Bartłomiej Dach · 2024-10-14 08:17:22 +02:00
  74675c8c78
• minor changes
  jhk2601 · 2024-10-14 01:54:02 -04:00
  1a142ff944
• Fix Beatmap Delete Dialog
  Shin Morisawa · 2024-10-14 09:55:28 +09:00
  90a08b8a68
• Switch colour scheme to blue
  smallketchup82 · 2024-10-13 19:40:06 -04:00
  15c7a12174
• replace empty keybinding array with input key type of None
  Leander Furumo · 2024-10-14 00:00:45 +02:00
  379794c462
• remove default keybind for toggling fps counter
  Leander Furumo · 2024-10-13 22:50:58 +02:00
  0e768cc517
• Merge pull request #30239 from rozukke/reset-offsets

  Add functionality to mass reset offsets

  Dean Herbert · 2024-10-14 01:56:14 +09:00
  f8bce706fa
• change fps toggle keybind
  Leander Furumo · 2024-10-13 17:36:06 +02:00
  8f1fbb44c4
• Only update beatmaps which actually had offsets

  Without this every beatmap gets a write and it reloads the whole of song
  select, basically.

  Dean Herbert · 2024-10-14 00:35:18 +09:00
  53671ad11e
• Fix placement blueprints not receiving latest mouse position with touch input
  Salman Alshamrani · 2024-10-13 11:01:18 -04:00
  f8c8184c5c
• Add failing test cases
  Salman Alshamrani · 2024-10-13 11:01:17 -04:00
  86b240d131