75266 Commits

This Branch

This Branch

All Branches

• Start preparing player earlier when quick retrying

  Should help with https://github.com/ppy/osu/issues/9039.

  Dean Herbert · 2024-10-13 22:29:00 +09:00
  868a7db9e9
• Overwrite downloaded data packages

  In https://github.com/ppy/osu/actions/runs/11311858931/job/31458581002, I cancelled the run during the download from `data.ppy.sh`.
  
  In https://github.com/ppy/osu/actions/runs/11313128285/job/31461534857, `wget` skipped downloading the file due to the `-nc` option (no-clobber), i.e.: if the file exists, don't re-download.
  
  The only way I'm aware of to resolve this with wget is to either use `-c` (continue), which may lead to broken files, or to explicitly specify the output file via `-O`. Thought I'd clean up a few pieces in the process.
  
  Why not curl? Mostly historical - some distros don't come with curl. It may be okay now but there's probably no point changing this at the moment...

  Dan Balasescu · 2024-10-13 18:43:02 +09:00
  9681e3ac46
• Merge pull request #30246 from Joehuu/recommend-csdevkit-instead

  Recommend C# Dev Kit extension on VSCode

  Dan Balasescu · 2024-10-13 15:02:03 +09:00
  9abca53829
• Switch overlay colour scheme to purple

  Figured this made sense since we're using purple buttons. It doesn't
  really seem to change anything visually though

  smallketchup82 · 2024-10-12 21:06:25 -04:00
  ca5a74df26
• Switch to using an overlay interface for skin mounting
  smallketchup82 · 2024-10-12 20:39:33 -04:00
  44fe7f2a44
• Revert "remove score debugging code I accidentally left in"

  This reverts commit 5192599543.

  finadoggie · 2024-10-12 16:53:32 -07:00
  6bcfed8963
• remove score debugging code I accidentally left in
  finadoggie · 2024-10-12 16:45:34 -07:00
  5192599543
• only assign countLargeTickMiss for slider accuracy scores

  helps indicate it should only be used for slider acc scores

  finadoggie · 2024-10-12 15:36:42 -07:00
  88af57818c
• consolidated if statements for getting effectiveMissCount and countSliderEndsDropped
  finadoggie · 2024-10-12 15:34:04 -07:00
  29b1697a70
• Join variable assignments with declarations
  finadoggie · 2024-10-12 15:30:02 -07:00
  3ac6a9f0ae
• Remove a comment
  smallketchup82 · 2024-10-12 17:15:48 -04:00
  3d16e45d79
• Group HitResults with the same name into one column in beatmap ranking

  Closes #29911

  Jonas Brandstötter · 2024-10-12 22:53:08 +02:00
  dcd3e5194e
• Recommend C# Dev Kit extension on VSCode
  Joseph Madamba · 2024-10-12 12:12:40 -07:00
  e1e8e39a89
• Merge branch 'master' into skin-mounting
  smallketchup82 · 2024-10-12 13:22:30 -04:00
  942efce78b
• Add functionality to mass reset offsets
  Artemis Rosman · 2024-10-13 00:50:45 +11:00
  e4f9c861ba
• Merge pull request #30218 from bdach/daily-challenge-conclusion-offline

  Do not show daily challenge conclusion notification on disconnection

  Dan Balasescu · 2024-10-12 18:14:22 +09:00
  2de1955892
• Convert estimateSliderEndsDropped assignment into '?:' expression

  I would just like to say that I don't know why anyone would ever want this but github told me to do it

  finadoggie · 2024-10-12 01:08:39 -07:00
  3b517e03aa
• Update to use variable usingClassicSliderAccuracy
  finadoggie · 2024-10-12 01:00:15 -07:00
  b921424461
• Merge branch 'ppy:master' into estimation-removal
  Fina · 2024-10-12 00:44:13 -07:00
  3d7f4aec99
• Smoother size changing using linear interpolation
  jhk2601 · 2024-10-11 21:52:13 -04:00
  4d367515dc
• Make TernaryStateRadioMenuItem localisable
  Joseph Madamba · 2024-10-11 18:48:04 -07:00
  71b08b54c1
• Fix layers dropdown localised entries
  schiavoanto · 2024-10-12 02:00:51 +02:00
  fc1ebfdf64
• Use LocalisableDescription for skin editor layers dropdown
  schiavoanto · 2024-10-12 01:38:52 +02:00
  9cd7f2b5d4
• Add more localisation in skin editor
  schiavoanto · 2024-10-12 00:55:33 +02:00
  1e7e2e0b1c
• Initial Implementation (working, unsafe handling of cursor position)
  jhk2601 · 2024-10-11 18:38:53 -04:00
  0794fc61a0
• Explicitly assert specific grid type
  OliBomby · 2024-10-11 23:57:26 +02:00
  9f73a45580
• Fix typo
  Marvin Schürz · 2024-10-11 23:49:52 +02:00
  40339b8a17
• Restore previous NewCombo state when adding objects
  Marvin Schürz · 2024-10-11 23:41:57 +02:00
  767ded4326
• Make sure to properly update hitobjects
  Marvin Schürz · 2024-10-11 23:22:15 +02:00
  f76a2d02f6
• Revert "Add a toggle for checking overwriting"

  This reverts commit b7883f18be.

  smallketchup82 · 2024-10-11 16:15:57 -04:00
  0dc77a70e1
• Fix off-by-one error
  Marvin Schürz · 2024-10-11 22:03:21 +02:00
  9e97141e33
• Rename oldskin
  smallketchup82 · 2024-10-11 14:50:51 -04:00
  2b7eb5626c
• Make everything translatable
  smallketchup82 · 2024-10-11 14:50:51 -04:00
  ee16c964dc
• Add a toggle for checking overwriting

  The GetFile method in AddFile has a huge overhead, given we're doing
  this in a loop.
  
  Since we clear the files in the skin, we already know there won't be any
  existing files, so we can skip all of that logic

  smallketchup82 · 2024-10-11 14:50:48 -04:00
  b7883f18be
• Abstract out logic to SkinImporter
  smallketchup82 · 2024-10-11 14:50:26 -04:00
  a20bd5cc3d
• Fix changes not being applied instantly, Improve import performance, lay down framework for abstracting logic
  smallketchup82 · 2024-10-11 14:50:23 -04:00
  9de248f5d7
• Initial implementation
  smallketchup82 · 2024-10-11 13:27:09 -04:00
  4d09e94367
• Inline scheduler calls
  Marvin Schürz · 2024-10-11 19:24:46 +02:00
  8e781c170d
• Update test
  Dean Herbert · 2024-10-12 02:23:43 +09:00
  8b046f60f0
• Fix bindings being clobbered
  Dean Herbert · 2024-10-12 02:19:02 +09:00
  b62d9f8696
• Simplify cycle logic
  Dean Herbert · 2024-10-12 02:18:36 +09:00
  05c8b3cbce
• Change shortcut to Shift+G
  Dean Herbert · 2024-10-12 02:18:08 +09:00
  d07a2fbb57
• Merge pull request #30215 from bdach/fix-music-controller

  Fix track restarting when trying to switch track change direction with shuffle active

  Dean Herbert · 2024-10-12 01:41:44 +09:00
  3a8ed889b5
• Fix scale popover doing things when both scale axes are turned off

  Spotted in passing when reviewing https://github.com/ppy/osu/pull/30080.
  The popover would very arbitrarily revert to scaling by Y axis if both
  checkboxes were checked off.
  
  Not sure how this passed review.

  Bartłomiej Dach · 2024-10-11 15:18:43 +02:00
  4e8e4a34bd
• Merge branch 'master' into clamp-scale2
  Bartłomiej Dach · 2024-10-11 15:13:54 +02:00
  5db1f05953
• Rename methods to fit new changes better
  Bartłomiej Dach · 2024-10-11 15:03:30 +02:00
  d1da1d4079
• Add positive assertion for conclusion notification being present too
  Bartłomiej Dach · 2024-10-11 14:31:30 +02:00
  07d15cc35a
• Do not show daily challenge conclusion notification on disconnection

  Closes https://github.com/ppy/osu/issues/30194.

  Bartłomiej Dach · 2024-10-11 14:18:19 +02:00
  968835bb44
• Add failing test
  Bartłomiej Dach · 2024-10-11 14:16:24 +02:00
  9d1eb842a7
• Rename "Cycle grid display mode" to "Cycle grid spacing"

  The "display mode" is easy to confuse with grid type, so I renamed it to literally the grid property it affects.

  OliBomby · 2024-10-11 14:09:50 +02:00
  550e575221