202 Commits

• Fix potential nullref due to silly null handling and too much OOP
  Dean Herbert · 2025-01-14 19:03:58 +09:00
  3ddff19337
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-07-23 12:09:32 +09:00
  d707e29ff7
• Fix storyboard sprites leaving gaps on edges when resolving from an atlas
  Salman Ahmed · 2024-07-17 14:47:17 +03:00
  c4141fff07
• Implement toggling visibility of pass and fail storyboard layers

  Closes https://github.com/ppy/osu/issues/6842.
  
  This is a rather barebones implementation, just to get this in place
  somehow at least. The logic is simple - 50% health or above shows pass
  layer, anything below shows fail layer.
  
  This does not match stable logic all across the board because I have
  no idea how to package that. Stable defines "passing" in like fifty
  ways:
  
  - in mania it's >80% HP
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Rulesets/Mania/RulesetMania.cs#L333-L336)
  - in taiko it's >80% *accuracy*
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Rulesets/Taiko/RulesetTaiko.cs#L486-L492)
  - there's also the part where "geki additions" will unconditionally set
    passing state
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Player.cs#L3561-L3564)
  - and also the part where at the end of the map, the final passing state
    is determined by checking whether the user passed more sections than
    failed
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Player.cs#L3320)
  
  The biggest issues of these are probably the first two, and they can
  *probably* be fixed, but would require a new member on `Ruleset` and I'm
  not sure how to make one look, so I'm not doing that at this time
  pending collection of ideas on how to do that.

  Bartłomiej Dach · 2024-06-14 13:59:02 +02:00
  67ca7e4135
• Move WidescreenStoryboard out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:23:53 +02:00
  1ab86ebd24
• Use sb element path as a name
  Andrei Zavatski · 2024-05-25 13:24:25 +03:00
  1e90e5e38e
• Make video sprites flippable and vector-scalable to fix type constraint errors

  Stable supports these on videos already from a quick read on code (since videos are generally a subclass of sprites).

  Salman Ahmed · 2024-05-02 00:01:50 +03:00
  6d6f165884
• Resolve post-merge-conflict issues
  Salman Ahmed · 2024-05-01 23:57:58 +03:00
  4ffeb5b469
• Merge branch 'master' into storyboard-loops-v2
  Salman Ahmed · 2024-05-01 23:46:38 +03:00
  895c09d4d1
• Actually apply transforms to the video
  Dean Herbert · 2024-04-23 17:37:37 +08:00
  17ca29c2c6
• Fix incorrect xmldoc

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2024-04-23 17:34:52 +08:00
  7eeac0f3b9
• Remove unused DI beatmap paramater
  Dean Herbert · 2024-04-22 18:45:02 +08:00
  9e7182acf0
• Allow storboard videos to take on no-relative size when specified by a mapper
  Dean Herbert · 2024-04-22 18:44:47 +08:00
  c43c383abf
• Remove unused using directive
  Salman Ahmed · 2024-03-08 23:09:16 +03:00
  8c92bb0595
• Remove leftover debugging code
  Salman Ahmed · 2024-03-08 22:37:27 +03:00
  1942d46a38
• Add generics to ApplyInitialValue/ApplyTransforms for ability to return custom transform sequences

  *sigh*

  Salman Ahmed · 2024-03-08 03:07:39 +03:00
  fa9b2f0cd5
• Apply major refactor to the storyboard commands flow structrure
  Salman Ahmed · 2024-03-08 01:10:09 +03:00
  585ab59768
• Implement StoryboardElementWithDuration
  Andrei Zavatski · 2024-03-06 00:16:06 +03:00
  8b03acd27b
• Remove unused transform extensions
  Andrei Zavatski · 2024-03-03 21:54:37 +03:00
  f5d24e6804
• Fix storyboard animations stripping path directory on skin lookup
  Salman Ahmed · 2024-01-17 18:39:48 +03:00
  5597b48882
• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Handle null texture case
  Bartłomiej Dach · 2023-09-27 11:18:38 +02:00
  e314913aeb
• Merge branch 'master' into fix-storyboard-skin-textures-lookup
  Dean Herbert · 2023-09-27 17:17:51 +09:00
  a7237e48aa
• Avoid potentially incorrect size adjustment when texture doesn't change
  Dean Herbert · 2023-09-27 17:16:45 +09:00
  3705c4c8d5
• Merge branch 'master' into limit-gameplay-sprite-dimensions
  Dean Herbert · 2023-09-26 16:40:32 +09:00
  990c54519b
• Ensure DrawableStoryboardSprite's texture size propagates corectly on skin change
  Dean Herbert · 2023-09-26 14:13:51 +09:00
  567bc8fcd3
• Merge branch 'master' into fix-storyboard-skin-textures-lookup
  Dean Herbert · 2023-09-26 14:05:27 +09:00
  2ca1c684bb
• Apply same fix to DrawableStoryboardAnimation
  Dean Herbert · 2023-09-20 12:54:36 +09:00
  b5e64d933c
• Remove incorrectly merge conflict resolved
  Dean Herbert · 2023-09-20 12:54:28 +09:00
  50adb5f7a7
• Fix DrawableStoryboardVideo attempting to unmap path once too much

  The `StoryboardResourceLookupStore` cached at storyboard level is
  supposed to already be handling that; no need for local logic anymore.

  Bartłomiej Dach · 2023-09-19 20:18:33 +02:00
  641e651bf2
• Fix StoryboardResourceLookupStore dying on failure to unmap path

  Before the introduction of `StoryboardResourceLookupStore`, missing
  files would softly fail by use of null fallbacks. After the
  aforementioned class was added, however, the fallbacks would not work
  anymore if for whatever reason `GetStoragePathFromStoryboardPath()`
  failed to unmap the storyboard asset name to a storage path.

  Bartłomiej Dach · 2023-09-19 20:11:16 +02:00
  ba518e1da8
• Fix storyboard UseSkinSprites being implemented incorrectly

  This was implemented as a "fallback", but it's actually intended to be
  an "override". As in it allows storyboarders to *prefer* a skin sprite
  before falling back to a local version contained within the storyboard.
  
  Can be tested with https://osu.ppy.sh/beatmapsets/832364#osu/1743837.
  
  Closes https://github.com/ppy/osu/issues/24813.

  Dean Herbert · 2023-09-19 20:20:20 +09:00
  4a7dc4d792
• Expose some storyboard pieces to allow better testability
  Dean Herbert · 2023-09-19 20:20:11 +09:00
  773ec46989
• Refactor storyboard resource lookup to be more streamlined
  Dean Herbert · 2023-09-14 16:15:50 +09:00
  900376b662
• Add support for limiting skin texture/animation dimensions
  Salman Ahmed · 2023-09-03 02:21:47 +03:00
  6674c70280
• Change IBeatSyncProvider.Clock to always be non-null
  Dean Herbert · 2023-07-13 22:13:40 +09:00
  20e4e2581a
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Fix storyboard video-only check being inverted
  Joseph Madamba · 2023-05-16 21:51:32 -07:00
  d6fa44240d
• Actually use new end time property when setting lifetimes
  Dean Herbert · 2023-04-26 13:28:51 +09:00
  1efc78c0f8
• Fix storyboard videos not fading out on completion

  Closes https://github.com/ppy/osu/issues/22802.
  
  Stable uses a 1,000 ms fade-in / out. Rather than matching that, I've
  stuck with 500ms (what lazer was already using for the fade-in) because
  I think it feels better.
  
  Tested using the beatmap linked in the issue thread.

  Dean Herbert · 2023-03-07 15:54:35 +09:00
  2cce785fa5
• Fix some more inspections
  Dean Herbert · 2022-12-16 20:21:19 +09:00
  192536643c
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Remove null conditional
  Salman Ahmed · 2022-09-23 17:06:55 +03:00
  835cae3087
• Fix crash when storyboard attempts to play at main menu
  Dean Herbert · 2022-09-23 20:10:57 +09:00
  4e9053b099
• Fix storyboard animations not starting their animation playback from the correct point in time
  Dean Herbert · 2022-09-12 14:05:16 +09:00
  24138b65a7
• Fix VectorScale set to 0 still showing some sprites in storyboard

  This implementation was matching the [framework side implementation of
  scale](https://github.com/ppy/osu-framework/blob/16d1c2d3356b0f59271fb49cff5fe8373ae9cdf3/osu.Framework/Graphics/Drawable.cs#L973-L976)
  but I don't think it's required here.
  
  I'm still not sure if the framework implementation is correct, but
  removing it locally does seem to fix broken storyboard cases.
  
  Closes https://github.com/ppy/osu/issues/20155.

  Dean Herbert · 2022-09-07 15:39:19 +09:00
  824e68dab3
• Move all usage of GameplayClock to IGameplayClock
  Dean Herbert · 2022-08-15 18:30:53 +09:00
  c8764cb333
• Migrate the majority of existing file lookups to use new extension methods
  Dean Herbert · 2022-08-10 16:01:16 +09:00
  ac99c1ad69
• Apply IRenderer changes
  Dan Balasescu · 2022-08-02 19:50:57 +09:00
  b4e55f7309