150 Commits

• Expose GameplayStartTime in IGameplayClock
  Dean Herbert · 2025-01-24 15:29:49 +09:00
  5cc8181bad
• Add logging for GameplayClockContainer starting or stopping
  Dean Herbert · 2024-03-06 04:37:11 +08:00
  57daaa7fed
• Remove test guarantee of audio time not advancing
  Dean Herbert · 2024-01-18 20:06:53 +09:00
  c4e9bcd140
• Cache GameplayClockContainer to allow usage of OnSeek
  Dean Herbert · 2023-12-13 16:13:08 +09:00
  110749205d
• Adjust comment to match current behaviour

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-10-10 22:54:19 +09:00
  b9dadc52b7
• Change GameplayClockContainer.Reset to directly call GameplayClock.Stop

  The reasoning is explained in the inline comment, but basically this was
  getting blocked by `isPaused` being in an initial `true` state (as it is
  on construction), while the source clock was still `IsRunning`.
  
  There's no real guarantee of sync between the source and the `isPaused`
  bindable right now. Maybe there should be in the future, but to restore
  sanity, let's ensure that a call to `Reset` can at least stop the track
  as we expect.

  Dean Herbert · 2023-10-10 18:16:14 +09:00
  f0bd975393
• Don't apply decoupling to SpectatorPlayerClocks

  See inline comment for reasoning. It's a bit complicated.

  Dean Herbert · 2023-09-22 16:22:35 +09:00
  8367bb6bee
• Set source directly in FramedBeatmapClock ctor

  This isn't required, but avoids creating a temporary `StopwatchClock`
  and generally just makes debug easier with less state changes.

  Dean Herbert · 2023-09-22 16:22:35 +09:00
  bf08fbe196
• Fix souce clock not always being transferred to FramedBeatmapClock in time
  Dean Herbert · 2023-09-22 16:22:35 +09:00
  586311d508
• Remove second hopefully-unnecessary workaround
  Dean Herbert · 2023-09-22 14:41:07 +09:00
  a1e298930c
• Disable decoupling for OsuGameBase's beatmap implementation

  This avoids it ever mutating the underlying track (aka attempting to start
  it). Resolves the one caveat mentioned in
  aeef92fa710648d4a00edc523e13c17ac6104125.

  Dean Herbert · 2023-09-22 12:49:25 +09:00
  df08c4e1ad
• Update usage of DecoupleableInterpolatingFramedClock in FramedBeatmapClock
  Dean Herbert · 2023-09-22 12:49:25 +09:00
  117cd74af6
• Change FramedBeatmapClock to always be decoupled
  Dean Herbert · 2023-09-22 12:49:25 +09:00
  600651795b
• Update clocks in line with framework changes
  Dean Herbert · 2023-09-20 21:17:08 +09:00
  bf984388b3
• Fix typo in comment
  Bartłomiej Dach · 2023-08-16 10:07:12 +02:00
  add1ef77d0
• Use CurrentTime instead of StartTime for hotfix seek (and update comment)
  Dean Herbert · 2023-08-16 16:38:49 +09:00
  bb98f10ff6
• Fix multiplayer spectator potentially taking too long to start

  When watching from the middle of gameplay, due to a series of failures,
  `SpectatorClock` would not get seeked to the current time, causing all
  clients to look like they were out of sync.
  
  This is a hotfix for the issue. A better fix will require framework
  changes or considerable restructuring.
  
  I'd recommend testing this works in practice and agreeing that while it
  is a hack, it's likely not going to cause issues and is something we
  want to see fixed sooner rather than later.

  Dean Herbert · 2023-08-02 19:05:43 +09:00
  87fee001c7
• Expose rewinding state of IGameplayClocks

  The implementation of this requires a bit of a special case
  for 0, so makes sense to implement in a central place.

  Dean Herbert · 2023-07-06 19:08:42 +09:00
  2e98ab0a48
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Rename GameplayAdjustments -> AdjustmentsFromMods
  Dan Balasescu · 2022-09-08 17:14:06 +09:00
  b559d4ecdf
• Apply proposed changes to remove inheritance from MasterGameplayClockContainer
  Dean Herbert · 2022-09-07 17:49:05 +09:00
  75d0deef72
• Change NonGameplayAdjustments to GameplayAdjustments and convert TrueGameplayRate to extension method
  Dean Herbert · 2022-09-06 22:26:46 +09:00
  bc1212f4e6
• Use new flow to calcaulate TrueGameplayRate
  Dean Herbert · 2022-09-05 23:37:49 +09:00
  266eb758aa
• Add method flow to reset applied adjustments
  Dean Herbert · 2022-09-05 23:22:38 +09:00
  7084aeee05
• Remove probably unnecessary Seek on start
  Dean Herbert · 2022-08-30 01:21:44 +09:00
  27ad224f13
• Fix gameplay skipping forward during resume operation
  Dean Herbert · 2022-08-29 19:51:16 +09:00
  75531d2d62
• Reword xmldoc regarding final clock source to read better
  Dean Herbert · 2022-08-26 16:46:22 +09:00
  ed0843aa84
• Fix typo in long comment
  Dean Herbert · 2022-08-26 15:20:09 +09:00
  9862b79b47
• Avoid setting the source clock until gameplay is ready to start

  Without this change, the audio track may audibly seek during load
  proceedings.

  Dean Herbert · 2022-08-23 18:34:17 +09:00
  29fed0c4a3
• Simplify track start/stop/paused tracking
  Dean Herbert · 2022-08-22 19:43:18 +09:00
  489e172a76
• Elaborate with example of GameplayClockContainer managing its own Stop state
  Dean Herbert · 2022-08-22 14:14:44 +09:00
  e6b669db8e
• Move operation of setting GameplayClockContainer.StartTime to Reset call
  Dean Herbert · 2022-08-22 14:11:06 +09:00
  af2e82d7d5
• Reword comment to hopefully read better
  Dean Herbert · 2022-08-19 20:57:55 +09:00
  7bf318541c
• Delay start operation by one frame to allow children to see initial start time
  Dean Herbert · 2022-08-19 17:39:51 +09:00
  3f0da14065
• Reorganise call order of Start / Reset to make more sense
  Dean Herbert · 2022-08-19 01:46:36 +09:00
  3eb1cda6aa
• Remove redundant ProcessFrame calls

  Of note, I'm not sure whether the `IsPaused` check was meaningful, but
  it's not reimplemented in the new `FramedBeatmapClock`.

  Dean Herbert · 2022-08-19 01:39:02 +09:00
  1d774f3f12
• Remove unnecessary virtual spec from GameplayClockContainer.Seek
  Dean Herbert · 2022-08-19 01:39:01 +09:00
  7bc96431a7
• Ensure setting a StartTime on a GameplayClockContainer always resets to the new time
  Dean Herbert · 2022-08-18 18:54:10 +09:00
  43879633db
• Fix `GameplayClockContainer potentially resetting external seeks
  Dean Herbert · 2022-08-18 18:54:10 +09:00
  2c6fd1ec6e
• Use FramedBeatmapClock in GameplayClockContainer
  Dean Herbert · 2022-08-18 18:54:10 +09:00
  6003afafc7
• Ensure GameplayClockContainer's FramedClock is always non-null
  Dean Herbert · 2022-08-15 20:22:36 +09:00
  61a8873266
• Reduce exposed properties in GameplayClockContainer
  Dean Herbert · 2022-08-15 20:22:36 +09:00
  1696a905ba
• Remove remaining usage of GameplayClock
  Dean Herbert · 2022-08-15 20:22:36 +09:00
  704568ae3b
• Remove FrameStableClock (and redirect usages to FrameStabilityContainer)
  Dean Herbert · 2022-08-15 19:19:19 +09:00
  27569e2ed5
• Cache self rather than GameplayClock
  Dean Herbert · 2022-08-15 18:30:53 +09:00
  cc982d374c
• Mark unused methods as NotImplemented for safety
  Dean Herbert · 2022-08-15 18:30:53 +09:00
  c5f8529d20
• Make GameplayClockContainer also an IGameplayClock and expose to remaining tests
  Dean Herbert · 2022-08-15 18:30:53 +09:00
  f81c7644b4
• Move all usage of GameplayClock to IGameplayClock
  Dean Herbert · 2022-08-15 18:30:53 +09:00
  c8764cb333
• Update usages of GameplayClockContainer.GameplayClock to access properties directly
  Dean Herbert · 2022-08-15 18:08:49 +09:00
  6d78218142
• Make GameplayClockContainer non-abstract and use in MultiSpectatorPlayer
  Dean Herbert · 2022-08-15 18:08:49 +09:00
  224f3eaa84