40 Commits

• pass on BeatmapManager directly
  Hivie · 2025-08-09 11:59:20 +01:00
  172a48f1ac
• refactor verifier context to use a static factory method for creating instances with beatmap resolution
  Hivie · 2025-08-07 01:52:50 +01:00
  c5f4feb725
• simplify filtering logic
  Hivie · 2025-08-04 14:22:02 +01:00
  bb156d4206
• define general checks with a bool in CheckMetadata instead of an interface
  Hivie · 2025-08-04 14:12:59 +01:00
  ed301ec114
• rename scopes
  Hivie · 2025-08-04 14:02:40 +01:00
  8a2053bf61
• simplify bool check
  Hivie · 2025-08-01 22:03:49 +01:00
  8d76ebae29
• add ability to filter checks via scope
  Hivie · 2025-08-01 21:41:21 +01:00
  ca8a821dca
• reduce whitespace
  Hivie · 2025-07-21 12:22:43 +01:00
  72254226cf
• fix ci
  Hivie · 2025-07-16 02:08:07 +01:00
  83ad34b718
• address review

  - add TODO for refactoring verifier context ctor
  - call `GetPlayableBeatmap()` in verifier context ctor
  - filter diffs with relevant ruleset in check logic
  - fix tests

  Hivie · 2025-07-16 01:53:22 +01:00
  747bff1df9
• include all of a beatmapset's diffs in the verifier context
  Hivie · 2025-07-13 01:53:07 +01:00
  f1eb7d367b
• Rewrite IssueTable to use virtualised list
  Bartłomiej Dach · 2024-06-26 10:40:02 +02:00
  b12db8fbe2
• Automatically refresh the verify screen's issue list on re-entering it

  Addresses https://github.com/ppy/osu/discussions/25365.

  Dean Herbert · 2023-11-06 19:34:36 +09:00
  51c891e2e4
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Darken background colour in "setup" and "verify" screens
  Salman Ahmed · 2022-05-28 02:10:18 +03:00
  eec9248cde
• Remove TriangleButton usage in editor
  Dean Herbert · 2022-05-24 18:13:09 +09:00
  a346990a8c
• Fix some null inspections
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  3811bd8520
• Clean up unused resolved properties
  Dean Herbert · 2021-12-03 18:49:49 +09:00
  1eed2436e6
• Remove null checks on CreateInstance() calls
  Dean Herbert · 2021-11-24 12:23:09 +09:00
  0eea026afb
• Tidy bindable changed code up
  Dean Herbert · 2021-05-14 16:24:52 +09:00
  67a99c83a3
• Move IBeatmap arg into context
  Naxess · 2021-05-13 11:24:22 +02:00
  19800f5f7f
• Change interpreted difficulty from bindable to regular value

  There's no reason for why checks would need this to be bindable. A 1-directional binding is more appropriate.

  Naxess · 2021-05-13 09:00:30 +02:00
  b37cb3bdbe
• Keep track of local bound copy
  Naxess · 2021-05-13 07:57:32 +02:00
  4eeeaf6a1a
• Merge branch 'master' into beatmap-verifier-context
  Naxess · 2021-05-13 07:40:33 +02:00
  e7c7786db3
• Also refresh when interpreted difficulty changes
  Naxess · 2021-05-13 06:00:21 +02:00
  fb305130de
• Use more consistent lambda discards
  Naxess · 2021-05-13 05:38:45 +02:00
  04c1585eb2
• Isolate refreshing to IssueList
  Naxess · 2021-05-13 05:25:02 +02:00
  c8d21f2c3f
• Split ShowIssueTypes dict into hidden and configurable lists

  This way `VerifyScreen` is decoupled from which options `VisibilitySection` provides.
  
  Bindings are a bit less neat, though.

  Naxess · 2021-05-13 04:50:32 +02:00
  fbb76ba598
• Remove unnecessary local variable

  This now exists in `VerifyScreen`, which we can access from here.

  Naxess · 2021-05-13 04:30:40 +02:00
  6806e40ad9
• Move ShowIssueTypes to VerifyScreen
  Naxess · 2021-05-13 04:29:27 +02:00
  56bd897666
• Reverse direction of binding to allow for better abstract class definitions
  Dean Herbert · 2021-05-12 16:53:58 +09:00
  d2e0e8ad94
• Add interpreted difficulty info to BeatmapVerifierContext

  Enables checks to make use of the difficulty level as shown in the settings UI.

  Naxess · 2021-05-12 02:30:21 +02:00
  64d96b06a6
• Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks

  This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
  
  See next commit for example.

  Naxess · 2021-05-12 02:29:18 +02:00
  c13b93e6f1
• Add InterpretationSection and its bindable in IssueList

  We'll eventually connect that bindable so that checks can access it.

  Naxess · 2021-05-12 01:32:18 +02:00
  4aeaec6ecc
• Refresh IssueList on changes in VisibilitySection
  Naxess · 2021-05-12 01:30:45 +02:00
  ad78aec1ef
• Add IssueList filtering based on those bindables
  Naxess · 2021-05-12 01:29:46 +02:00
  1bb7d412da
• Add VisibilitySection and its bindables in IssueList
  Naxess · 2021-05-12 01:27:21 +02:00
  2e4399f0c1
• Separate IssueList into own class
  Naxess · 2021-05-12 01:23:31 +02:00
  1de35f880b