77 Commits

• Show border instead of adjusting dim
  Dean Herbert · 2025-03-11 18:35:10 +09:00
  770291b462
• Change amount from 0.9f to 0.6f
  Arthur Araujo · 2025-03-10 16:09:18 -03:00
  a78868712c
• Remove dependence of blueprint containers on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:05 +01:00
  15b6e28ebe
• Fix allocations in updateSamplePointContractedState
  Andrei Zavatski · 2025-01-07 00:48:58 +03:00
  791ca915e4
• Reduce HitSampleInfo constants allocations
  Andrei Zavatski · 2025-01-07 00:36:58 +03:00
  e8dc09f5bc
• Take custom bank name length into account when collapsing sample point indicators

  Would close https://github.com/ppy/osu/issues/31312.
  
  Not super happy with the performance overhead of this, but this is
  already a heuristic-based implementation to avoid every-frame
  `.ChildrenOfType<>()` calls or similar, so not super sure how to do
  better. The `Array.Contains()` check stands out in profiling, but
  without it the indicators can collapse *too* eagerly sometimes.

  Bartłomiej Dach · 2024-12-30 12:04:41 +01:00
  693db097ee
• Merge branch 'master' into hs-toggle2
  Bartłomiej Dach · 2024-11-01 18:44:33 +01:00
  f2afec23f9
• only consider hit objects which are visible in timeline for contracted state
  OliBomby · 2024-10-24 21:22:09 +02:00
  eb61da4232
• Fix timeline blueprints sometimes causing crashes due to current placement blueprint becoming unsorted

  Closes https://github.com/ppy/osu/issues/30324.

  Bartłomiej Dach · 2024-10-21 14:48:57 +02:00
  dbc2e78dd9
• dont contract samples for stacked objects
  OliBomby · 2024-10-20 00:07:40 +02:00
  22aef90cb7
• Update sample point contracted state each frame
  OliBomby · 2024-10-19 23:57:41 +02:00
  f137fed04e
• contract sample point pieces based on smallest gap on the timeline

  It finds the smallest distance between two sample point pieces on the alive timeline blueprints

  OliBomby · 2024-10-05 20:52:45 +02:00
  48da758c39
• Add to existing selection when dragging with control pressed

  Closes https://github.com/ppy/osu/issues/29023.

  Bartłomiej Dach · 2024-09-18 15:18:13 +02:00
  f6195c5515
• Change order of application to avoid bias to side with more room to drag

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2024-07-23 20:56:21 +09:00
  aed7ba9508
• Use non-screen-space coordinates and add time-based drag ramping for better control
  Dean Herbert · 2024-07-23 18:59:22 +09:00
  cc4ed0ff3f
• Add tolerance when drag-scrolling editor timeline

  Closes https://github.com/ppy/osu/issues/28983.
  
  While the direct cause of this is most likely mouse confine in
  full-screen, it shouldn't/can't really be disabled just for this,
  and I also get this on linux in *windowed* mode.
  
  In checking other apps, adding some tolerance to this sort of
  drag-scroll behaviour seems like a sane UX improvement anyways.

  Bartłomiej Dach · 2024-07-23 11:10:18 +02:00
  38fc6f70f6
• Commit active placement when starting drag selection via timeline

  This was reported in https://github.com/ppy/osu/pull/28474, albeit the
  code changes proposed there did not fix the issue at all.
  
  See 8b6385f7d0 for demonstration of the
  crash scenario. Basically what is happening there is:
  
  - The starting premise is that there is a spinner placement active.
  - At this time, a drag selection is started via the timeline.
  - Once the drag selection finds at least one suitable object to select,
    it mutates `SelectedItems`.
  - When selection changes for any reason, the `HitObjectComposer`
    decides to switch to the "select" tool, regardless of why
    the selection changed.
  - Changing the active tool causes the current placement - if any -
    to be committed, which mutates the beatmap.
  - Back at the drag box selection code, this causes a "collection
    modified when enumerating" exception.
  
  The proposed fix here is to eagerly commit active placement - if any -
  when drag selection is initiated via the timeline, which avoids this
  issue. This also appears to vaguely match stable behaviour and is sort
  of consistent with the logic of committing any outstanding changes upon
  switching to the selection tool.

  Bartłomiej Dach · 2024-06-14 09:32:40 +02:00
  bdeea37a44
• Reduce allocations in TimelineBlueprintContainer
  Andrei Zavatski · 2024-02-21 23:13:10 +03:00
  4cefa8bb8d
• Add TODO regarding failing stack display code
  Dean Herbert · 2023-05-17 17:52:17 +09:00
  214d7e07fa
• Fix weird purple tint on placement object in timeline
  Dean Herbert · 2023-05-17 17:26:19 +09:00
  9563d4f730
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Refactor blueprint container drag code
  ekrctb · 2022-10-11 22:39:53 +09:00
  fcb9e2cc00
• Ensure blueprint is added for selected hit object
  ekrctb · 2022-10-06 13:59:54 +09:00
  29cc554632
• Use mid time instead of start time

  It is closer to the old blueprint-based behavior

  ekrctb · 2022-10-05 22:19:22 +09:00
  b0213c29e9
• Fix inspect issues
  ekrctb · 2022-10-05 22:04:43 +09:00
  3108c42ece
• Improve timeline selection performance

  But selecting a large number of hit objects is still very slow
  because all DHOs must be added
  and also `AddBlueprintFor` has quadratic behaviors

  ekrctb · 2022-10-05 21:58:05 +09:00
  00b3d97f69
• Use hit object time for timeline selection
  ekrctb · 2022-10-05 21:51:01 +09:00
  0ffde02f79
• Move selection logic from DragBox to BlueprintContainer
  ekrctb · 2022-10-05 21:51:01 +09:00
  8d29e9e76b
• Update Remove/RemoveRange/RemoveAll calls in line with framework changes
  Dean Herbert · 2022-08-29 15:57:40 +09:00
  a215d009fe
• Fix BlueprintContainer eating input from skin editor buttons
  Salman Ahmed · 2022-06-18 18:28:36 +03:00
  a5e5172b91
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Remove no longer necessary ReceivePositionalInputAt overrides in timeline components
  Salman Ahmed · 2022-06-14 00:19:47 +03:00
  fa4930c586
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Split out nested classes from TimelineBlueprintContainer

  They got too big.

  Dean Herbert · 2021-07-22 15:48:08 +09:00
  957a0686ed
• Move resolved property to top of class
  Dean Herbert · 2021-07-22 15:39:01 +09:00
  b5cc9010de
• Allow context menus to be triggered as well
  Derrick Timmermans · 2021-07-21 12:04:09 +02:00
  9d43ca122f
• Fix slight Y position offset in HandleDrag
  Derrick Timmermans · 2021-07-20 23:00:58 +02:00
  a8cf6a6854
• Let TimelineBlueprintContainer only accept positional input within timeline quad
  Derrick Timmermans · 2021-07-20 22:30:50 +02:00
  bfec87b082
• Allow moving timeline selection when mousedown event is outside of blueprint container
  Derrick Timmermans · 2021-07-18 18:06:59 +02:00
  2e2a2bdd99
• Avoid using guesses to determine whether inputs blocked
  Derrick Timmermans · 2021-07-18 16:04:23 +02:00
  ee220feecf
• Pass on mouseDown input to timeline if no selection modification is made with that input
  Derrick Timmermans · 2021-07-16 17:21:43 +02:00
  e35cff99c7
• Allow interacting with timeline objects outside of drawable bounds
  Derrick Timmermans · 2021-07-16 16:16:34 +02:00
  3e8a13bfbf
• Fix "possible NRE" inspection
  ekrctb · 2021-06-23 10:57:04 +09:00
  0b351c9922
• Ensure EditorBeatmap.Update is called inside PerformOnSelection calls
  Dean Herbert · 2021-05-23 21:22:35 +09:00
  4c9d72e62a
• Remove hitobject terminology from base classes
  Dean Herbert · 2021-04-27 19:01:29 +09:00
  7ec5ea1eb5
• Refactor editor selection/blueprint components to be generic
  Dean Herbert · 2021-04-27 19:01:29 +09:00
  f2e56bd306
• Add simple key based time nudging support to editor
  Dean Herbert · 2021-04-22 18:47:04 +09:00
  a5364b224f
• Use additive blending for background box

  Doesn't make a huge difference but this was intended.

  Dean Herbert · 2021-04-14 14:56:28 +09:00
  e543db9bee
• Update visual appearance of timeline blueprints to close match new designs
  Dean Herbert · 2021-04-13 19:26:20 +09:00
  00f235760d
• Remove no longer necessary FinishTranforms call
  Dean Herbert · 2021-04-06 15:35:07 +09:00
  9d0839be8f