osu-lazer

Emit important replay frames on every judgement

- Closes https://github.com/ppy/osu/issues/4287
- Probably closes https://github.com/ppy/osu/issues/25405 (but not
  retroactively)

Up until now, whether or not a replay frame is emitted depended solely
on the user's input, i.e. mouse movement or key presses/releases. This,
intersected with the replay playback system which is given allowance to
perform interpolation between replay frames, leads to potential
situations wherein a replay can play inaccurately when a judgement takes
place without user input meaningfully changing. One such case is slider
ends with their 36ms of judgement leniency; see
https://github.com/ppy/osu/issues/25405#issuecomment-2879031106 for
details on that.

To that end, this commit aims to counteract that issue by *forcing* an
important replay frame to be emitted on every new judgement recorded
during gameplay. This will only benefit rulesets wherein judgements can
occur that are not inherently tied to user input changing, which are
going to be osu! as mentioned above, and maybe possibly catch. I don't
foresee this doing anything relevant for taiko or mania.

Bartłomiej Dach · 2025-05-15 11:43:09 +02:00

9f91c2e25c

Use alternative method of releasing user-pressed keys when activating autoplay

Bartłomiej Dach · 2024-07-03 14:37:07 +02:00

0ab13e4486

Fix user-pressed keys remaining pressed whtn autoplay is turned on

Bartłomiej Dach · 2024-07-03 10:32:08 +02:00

84c7d34b77

Clear pressed keys and last replay frame when detaching replay from ruleset input manager

Bartłomiej Dach · 2024-07-03 10:19:59 +02:00

294aa09c41

Enable NRT in RulesetInputManager

Bartłomiej Dach · 2024-07-03 09:33:48 +02:00

29c3ff0677

Mark some delegates as static because we can

Dean Herbert · 2024-01-29 16:16:28 +09:00

760368709a

Change key overlay to use the ordering provided by rulesets

osu!mania already goes out of its way to order things correctly.
Arguably, osu!taiko just did it wrong.

Dean Herbert · 2024-01-17 17:37:38 +09:00

45e52854ca

Rename setting to TouchDisableGameplayTaps for better visibility when searching

Susko3 · 2023-11-07 00:13:46 +01:00

05d9418718

Fix tests by using the correct setting for touch input

Susko3 · 2023-11-06 20:53:22 +01:00

ea357bafdd

Add migration to remove duplicate bindings

Bartłomiej Dach · 2023-10-16 22:20:26 +02:00

9c6166ec3d

Prevent ruleset input managers from reading duplicate bindings

Bartłomiej Dach · 2023-10-16 21:02:24 +02:00

639c96e60c

Rename ClicksPerSecondCalculator to ClicksPerSecondController

Dean Herbert · 2023-06-27 16:38:46 +09:00

8bd6f7a46a

Refactor InputCountController to not require being added to foreign body via Attach

I've made the flow match `ClicksPerSecondCalculator` as close as
possible. Hopefully this reads better.

Dean Herbert · 2023-06-27 16:36:00 +09:00

e21583ff1b

Fix incorrect indent size

Bartłomiej Dach · 2023-06-26 22:40:25 +02:00

40ceb4dfac

Rename {KeyCounter -> InputCount}Controller

Bartłomiej Dach · 2023-06-26 19:27:42 +02:00

8d91580dc1

Split out interfaces from RulesetInputManager and improve xmldoc

Dean Herbert · 2023-06-26 16:34:57 +09:00

084354a8dc

Remove unused interface

Dean Herbert · 2023-06-26 16:32:19 +09:00

c8e081c2b6

revert: bring back old attachment flow

As discussed, this would bring more problems that anything.

Refs: 4c39708, f83a4f4

tsrk · 2023-06-25 15:21:55 +02:00

a7088ffe22

refactor: tidy up attachement flow

TODO: find better naming and improve XMLDocs

tsrk · 2023-06-18 22:57:21 +02:00

f83a4f4952

style(KeyCounterController): remove reliance on Receptor

tsrk · 2023-06-18 21:26:16 +02:00

141f9efad5

refactor: remove detachment logic

No real use case, cleaning up the diff

tsrk · 2023-06-15 12:24:37 +02:00

b4cbcb210e

refactor: decouple Trigger logic from KeyCounterDisplay

This allows to keep a coeherent state regardless of the progress of the play

tsrk · 2023-06-14 21:13:35 +02:00

c637fddf73

refactor: improve attachement flow

This removes the hard reliance on individual classes and makes its usage easiser to ingreate anywhere
else.

tsrk · 2023-06-06 00:12:53 +02:00

4c397085c5

Fix hold-for-right-click showing during gameplay

Dean Herbert · 2023-05-13 21:32:30 +09:00

8c542c6c51

Fix incorrect indent

Bartłomiej Dach · 2023-04-05 19:47:25 +02:00

e5d57a65c9

Merge branch 'master' into gameplay/key-counter-abstraction

Dean Herbert · 2023-04-03 15:33:35 +09:00

b0c09df259

Rename Add/AddRange methods as they are no longer conflicting with Container

Dean Herbert · 2023-03-15 18:02:41 +09:00

5f9b13a775

refactor: make KCD a CompositeDrawable

tsrk · 2023-03-08 00:47:16 +00:00

44297a7d0a

Move KeyCounter components to HUD namespace

Dean Herbert · 2023-03-07 16:41:39 +09:00

28520414aa

refactor(KeyCounterDisplay): apply suggestions

I also took the freedom to add type checking, as we can't limit the
usage of `Add()` since it's a Container. The exception thrown also
advises of using the suggested `AddTrigger()` instead.

tsrk · 2023-02-22 14:58:27 +00:00

1beec71037

refactor: rename trigger classes

Makes it better to understand their purpose

tsrk · 2023-02-15 21:46:13 +00:00

076eb81b21

refactor: rename Trigger class to InputTrigger

tsrk · 2023-02-15 21:41:36 +00:00

157bba7830

Combine and attempt to simplify the score import / preparation process further

Dean Herbert · 2023-02-14 16:55:35 +09:00

7aaaf7fca2

refactor: separate things in KeyCounter

To implement different different sources of input for KeyCounter, it
is now possible to create a Trigger class (to inherit) instead of
inheriting KeyCounter. This eases the creation of more input sources
(like for tests) while allowing to implement different UI variants.

That way, if another variant of the key counter needs to implemented
(for whathever reason), this can be done by only inheriting KeyCounter
and changing how things are arranged visually.

tsrk · 2023-02-13 01:24:27 +00:00

74a58fb674

Partial everything

Dan Balasescu · 2022-11-27 00:00:27 +09:00

7bc8908ca9

Remove non-smoke key bindings on "Relax" mod instead

Salman Ahmed · 2022-10-09 17:14:16 +03:00

2d4f390372

Change FrameStableClock to inherit IGameplayClock

Dean Herbert · 2022-09-08 18:24:18 +09:00

6729bb3e1a

Code cleanup (CPS)

Ryuki · 2022-08-24 17:13:23 +02:00

5cddc7ed1f

Tidy up attach logic

Dean Herbert · 2022-08-24 19:36:01 +09:00

f3847b90fd

Rename all "KeysPerSecond" usages to "ClicksPerSecond"

Ryuki · 2022-08-14 20:12:11 +02:00

2aa3a1b50d

Make ActionListener and KeysPerSecondCalculator not rely on events to add timestamps

Ryuki · 2022-08-14 19:31:14 +02:00

9dc806506e

Make KeysPerSecondCalculator dependency in HUDOverlay nullable

Ryuki · 2022-08-11 11:58:30 +02:00

9b252b1d81

Remove KPS acronym usage

Ryuki · 2022-08-11 10:01:39 +02:00

3c6461b9e4

Use DI to provide dependencies for KPS Calculator and improve input

gathering

KPS Calculator now uses DI to retrieve the clocks. Using `HUDOverlay` it
is now cached for `KeysPerSecondCounter`s to resolve it. This also
allows to make an "Attach" flow like `KeyCounter`.

Ryuki · 2022-08-08 21:54:06 +02:00

b52a07c16a

Update parameter discards

Dean Herbert · 2022-06-24 21:26:19 +09:00

31a447fda0

Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850

Remove Ruleset parameter from ResetFromReplayFrame()

Dan Balasescu · 2022-05-31 17:16:23 +09:00

132c94c1b5

Merge branch 'master' into spectator-consistency-frames