582 Commits

• Fix HealthProcessor potentially incorrectly reverting failed state

  This stems from me looking into `TestSceneFailAnimation` failures
  (https://github.com/ppy/osu/runs/48663953318). As it turns out, I should
  not have been mad by CI, and rather should have been mad at myself for
  failing to read.
  
  `FailedAtJudgement` in fact does not mean "this judgement, and only this
  judgement, triggered failure". If any further judgements occur
  post-fail, they will also have `FailedAtJudgement` set to true. It is
  essentially a *dump* of the state of `HealthProcessor.Failed` prior to
  applying the judgement.
  
  	https://github.com/ppy/osu/blob/ec21685c2531af3b243f7f0833ffbb340bf3c044/osu.Game/Rulesets/Scoring/HealthProcessor.cs#L49-L57
  
  Because of this, reverting several judgements which occur post-fail
  could lead to failed state reverting earlier than intended, and thus
  potentially trigger a second fail, thus tripping the `Player` assertion.

  Bartłomiej Dach · 2025-08-27 12:27:11 +02:00
  197c318180
• Add rudimentary support of rewinding failed state to health processor

  As indicated in the inline comment this is very best effort, just to
  make the HP bar not very obviously stuck in a very obviously incorrect
  state after the replay is rewound from a failure. There's likely to be a
  bunch of replay accuracy issues related to this, but I'm just making the
  minimum effort to get this to work semi-acceptably for now.

  Bartłomiej Dach · 2025-08-12 14:26:00 +02:00
  30857de55e
• Make assertion completely dead in release mode
  Bartłomiej Dach · 2025-06-25 10:06:04 +02:00
  55ff5a744c
• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Adjust combo accounting in score processor to be order-agnostic

  Closes https://github.com/ppy/osu/issues/21732.
  
  While the problem of multiple judgements in one frame and ordering of
  `RevertResult()` calls as described in the issue is a real one, this
  commit is a bit of a sidestep of the entire issue.
  
  The idea here that while *snapshots* of instantaneous combo values are
  susceptible to such ordering foibles on revert, *deltas* are not - and
  such, when deltas are using to update the combo counts on revert,
  ordering stops mattering so much.

  Bartłomiej Dach · 2025-05-20 12:28:28 +02:00
  237de1ef72
• Allow any hit result for empty hit windows

  It's really going to return zero anyway even if given a "supported"
  one, so probably fine?

  Bartłomiej Dach · 2025-05-09 10:31:00 +02:00
  bf86878597
• Fix HitWindows.WindowFor() returning values for invalid results

  This fell out of my work on hit window-related replay issues. In my WIP
  branch (that is probably going to get PR'd as draft soon) I refactored
  `HitWindows` and found a few straggling test failures due to some places
  reading hit windows for results that were not actually supported by the
  underlying `HitWindows` implementations, leading to returning garbage
  (mostly zeroes).
  
  Importantly, there is one actual usage in game code with impact here -
  `TaikoModSingleTap` was attempting to read the hit window for MEH, when
  MEH was never actually a valid hit result in taiko (OK is). This was a
  result of a copy-paste oversight from osu!, specifically from
  
  	https://github.com/ppy/osu/blob/51cf835fb6300aca53b5b98143d606f64d7a4d49/osu.Game.Rulesets.Osu/Mods/InputBlockingMod.cs#L58

  Bartłomiej Dach · 2025-05-09 09:40:20 +02:00
  ceb58a1141
• Revert "Use median for statistic display"

  This reverts commit fa06643bb6.
  
  Revert "Remove mean hit error calculation"
  
  This reverts commit b3c578e545.

  Dean Herbert · 2025-04-11 02:12:40 +09:00
  ba5932c1dd
• Remove mean hit error calculation
  sineplusx · 2025-03-29 13:45:39 +01:00
  b3c578e545
• Add comment
  sineplusx · 2025-03-26 17:22:57 +01:00
  6452514066
• Use median instead of mean for automatic beatmap offset adjustment
  sineplusx · 2025-03-26 15:41:48 +01:00
  bb8f8e8d8c
• Fix incremental unstable rate calculation not matching expectations

  The `EventCount` variable wasn't factoring in that some results do not
  affect unstable rate. It would therefore become more incorrect as the
  play continued.
  
  Closes https://github.com/ppy/osu/issues/31712.

  Dean Herbert · 2025-01-29 17:11:12 +09:00
  d8ec3b77e4
• Typo fix
  Shawn Presser · 2025-01-15 19:29:41 -06:00
  6008c3138e
• Add basic xmldoc to results class
  Dean Herbert · 2024-11-26 12:16:26 +09:00
  d6cf1db0f5
• Rename NextProcessableIndex to EventCount in line with actual functionality
  Dean Herbert · 2024-11-26 12:10:34 +09:00
  d903d381d5
• Only update unstable rate counter when an applicable hitobject is reached
  Dean Herbert · 2024-11-25 21:13:18 +09:00
  bbe8f2ec44
• Use class instead of record for lower allocations
  Dean Herbert · 2024-11-25 21:13:18 +09:00
  ea68d4b33a
• Add incremental processing
  Dean Herbert · 2024-11-25 21:13:17 +09:00
  5668258182
• Address unstable rate calculations as a list for marginal gains
  Dean Herbert · 2024-11-25 19:44:11 +09:00
  33d725e889
• Make empty hitwindows readonly static and slightly improve comparison performance
  Dean Herbert · 2024-11-25 19:17:32 +09:00
  605fe71f46
• Do not show timing distribution graph in offset control if there's not enough timed hits

  Intended to address concerns raised in
  https://github.com/ppy/osu/pull/30620#issuecomment-2475744164.

  Bartłomiej Dach · 2024-11-14 13:17:03 +01:00
  bd1d3cad49
• Simplify implementation
  Dan Balasescu · 2024-10-17 20:00:17 +09:00
  bfcf6693ca
• Add test coverage of judgements not being synced when resuming a replay
  Dean Herbert · 2024-09-18 15:28:10 +09:00
  2d993645af
• Prevent multiple invocations of failure procedure
  Dan Balasescu · 2024-06-26 13:57:18 +09:00
  0379abd714
• Fix transient rank value applied to bindable
  PercyDan54 · 2024-06-25 18:06:50 +08:00
  2de0852551
• fix accuracyProcess typo
  sometimes · 2024-06-20 22:06:00 -04:00
  89d3f67eb3
• Revert "Temporary rollback of framework / SDL3"

  This reverts commit d7d569cf4e.

  Dean Herbert · 2024-05-22 16:29:39 +08:00
  d0b1ebff5a
• Temporary rollback of framework / SDL3
  Dean Herbert · 2024-05-21 14:36:16 +08:00
  d7d569cf4e
• Merge branch 'master' into pre-mod-multiplier-score
  Bartłomiej Dach · 2024-05-08 13:39:44 +02:00
  c9414da5d4
• Fix LegacyDrainingHealthProcessor drain rate computation diverging to infinity
  Bartłomiej Dach · 2024-04-23 18:57:14 +02:00
  787e60f706
• Populate TotalScoreWithoutMods on scores set locally
  Bartłomiej Dach · 2024-04-17 08:52:47 +02:00
  e0178802b8
• Add HP and AR to LegacyBeatmapConversionDifficultyInfo
  Dan Balasescu · 2024-03-28 22:30:39 +09:00
  5febd40bd9
• Fix infinite health processor loop when no top-level objects

  This is unlikely to occur in actual gameplay, but occurs in the
  follow-up test.

  Dan Balasescu · 2024-03-20 17:30:37 +09:00
  c78e203df5
• Merge branch 'master' into catch-fail-on-banana
  Dan Balasescu · 2024-03-04 13:13:26 +09:00
  5bd037fe8f
• Fix missing tiny droplet not triggering fail with perfect on

  Stable does this:
  
      https://github.com/peppy/osu-stable-reference/blob/46cd3a10af7cc6cc96f4eba92ef1812dc8c3a27e/osu!/GameplayElements/HitObjectManagerFruits.cs#L98-L102
  
  I'd rather not say what I think about it doing that, since it's likely
  to be unpublishable, but to approximate that, just make it so that
  only the "default fail condition" is beholden to the weird ebbs
  and flows of what the ruleset wants. This appears to fix the problem
  case and I'm hoping it doesn't break something else but I'm like 50/50
  on it happening anyway at this point. Just gotta add tests add nauseam.

  Bartłomiej Dach · 2024-02-14 14:21:48 +01:00
  2c0a5b7ef5
• Fix draining processor failing gameplay on bonus misses and ignore hits
  Bartłomiej Dach · 2024-02-13 13:06:19 +01:00
  16d893d40c
• Cache created judgement in HitObject
  Andrei Zavatski · 2024-02-09 23:20:31 +03:00
  c500264306
• Merge branch 'master' into ur-alloc
  Bartłomiej Dach · 2024-02-05 19:14:08 +01:00
  4b5348bbbf
• Move algorithm description to remarks section of xmldoc
  Bartłomiej Dach · 2024-02-05 18:57:57 +01:00
  7b03bebd5f
• Use better variable names

  It's not the 1970s. We can spare a few extra letters.

  Bartłomiej Dach · 2024-02-05 18:56:20 +01:00
  a5aeb2ff9e
• Improve readability
  Andrei Zavatski · 2024-02-03 00:19:04 +03:00
  57bc5ee04f
• Incorporate new unstable rate algo
  Andrei Zavatski · 2024-02-02 22:46:52 +03:00
  dde7e068a4
• Adjust default min result of SliderTailHit, remove override
  Dan Balasescu · 2024-01-31 18:01:29 +09:00
  0642a0ee11
• Revert "Merge pull request #26870 from smoogipoo/adjust-default-minresult"

  This reverts commit 1acff746ee, reversing
  changes made to 696ecda398.

  Dean Herbert · 2024-01-31 17:51:38 +09:00
  fbc923b47e
• Adjust default min result of SliderTailHit, remove override
  Dan Balasescu · 2024-01-31 16:12:05 +09:00
  9b1bbe5f48
• Merge pull request #26703 from peppy/smaller-slider-misses

  Adjust slider tick / end defaults again

  Bartłomiej Dach · 2024-01-29 13:51:07 +01:00
  2667cb8b36
• Move solution to multiplayer flow instead
  Salman Ahmed · 2024-01-28 00:42:04 +03:00
  64b61108ad
• Fix score processor no longer applying results when failing in multiplayer match
  Salman Ahmed · 2024-01-27 23:23:10 +03:00
  a25be9927d
• Update triangles skin judgment display
  Dean Herbert · 2024-01-25 19:31:57 +09:00
  107b37494e
• Make RankFromScore()'s dictionary param readonly

  Just to make sure nobody tries any "funny" business.

  Bartłomiej Dach · 2024-01-22 19:56:30 +01:00
  cb8ec48717