277 Commits

• Simplify taglib interactions further
  Dean Herbert · 2025-04-28 15:52:31 +09:00
  40faa3fc99
• Work around rare sharpcompress failure to extract certain archives

  Closes https://github.com/ppy/osu/issues/31667.
  
  See https://github.com/ppy/osu/issues/31667#issuecomment-2615483900 for
  explanation.
  
  For whatever it's worth, I see rejecting this change and telling
  upstream to fix it as an equally agreeable outcome, but after I spent an
  hour+ tracking this down, writing this diff was nothing in comparison.

  Bartłomiej Dach · 2025-01-27 12:28:53 +01:00
  bb8f58f6d6
• Apply type inheritance check
  mini · 2024-12-19 09:21:49 +01:00
  c7354d9c41
• Use temporary storage for exported files on iOS
  Salman Alshamrani · 2024-12-09 08:16:37 -05:00
  0c0dcb1e15
• Update naming of enum fields in ObjType
  Salman Ahmed · 2024-05-01 17:24:53 +03:00
  e8a6381395
• Force encoding to Shift-JIS for archive filenames

  After way too much time investigating this, the encoding situation is
  not great right now.
  
  - Stable sets the "default code page" to be used for encoding filenames
  to Shift-JIS (932):
  https://github.com/peppy/osu-stable-reference/blob/c29ebd7fc52113013fb4ac2db230699d81e1fe2c/osu!/GameBase.cs#L3099
  - Lazer does nothing (therefore using UTF-8).
  
  When importing to lazer, stable files are assumed to be UTF-8. This
  means that the linked beatmaps don't work correctly. Forcing lazer to
  decompress *and* compress using Shift-JIS will fix this.
  
  Here's a rough idea of how things look for japanese character filenames
  in current `master`:
  
  | | stable | lazer |
  |--------|--------|--------|
  | export encoding | shift-jis | utf8 |
  | utf8 [bit flag](https://superuser.com/a/1507988) set | ❌ | ❌ |
  | import stable export osz | ✅  | ❌ |
  | import lazer export osz | ❌ | ✅ |
  | windows unzip | ❌ | ❌ |
  | macos unzip | ✅ | ✅ |
  
  and after this change
  
  | | stable | lazer |
  |--------|--------|--------|
  | export encoding | shift-jis | shift-jis |
  | utf8 [bit flag](https://superuser.com/a/1507988) set | ❌ | ❌ |
  | import stable export osz | ✅  | ✅ |
  | import lazer export osz | ✅ | ✅ |
  | windows unzip | ❌ | ❌ |
  | macos unzip | ✅ | ✅ |
  
  A future endeavour to improve compatibility would be to look at setting
  the utf8 flag in lazer, switching the default to utf8, and ensuring the
  stable supports this flag (I don't believe it does right now).

  Dean Herbert · 2024-04-30 01:27:47 +08:00
  c8f7f2215b
• Fix exports containing zero byte files after import from specific ZIP archives

  Closes https://github.com/ppy/osu/issues/27540.
  
  As it turns out, some ZIP archivers (like 7zip) will decide to add fake
  entries for directories, and some (like windows zipfolders) won't.
  The "directory" entries aren't really properly supported using any
  actual data or attributes, they're detected by sharpcompress basically
  by heuristics:
  
      https://github.com/adamhathcock/sharpcompress/blob/ab5535eba365ec8fae58f92d53763ddf2dbf45af/src/SharpCompress/Common/Zip/Headers/ZipFileEntry.cs#L19-L31
  
  When importing into realm we have thus far presumed that these directory
  entries will not be a thing. Having them be a thing breaks multiple
  things, like:
  
  - When importing from ZIPs with separate directory entries, a separate
    `RealmFile` is created for a directory entry even though it doesn't
    represent a real file
  - As a result, when re-exporting a model with files imported from such
    an archive, a zero-byte file would be created because to the database
    it looks like it was originally a zero-byte file.
  
  If you want to have fun, google "zip empty directories". You'll see
  a whole gamut of languages, libraries, and developers stepping on this
  rake. Yet another episode of underspecced mistakes from decades ago
  that were somebody's "good idea" but continue to wreak havoc forevermore
  because now there are two competing conventions you can't just pick one.

  Bartłomiej Dach · 2024-03-12 09:06:24 +01:00
  83e47b3c4c
• Merge pull request #27501 from turbedi/throw_helper

  Use ThrowHelper methods in more places

  Bartłomiej Dach · 2024-03-07 11:36:21 +01:00
  3d8fdc52a4
• Update usage of MathUtils
  Dean Herbert · 2024-03-06 12:13:12 +08:00
  b53b752e54
• Use ArgumentException.ThrowIfNullOrEmpty throw helper
  Berkan Diler · 2024-03-05 10:20:57 +01:00
  5965db4fd7
• Fix compile error (reserved name)
  Dan Balasescu · 2024-02-02 21:28:51 +09:00
  c8b4ff2b47
• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Add retry loop to avoid log export failing occasionally on windows

  Closes https://github.com/ppy/osu/issues/26693.

  Dean Herbert · 2024-01-25 13:53:36 +09:00
  d2990170d0
• Fix various other inspections
  Dean Herbert · 2023-10-17 17:48:51 +09:00
  e081fa48a2
• Fix MemoryStreamArchiveReader.GetStream() failing in some cases

  `MemoryStreamArchiveReader` introduced in
  0657b55196 would previously use
  `MemoryStream.GetBuffer()` to retrieve the underlying byte buffer with
  stream data. However, this is not generally the method you would want,
  for two reasons:
  
  1. It can fail if the stream wasn't created in the way that supports it.
  2. As per
  
  	https://learn.microsoft.com/en-us/dotnet/api/system.io.memorystream.getbuffer?view=net-7.0#system-io-memorystream-getbuffer,
  
     it will return the _raw_ contents of the buffer, including
     potentially unused bytes.
  
  To fix, use `MemoryStream.ToArray()` instead, which avoids both
  pitfalls. Notably, `ToArray()` always returns the full contents of the
  buffer, regardless of `Position`, as documented in:
  
      https://learn.microsoft.com/en-us/dotnet/api/system.io.memorystream.toarray?view=net-7.0#system-io-memorystream-toarray

  Bartłomiej Dach · 2023-09-18 11:50:36 +02:00
  e57d7d1205
• Rename ArchiveReader implementations to read better
  Dean Herbert · 2023-09-14 13:36:07 +09:00
  541cd972e1
• Avoid MemoryStream.ToArray overhead in LegacyByteArrayReader
  Dean Herbert · 2023-09-14 13:33:25 +09:00
  0657b55196
• Rename GetPath to GetFullPath to better match expectations
  Dean Herbert · 2023-08-18 17:56:43 +09:00
  5e0b89a1a8
• Set correct date added value when importing stable beatmapsets
  Krzysztof Gutkowski · 2023-08-17 00:49:48 +02:00
  59abb59ee8
• Return null intead of FileNotFoundException on missing file in ZipArchiveReader
  Dean Herbert · 2023-08-03 09:01:11 +09:00
  d39ef48b71
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Also support hard links on macOS
  Dean Herbert · 2022-12-29 22:35:13 +08:00
  0fcf10e10a
• Disable naming rule inspection on struct stat definition
  Bartłomiej Dach · 2022-12-28 22:38:42 +01:00
  74bc5d4666
• Fix broken condition
  Bartłomiej Dach · 2022-12-28 22:24:18 +01:00
  49b0ec9ddb
• Implement GetFileLinkCount() for Linux
  Bartłomiej Dach · 2022-12-28 22:14:56 +01:00
  8d79fa93ac
• Rename and xmldoc hard link creation method
  Bartłomiej Dach · 2022-12-28 22:04:05 +01:00
  04d4b4a6ce
• Use switch statement in AttemptHardLink()
  Bartłomiej Dach · 2022-12-28 21:20:49 +01:00
  cadd487c75
• Move duplicated code into its own method
  BlauFx · 2022-12-28 14:34:27 +01:00
  53bca947d1
• Fix formatiing
  BlauFx · 2022-12-28 14:06:50 +01:00
  5c5e84f931
• Remove blank line
  BlauFx · 2022-12-28 13:58:52 +01:00
  16165b1f67
• Add hardlink support for Linux
  BlauFx · 2022-12-28 13:32:49 +01:00
  b2aa2e1602
• Use new ArgumentNullException.ThrowIfNull throw-helper API
  Berkan Diler · 2022-12-22 21:27:59 +01:00
  08d2fbeb8e
• Fix some more inspections
  Dean Herbert · 2022-12-16 20:21:19 +09:00
  192536643c
• Add SetLastError hint to CreateHardLink pinvoke method

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-12-14 11:34:06 +09:00
  a3c3112f89
• Move hard link availability check to helper class
  Dean Herbert · 2022-12-13 20:20:42 +09:00
  6bb612ce69
• Move hard link helper functions to their own class
  Dean Herbert · 2022-12-13 19:55:18 +09:00
  bbf931c746
• Fix missing DummyRenderer in skin resources tests
  Dean Herbert · 2022-08-08 13:06:01 +09:00
  a8dee17513
• Merge branch 'master' into irenderer-glwrapper
  Dan Balasescu · 2022-08-05 20:35:06 +09:00
  c4b9b2a14b
• Change migration logic to ignore realm pipe files regardless of database filename
  Dean Herbert · 2022-08-03 17:37:30 +09:00
  f743dc623f
• Apply IRenderer changes
  Dan Balasescu · 2022-08-02 19:50:57 +09:00
  b4e55f7309
• Re-query file existence before failing a recursive copy operation during migration
  Dean Herbert · 2022-08-01 17:01:19 +09:00
  cc8a71b65d
• Revert "Fix migration failing on single file copy failure"

  This reverts commit fc8835d43a.

  Dean Herbert · 2022-08-01 16:57:50 +09:00
  59210ecc9d
• Fix migration failing on single file copy failure

  No longer throw if copying of single files fails during data migration.
  
  Aiming to fix https://github.com/ppy/osu/runs/7601653833?check_suite_focus=true, which could also affect end users. I've left a limit before an exception is still thrown, to handle cases like the user running out of disk space (where we probably *do* want to bail, so they can continue to use their still-intact original storage location).
  
  If this isn't seen as a good direction, an alternative will be to make the migration code aware of the structure of the temporary files created by `Storage` (but doesn't guarantee this will cover all cases of such temporary files – there could for isntance be metadata files created by the host operating system).
  
  Another option would be to mark those temporary files as hidden and skip any hidden files during iteration.

  Dean Herbert · 2022-08-01 15:02:39 +09:00
  fc8835d43a
• Replace calls to defective Humanizer methods with correct version
  Bartłomiej Dach · 2022-07-18 22:34:58 +02:00
  6f37487528
• Add log output for custom storage usage

  Sometimes I am not sure where my osu! is reading files from. This should
  help somewhat.
  
  ```csharp
  /Users/dean/Projects/osu/osu.Desktop/bin/Debug/net6.0/osu!
  [runtime] 2022-07-13 07:22:03 [verbose]: Starting legacy IPC provider...
  [runtime] 2022-07-13 07:22:03 [verbose]: Attempting to use custom storage location /Users/dean/Games/osu-lazer-2
  [runtime] 2022-07-13 07:22:03 [verbose]: Storage successfully changed to /Users/dean/Games/osu-lazer-2.
  [runtime] 2022-07-13 07:22:05 [verbose]: GL Initialized
  ```

  Dean Herbert · 2022-07-13 16:22:51 +09:00
  27ef7fc78e
• Fix crash on mobile releases when attempting to read any file
  Dean Herbert · 2022-07-09 06:01:22 +09:00
  66f314915d
• Avoid usage of finally in potentially hot path
  Dean Herbert · 2022-07-06 19:55:51 +09:00
  c2f1069073
• Revert old behaviour of ReadToEnd
  Dean Herbert · 2022-07-06 19:55:51 +09:00
  01bc6e5cb7
• Use -1 to specify default buffer size
  Dean Herbert · 2022-07-06 15:43:35 +09:00
  12d396a513