3395 Commits

• Avoid constructor overhead for realm BeatmapInfo parameterless constructor
  Dean Herbert · 2022-01-20 16:47:27 +09:00
  3faf980fed
• Fix expanded content scrollbar inadvertently hiding expanded content
  Bartłomiej Dach · 2022-01-19 22:30:49 +01:00
  247c557eaf
• Show scrollbar on expanded card content where applicable
  Bartłomiej Dach · 2022-01-19 22:21:08 +01:00
  77748a5f93
• Merge pull request #16505 from peppy/remove-base-difficulty-usage

  Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)

  Dan Balasescu · 2022-01-19 13:53:55 +09:00
  3e5d29ed00
• Merge branch 'master' into optimise-set-detach-part-2
  Dan Balasescu · 2022-01-19 13:20:38 +09:00
  2556f1cb87
• Add back BaseDifficulty with obsoletion counter to account for custom rulesets
  Dean Herbert · 2022-01-19 12:33:56 +09:00
  2363130f8b
• Avoid file retrieval overhead when detaching BeatmapSetInfo

  It seems that no usages of `BeatmapSetInfo` detaches require files - a
  `WorkingBeatmap` is always obtained before doing further lookups.
  
  Therefore we can omit this include unless the detaching object is a
  `BeatmapInfo`. A refetch is performed when retrieving a
  `WorkingBeatmap` to complete the equation.

  Dean Herbert · 2022-01-19 00:49:18 +09:00
  60b80c88b6
• Remove all usage of AuthorString
  Dean Herbert · 2022-01-18 23:30:40 +09:00
  67bf95bc91
• Add some missing IgnoredAttributes to reduce automapper overhead
  Dean Herbert · 2022-01-18 23:25:30 +09:00
  3596c6ed5d
• Remove all usage of BaseDifficulty (and access Difficulty instead)
  Dean Herbert · 2022-01-18 22:57:39 +09:00
  7f65f3a47f
• Update automapper spec in line with v11

  See https://docs.automapper.org/en/latest/11.0-Upgrade-Guide.html for
   more details.

  Dean Herbert · 2022-01-18 15:23:28 +09:00
  9a43ed742b
• Give the placeholder ruleset better defaults to allow tests to work again
  Dean Herbert · 2022-01-17 14:40:00 +09:00
  381174e482
• Initialise all parameters is paramaterless constructor for now for added safety
  Dean Herbert · 2022-01-17 13:51:30 +09:00
  744084b418
• Fix GetDisplayTitleRomanisable() relying on ToString() implementation
  Bartłomiej Dach · 2022-01-15 15:26:41 +01:00
  e75d21507c
• Return immediately on failed web request in synchronous BeatmapOnlineLookupQueue flow
  Dean Herbert · 2022-01-14 13:20:51 +09:00
  dea2e1fac0
• Remove unused cancellationToken parameter in synchronous BeatmapOnlineLookupQueue flow
  Dean Herbert · 2022-01-14 13:19:00 +09:00
  8424d86e9a
• Ensure detached when performing model Clone operations on BeatmapInfo/ScoreInfo
  Dean Herbert · 2022-01-14 13:08:20 +09:00
  9b33fbbee5
• Add EF to realm beatmap migration
  Dean Herbert · 2022-01-13 18:23:18 +09:00
  b610d2db12
• Remove pointless compatibility parameter BeatmapSetInfoID
  Dean Herbert · 2022-01-13 18:02:10 +09:00
  069d6d2954
• Add synchronous fetch flow to BeatmapOnlineLookupQueue

  The async flow doesn't work great with the realm import process. We
  might be able to improve on this going forward, but for the time being
  adding a synchronous path seems safest.
  
  After all, we are already an an asynchronous (dedicated) thread pool at
  this point.

  Dean Herbert · 2022-01-13 16:36:54 +09:00
  93c78253d6
• Use ctor rather than MemberwiseClone to guarantee a safer clone of BeatmapDifficulty
  Dean Herbert · 2022-01-13 13:23:41 +09:00
  b77cb344d5
• Remove unnecessary Ruleset null check in BeatmapDifficultyCache
  Dean Herbert · 2022-01-13 13:19:49 +09:00
  86b2ac3217
• Replace compatibility properties with direct references
  Dean Herbert · 2022-01-12 18:13:14 +09:00
  eb70a1eeb7
• Sanitise and remove some usages of Detach which are no longer required
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  34aa1bf21d
• Ensure scores are cleaned up alongside beatmap so they don't have a null reference
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  5f7365e8f3
• Make copying detached changes to realm only exposed for BeatmapSet

  Also fixes remaining issues with the copy process.

  Dean Herbert · 2022-01-12 17:49:11 +09:00
  f24b2b1be3
• Move manager Update methods to be explicit to where they are still used by legacy code

  Also fixes skin hash repopulation being completely broken.

  Dean Herbert · 2022-01-12 17:49:11 +09:00
  a4de0f93fa
• Add equatable support to IUser and RealmUser

  Not sure this will stick, but let's add it for now to make testing
  detach support work nicely.

  Dean Herbert · 2022-01-12 17:49:11 +09:00
  51d6db1bca
• Fix protected beatmap sets getting deleted
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  157dfdaa82
• Fix beatmap restore/undelete flows
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  72656ae01e
• Fix beatmap mass deletion flow
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  46206f70d6
• Add refetch for non-managed hide/restore attempts
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  d5239d550a
• Clean up BeatmapManager query methods
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  46e92c3b60
• Remove hide/restore event flow
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  9beabad6a4
• Fix multiple remaining warnings
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  c06b5951fd
• Update BeatmapModelManager.Save to work for editor scenarios
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  7509a9ff8f
• Fix incorrect realm access after new beatmap import
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  8c3dc4333d
• Add back caching in WorkingBeatmapCache
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  2ce80cc030
• Fix BeatmapDifficulty cloning regression
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  286994a808
• Update null allowances across beatmaps and scores
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  f451560203
• Ensure BeatmapInfo Difficulty and Metadata is non-null
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  6033a825ed
• Add note about BeatmapMetadata.Author being weird
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  a0f8debafe
• Mention safety failures of Beatmap/Score constructors
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  83ccbc1d13
• Fix BeatmapInfo.Clone potentially not cloning if already detached
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  c831e9107a
• Fix incorrect BeatmapInfo.ToString implementation
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  e5af673b01
• Fix multiple tests via null checks and changing ToLive to Detach

  flow

  Dean Herbert · 2022-01-12 17:00:17 +09:00
  e74a5022c9
• Fix BeatmapDifficultyCache not working with detached beatmaps
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  76670a8faa
• Handle ignored mappings locally in Detach configuration
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  aaefd72c69
• BeatmapSetInfo detach support
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  8461eaab46
• Fix some null inspections
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  3811bd8520