377 Commits

• Attempt to fix flaky TestGameplaySettingsDoesNotExpandWhenSkinOverlayPresent

  See https://github.com/ppy/osu/pull/35118/checks?check_run_id=51202910556.

  Dean Herbert · 2025-09-25 15:56:48 +09:00
  12e29f0bcc
• Apply suggested rename
  Bartłomiej Dach · 2025-08-29 09:58:56 +02:00
  526ee32268
• Adjust tests to new beatmap set model usage in carousel
  Bartłomiej Dach · 2025-08-28 13:09:11 +02:00
  6ba72fa481
• Merge pull request #34491 from peppy/wedge-background-click-block

  Fix clicks propagating through personal best score area

  Bartłomiej Dach · 2025-08-04 12:56:40 +02:00
  3bfe2581a4
• Fix test failure due to over-scoping
  Dean Herbert · 2025-08-04 18:53:55 +09:00
  13ff11ac85
• Fix skin editor tests not passing on macOS
  Dan Balasescu · 2025-08-03 03:50:06 +09:00
  0270ca6cf1
• Remove duplicate test
  Dean Herbert · 2025-07-24 13:24:57 +09:00
  ad9584e658
• Adjust variable name
  eyhn · 2025-07-23 22:33:22 +08:00
  843cd86551
• Fix present beatmap audio start at the preview point
  eyhn · 2025-07-23 22:29:07 +08:00
  e55a9e486b
• Fix flaky playlists navigation test

  See: https://github.com/ppy/osu/actions/runs/16267403227/job/45929099025
  
  Repro:
  
  ```diff
  diff --git a/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs b/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs
  index a4e808ff76..db0a0e83a6 100644
  --- a/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs
  +++ b/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs
  @@ -88,6 +88,7 @@ public abstract partial class LoungeSubScreen : OnlinePlaySubScreen, IOnlinePlay
           [BackgroundDependencyLoader(true)]
           private void load()
           {
  +            System.Threading.Thread.Sleep(1000);
               Masking = true;
  
               const float controls_area_height = 25f;
  
  ```

  Dan Balasescu · 2025-07-14 22:41:08 +09:00
  3a3c1c4e09
• Remove duplicated test method
  Dean Herbert · 2025-07-01 17:34:52 +09:00
  99220408f6
• Update existing tests to work with Song Select v2
  Dean Herbert · 2025-07-01 17:25:38 +09:00
  397b9b3994
• Attempt to fix flaky test TestExitWithHoldDisabled

  See
  https://github.com/ppy/osu/actions/runs/15915618971/job/44892620536#step:5:203.
  
  Note that the `DialogOverlay` only finishes loading after the until step
  failure.

  Dean Herbert · 2025-06-27 14:32:58 +09:00
  e713a68c49
• Add failing test
  Bartłomiej Dach · 2025-06-25 09:47:53 +02:00
  57bfb37888
• Add failing test case
  Salman Alshamrani · 2025-06-18 19:19:54 +03:00
  9cb824df6f
• Increase hitbox for footer back button

  Based on countless feedback of users wanting to be able to throw their
  mouse into the corner of the screen to go back. It makes sense.

  Dean Herbert · 2025-06-11 18:00:22 +09:00
  70a5474489
• Add test coverage of editor flow from song select
  Dean Herbert · 2025-06-05 03:49:00 +09:00
  bb49bb5e23
• Add back more song select navigation tests
  Dean Herbert · 2025-06-05 03:49:00 +09:00
  118583bf21
• Merge pull request #33413 from bdach/update-framework

  Update framework

  Dean Herbert · 2025-06-05 03:15:27 +09:00
  6d5bf22a71
• Fix cursor test
  Bartłomiej Dach · 2025-06-04 13:34:21 +02:00
  68795255ee
• Mark test scene class partial
  Bartłomiej Dach · 2025-06-04 11:23:10 +02:00
  2cd923ba26
• Add back test covering immediate exit song select
  Dean Herbert · 2025-06-04 17:59:08 +09:00
  7d8df1d8d4
• Fix audio not correctly continuing on resuming from gameplay
  Dean Herbert · 2025-06-04 17:39:22 +09:00
  f086be9c18
• Fix test being sensitive to selected tab on new song select
  Bartłomiej Dach · 2025-05-30 10:02:40 +02:00
  9d0d3bb97a
• Add test coverage of volume changing while at song select

  This passes without changes in this pull request. But I'm just copying
  across from https://github.com/ppy/osu/pull/33225 to stay in theme?

  Dean Herbert · 2025-05-27 15:53:31 +09:00
  7d8dc1bd0a
• Fix footer buttons not restoring when exiting an already displayed screen

  Closes https://github.com/ppy/osu/issues/33168.

  Dean Herbert · 2025-05-18 16:53:33 +09:00
  bec3450a44
• Merge branch 'master' into tidy-screen-footer
  Bartłomiej Dach · 2025-05-15 12:55:28 +02:00
  0132b78eec
• Fix nullability inspections
  Bartłomiej Dach · 2025-05-15 12:55:21 +02:00
  840e51e6a1
• Add failing test case
  Salman Alshamrani · 2025-05-14 21:45:30 +03:00
  7dc9ea6774
• Allow accessing song select v2 by holding control while entering song select
  Dean Herbert · 2025-05-14 17:06:18 +09:00
  0a3f05c52b
• Move "local" test to "navigation" namespace
  Dean Herbert · 2025-05-13 17:22:01 +09:00
  238855c4cc
• Disallow adjusting scroll speed during gameplay

  Matches stable. Addresses https://github.com/ppy/osu/discussions/32670.

  Dean Herbert · 2025-04-04 19:46:14 +09:00
  32c60bfb36
• Minor bump some packages
  Dean Herbert · 2025-02-17 15:23:26 +09:00
  db4a4a1723
• Remove stray [Solo]s
  Dean Herbert · 2025-02-07 15:30:31 +09:00
  aa329f397e
• Add failing test coverage of random rewind button not working
  Dean Herbert · 2025-01-21 17:24:41 +09:00
  c8cc36e9af
• Fix test potentially false-negative due to realm write delays
  Dean Herbert · 2025-01-17 14:16:38 +09:00
  224f39825f
• Add failing test coverage showing offset adjust is not limited correctly
  Dean Herbert · 2025-01-16 18:05:58 +09:00
  a4174a3644
• Adjust test to pass

  What I think was happening here is that the dump of the accuracy
  counter's state was happening too early. The component is loaded
  synchronously into the `ISerialisableDrawableContainer` before its
  default position is set via the "apply defaults" `ArgonSkin` flow
  - so the test needs to wait for that to take place first.

  Bartłomiej Dach · 2025-01-13 13:14:34 +01:00
  39a69d6454
• Merge branch 'master' into fix-skin-editor-undo
  Bartłomiej Dach · 2025-01-13 12:39:51 +01:00
  8968ab19d9
• Flip navigation test expectations in line with new behaviour
  Dean Herbert · 2025-01-04 00:55:12 +09:00
  1161b7b3c0
• Fix mouse wheel disable not working during gameplay
  Dean Herbert · 2024-12-20 16:31:06 +09:00
  5d17014698
• Add failing test showing player settings appearing in skin editor
  Dean Herbert · 2024-12-13 17:18:34 +09:00
  b470e30cc0
• Update usages of IPC in line with framework changes
  Dean Herbert · 2024-12-03 16:34:23 +09:00
  75781e3436
• Add test coverage governing new behaviour
  Dean Herbert · 2024-11-28 18:03:19 +09:00
  c26c84ba45
• Add failing test coverage of skin editor still not undoing correctly to initial state
  Bartłomiej Dach · 2024-10-16 14:21:07 +02:00
  f84f6b78d9
• Also ensure filter is applied when returning to song select
  Dean Herbert · 2024-09-18 17:22:08 +09:00
  743d509241
• Add failing test showing crash at song select on selection edge case
  Dean Herbert · 2024-09-18 16:12:34 +09:00
  aae98e6906
• Fix some tests not always waiting long enough for beatmap loading

  These used to work because there was a huge blocking load operation,
  which is now more asynchronous.
  
  Note that the change made in `SongSelect` is not required, but defensive
  (feels it should have been doing this the whole time).

  Dean Herbert · 2024-08-29 18:42:43 +09:00
  def1abaeca
• Fix multiple test failures
  Dean Herbert · 2024-08-28 23:28:43 +09:00
  9123d2cb7f
• Rename SkinComponentsContainer to SkinnableContainer
  Dean Herbert · 2024-08-22 17:42:50 +09:00
  41756520b1