55 Commits

• Remove no longer required nested object reposition hacks

  As touched on in
  https://github.com/ppy/osu/issues/30237#issuecomment-2408557766, these
  types of maneouvers are no longer required after
  https://github.com/ppy/osu/pull/30021 - although as it turns out on
  closer inspection, these things being there still *did not actually
  break anything*, because the `slider.Path` mutation at the end of
  `modifySlider()` causes `updateNestedPositions()` to be called
  eventually anyway. So this is at mostly a code quality upgrade.

  Bartłomiej Dach · 2024-10-14 14:26:27 +02:00
  1f1a174c50
• Remove unused member
  Bartłomiej Dach · 2024-09-30 09:30:06 +02:00
  31d1ba4949
• Fix random mod needlessly trying to fix nested object positions on its own
  Bartłomiej Dach · 2024-09-27 10:28:32 +02:00
  89f47c4654
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Apply "reflect" vernacular in nested methods
  Bartłomiej Dach · 2022-12-07 23:27:02 +01:00
  7676838cc0
• Disambiguate object flipping and reflection methods
  apollo-dw · 2022-12-07 21:09:53 +00:00
  684b16cef5
• Reflect nested objects vertically in the playfield correctly
  apollo-dw · 2022-12-07 20:20:11 +00:00
  1776485b93
• Update ReflectHorizontally() and ReflectVertically() to use FlipSliderHorizontally() and modifySlider().
  Pasi4K5 · 2022-12-07 01:05:15 +01:00
  8f3023ffd9
• Rename FlipSlider() to FlipSliderHorizontally
  Pasi4K5 · 2022-12-07 00:48:25 +01:00
  91e9c27507
• Allow random mod to flip sliders
  Pasi4K5 · 2022-12-07 00:40:18 +01:00
  30952199b8
• Refactor IsHitObjectOnBeat to be understandable
  Dean Herbert · 2022-09-09 18:00:51 +09:00
  31cd7cdca0
• Merge branch 'ppy:master' into enhance-randomisation
  Pascal Pomper · 2022-08-10 12:22:39 +02:00
  f98ee3ff24
• update new usage of CalculatePossibleMovementBounds
  Gabe Livengood · 2022-07-08 12:00:07 -04:00
  a606d545c1
• Merge branch 'master' into osu-mod-repel
  Dean Herbert · 2022-07-09 00:26:49 +09:00
  36f129a9b6
• Merge pull request #18596 from hlysine/fix-random-mod-slider

  Fix random mod generating off-screen sliders

  Dean Herbert · 2022-07-08 19:28:34 +09:00
  8071335f3a
• Merge branch 'master' into osu-mod-repel
  Gabe Livengood · 2022-07-06 17:05:09 -04:00
  b3f23d93e8
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Add comments and XML doc
  Pasi4K5 · 2022-06-22 16:49:07 +02:00
  2f1186d328
• Fix possible exception caused by log(0)
  Pasi4K5 · 2022-06-20 00:19:29 +02:00
  a912bcadf8
• Code optimisation
  Pasi4K5 · 2022-06-19 23:03:41 +02:00
  1bb27cd488
• Add XML documentation
  Pasi4K5 · 2022-06-19 20:43:17 +02:00
  9090e75020
• Adjust target angle calculation parameters
  Pasi4K5 · 2022-06-19 13:50:09 +02:00
  33c6c6af6b
• Enhance target angle calculation
  Pasi4K5 · 2022-06-19 13:07:10 +02:00
  c6ac60c0b5
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• revert slider radius parameter addition
  Gabe Livengood · 2022-06-09 18:07:37 -04:00
  6e883a69d9
• clamp sliders, expose slider bounds function
  Gabe Livengood · 2022-06-07 09:36:44 -04:00
  b7bdad4074
• Limit slider rotation when the slider is too large
  Henry Lin · 2022-06-07 10:32:51 +08:00
  de224e79c7
• Add inline comments
  Henry Lin · 2022-04-18 09:38:51 +08:00
  e5e1960975
• Clarify in the xmldoc that angles are measured in radians
  Henry Lin · 2022-04-17 10:40:43 +08:00
  1d79266d42
• Use a bigger sample step to calculate slider center of mass
  Henry Lin · 2022-04-17 10:34:48 +08:00
  610d2dc1a3
• USe MathF in all applicable places
  Henry Lin · 2022-04-11 14:15:08 +08:00
  72cb3d6ad6
• Consider spinners when calculating jump angles

  Spinners are considered in `GeneratePositionInfos`, so they should also be considered in `RepositionHitObjects`

  Henry Lin · 2022-04-01 11:59:24 +08:00
  3bebc88306
• Calculate slider rotation using end point of path instead of EndPosition
  Henry Lin · 2022-04-01 11:50:30 +08:00
  031a977009
• Add xmldoc
  Henry Lin · 2022-04-01 11:49:27 +08:00
  0015f627b0
• Fix generation for zero-length sliders
  Henry Lin · 2022-04-01 11:47:21 +08:00
  c0a78924aa
• Fix slider relative rotation calculation
  Henry Lin · 2022-04-01 11:41:45 +08:00
  af3835083c
• Fix large slider clamping
  Henry Lin · 2022-04-01 11:37:10 +08:00
  998df5a4fe
• Rotate sliders in random mod
  Henry Lin · 2022-04-01 11:36:20 +08:00
  cabbc486e9
• Remove extra parameters
  Henry Lin · 2022-03-14 20:23:35 +08:00
  76021c7627
• Separate the two nested classes
  Henry Lin · 2022-03-14 20:18:30 +08:00
  6657d93b29
• Convert IObjectPositionInfo to a class
  Henry Lin · 2022-03-10 12:02:25 +08:00
  5e36383258
• Convert the position modifier to stateless methods
  Henry Lin · 2022-03-10 11:53:03 +08:00
  3a71d81775
• Use ObjectPositionInfo.HitObject
  Henry Lin · 2022-03-10 11:23:52 +08:00
  ede838c4b3
• Move OsuHitObjectPositionModifier to Utils/
  Henry Lin · 2022-03-09 21:52:15 +08:00
  e8dbed738e
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Remove bindable usage in PathControlPoint

  This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
  
  I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.

  Dean Herbert · 2021-08-26 12:33:53 +09:00
  6dcd9427ac
• Fix flipped xmldoc
  Salman Ahmed · 2021-07-27 18:24:17 +03:00
  5cb02002d7
• review modifications: change xmldocs, change reflection method name, remove reflection method returns, simplify incompat. mod list
  Gabe Livengood · 2021-07-27 09:01:01 -04:00
  c741366c72
• review modifications: change xmldoc wording, configure with enum instead of bool, declare incompatibility with hr
  Gabe Livengood · 2021-07-26 17:48:03 -04:00
  c7c261ba03
• review modifications: maniamodmirror inheritance, reflection utilities, vertical flip option
  Gabe Livengood · 2021-07-26 10:46:41 -04:00
  49160e4482