151 Commits

• Calculate hit windows in performance calculator instead of databased difficulty attributes (#31735)

  * Calculate hit windows in performance calculator instead of databased difficulty attributes
  
  * Apply mods to beatmap difficulty in osu! performance calculator
  
  * Remove `GreatHitWindow` difficulty attribute for osu!mania
  
  * Remove use of approach rate and overall difficulty attributes for osu!
  
  * Remove use of hit window difficulty attributes in osu!taiko
  
  * Remove use of approach rate attribute in osu!catch
  
  * Remove unused attribute IDs
  
  * Code quality
  
  * Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set

  James Wilson · 2025-02-07 19:21:12 +09:00
  9f90ebb2f7
• Replace indexed skill access with skills.OfType<...>().Single() (#30034)

  * Replace indexed skill access with `skills.First(s is ...)`
  
  * Fix comment
  
  * Further refactoring to remove casts
  
  ---------
  
  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  StanR · 2025-01-20 09:39:35 +00:00
  22e839d62b
• Add DifficultyCalculationUtils
  StanR · 2024-11-07 20:36:00 +05:00
  78c97d2cd7
• Bump difficulty calculator versions

  In order for the new star difficulty to be shown to users on the next
  release.
  
  catch's difficulty calculator version is not bumped because the only
  catch change pending deploy is https://github.com/ppy/osu/pull/28353 and
  that affects performance points only.

  Bartłomiej Dach · 2024-10-07 15:38:41 +02:00
  1af464d5ae
• fixed CI
  Givikap120 · 2024-08-05 17:02:37 +03:00
  174f4d3ab7
• merged multipliers
  Givikap120 · 2024-08-05 16:33:42 +03:00
  e6fc4f6766
• Refactor score simulator to use GetColumnCount()
  Dan Balasescu · 2024-03-28 22:58:39 +09:00
  c08a4898b2
• Bump databased star rating versions
  Dan Balasescu · 2024-02-06 22:58:11 +09:00
  ee05743921
• Populate MaxCombo scoring attrib for non-osu rulesets
  Dan Balasescu · 2023-12-18 12:01:51 +09:00
  30116512ca
• Add method to retrieve legacy score multiplier
  Dan Balasescu · 2023-10-02 16:52:01 +09:00
  da2a4681d9
• Split legacy scoring attributes into a separate object
  Dan Balasescu · 2023-09-07 21:10:38 +09:00
  2334be1987
• Merge branch 'master' into LNFixHotfix
  Dan Balasescu · 2023-08-15 13:45:06 +02:00
  7d8cef83e6
• 2nd fix to cover all scenarios
  Hydria · 2023-07-22 16:44:01 +01:00
  1e19def153
• Fix issue with processing LN orders

  Related Issue: https://github.com/ppy/osu/issues/22756
  
  The trigger in question happens when
  (1) in a chord: a longer LN, then a shorter LN is processed respectively.
  (2) in a chord: a long LN, then a note is processed respectively.
  
  however, given the opposite processing step, it will fail to trigger.
  
  We observe that both situations have the same pattern, however has undeterministic results, which only depends on the order the mapper placed each note.

  Hydria · 2023-07-22 10:45:48 +01:00
  ef2134a92a
• ILegacyScoreProcessor -> ILegacyScoreSimulator
  Dean Herbert · 2023-07-04 17:32:54 +09:00
  1629024111
• Finalised LN Adjustment Values

  Spent a couple days discussing this on the pp rework server about values that were the most acceptable, these seemed to be the best from the community standpoint of top players.
  Note: This is more to fix issues with the current system, not to be a final solution.
  Related Google Sheets Page: https://docs.google.com/spreadsheets/d/1P0AxfdKvMHwWBQder4ZkFGO1fC9eADSGCryA5-UGriU/edit?usp=sharing

  Hydria · 2023-07-03 17:45:30 +01:00
  5d5e6a5ab7
• Apply a few other code reviews
  Dan Balasescu · 2023-06-29 17:28:06 +09:00
  426f11b824
• Refactoring
  Dan Balasescu · 2023-06-28 16:14:32 +09:00
  09bc8e45de
• Initial conversion of scores
  Dan Balasescu · 2023-06-26 22:19:01 +09:00
  a9c65d200a
• Merge branch 'master' into diffcalc-total-scorev1
  Dan Balasescu · 2023-06-26 14:32:14 +09:00
  e1d723a2cc
• Add flag to disable computing legacy scoring values
  Dan Balasescu · 2023-06-24 01:03:18 +09:00
  06565871d6
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Adjust attribute data
  Dan Balasescu · 2023-06-19 21:38:13 +09:00
  bfa449e47a
• Fix exception with no matching mods
  Dan Balasescu · 2023-06-15 19:55:51 +09:00
  975e9baf43
• Add ScoreV1 calculation for ManiaRuleset
  Dan Balasescu · 2023-06-13 23:28:45 +09:00
  13d1f9c902
• Write max combo attribute from base class
  Dan Balasescu · 2023-06-02 21:53:25 +09:00
  e402c6d2b4
• Remove whitespace
  Dan Balasescu · 2022-10-11 13:53:18 +09:00
  ed2b39a220
• rename method to reflect being a method
  Natelytle · 2022-10-10 13:52:01 -04:00
  cc54fc5c1b
• slight formatting
  Natelytle · 2022-10-10 13:45:16 -04:00
  430eb44446
• Fix division by 0
  Natelytle · 2022-10-10 13:36:52 -04:00
  32adc1ec14
• Bump difficulty calculator versions
  Dan Balasescu · 2022-09-02 16:27:25 +09:00
  9645bfe708
• Add explanatory comment
  Dan Balasescu · 2022-08-17 19:03:48 +09:00
  f381bc9115
• update comment and deltaTime check
  63411 · 2022-08-16 11:03:18 +08:00
  b33e0f5e1c
• Merge branch 'master' into mania-note-order-fix
  Dan Balasescu · 2022-08-15 23:44:02 +09:00
  5f70ee3ed7
• Add versioning to difficulty calculators
  Dean Herbert · 2022-07-21 18:15:25 +09:00
  aca19a005e
• individualStrain should be the hardest individualStrain column for notes in a chord
  63411 · 2022-07-14 15:07:58 +08:00
  4fdbf3ff24
• Merge branch 'ppy:master' into mania-difficulty-refactor
  molneya · 2022-07-01 11:04:55 +00:00
  11c7756670
• Merge branch 'master' into accuracy-pp-curve
  Dan Balasescu · 2022-06-29 16:48:11 +09:00
  5cdf98b4dc
• apply individualStrain decay only when a note appears in that column
  63411 · 2022-06-28 20:32:35 +08:00
  2b42dfb9cb
• Remove NRT disables from attributes classes
  Dan Balasescu · 2022-06-27 16:07:15 +09:00
  0fd2c010e5
• Add IBeatmapOnlineInfo parameter and use to extract more data
  Dan Balasescu · 2022-06-27 16:07:15 +09:00
  0579780bb8
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• revert customAccuracy changes
  63411 · 2022-06-23 15:51:28 +08:00
  9be13f88fd
• Reduce NoFail pp multiplier
  63411 · 2022-06-20 19:55:26 +08:00
  58d6fa4645
• Adjust customAccuracy formula slightly
  63411 · 2022-06-18 22:27:28 +08:00
  984634c580
• Update comments
  63411 · 2022-06-18 12:20:47 +08:00
  361a87412b
• Fix code style
  63411 · 2022-06-18 00:45:34 +08:00
  451d4154f0
• Remove unneeded attributes
  63411 · 2022-06-17 23:44:10 +08:00
  e238bcc6c6
• Use accuracy for pp calculation
  63411 · 2022-06-17 23:38:22 +08:00
  9fe7636138
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850