Dean Herbert
32b34c1967
Rename container to make more sense
2024-11-28 15:20:51 +09:00
Dean Herbert
4d9d5adbf4
Rename parameter to be more clear
2024-11-28 15:13:59 +09:00
Salman Alshamrani
19e396f878
Fix android workflow not installing .NET 8 version
2024-11-27 23:46:21 -05:00
Dean Herbert
e0fdcaf523
Merge pull request #30848 from Joehuu/dicord-fix-beatmap-button-visibility
...
Fix discord "view beatmap" button being shown when editing and hide identifiable information is set
2024-11-28 13:29:09 +09:00
Salman Alshamrani
24c0799680
Move beatmap ID lookup to UesrActivity
2024-11-27 16:54:51 -05:00
Salman Alshamrani
238a1ce284
Fix tests reliability and improve code
...
Shaved off lots of copypasta so the test actually shows what it's testing.
2024-11-27 15:27:21 -05:00
Salman Alshamrani
f792b6de00
Fix comment
2024-11-27 06:07:10 -05:00
Salman Alshamrani
4ae3ccfe48
Make BackButtonVisibility in game class private
2024-11-27 06:05:02 -05:00
Salman Alshamrani
4b8094d0db
Update test coverage
2024-11-27 05:58:06 -05:00
Salman Alshamrani
efb68e4232
Refactor ResourcesSection to support new form of selection
2024-11-27 05:53:22 -05:00
Salman Alshamrani
b70fb4b0fe
Add FormBeatmapFileSelector for intermediate user-choice step
2024-11-27 05:52:43 -05:00
Dean Herbert
0f73941808
Combine new implementation back into the old one and use everywhere
2024-11-27 17:47:42 +09:00
Dean Herbert
7fdf13911b
Adjust the colour of non-pinned settings groups' headers to be more legible
2024-11-27 17:47:27 +09:00
Dean Herbert
782ce24ca6
Move player settings out of right flow
2024-11-27 17:09:15 +09:00
Dean Herbert
9c707ed341
Rename class and fix padding considerations
2024-11-27 16:47:54 +09:00
Dean Herbert
5ce55e9cb4
Merge branch 'master' into multi-spectator-settings-sidebar
2024-11-27 16:35:05 +09:00
HenintsoaSky
c3ac6d7fe5
Delete changes.patch
...
oops
2024-11-27 10:22:30 +03:00
Dean Herbert
4fcc76270a
Ensure events are unbound on disposal as a safety
2024-11-27 15:46:55 +09:00
Dean Herbert
5260a401d4
Use RealmLive in SaveFailedScoreButton
...
This also optimises the manager classes to better support `Live` usage
where the managed object is already in a good state (ie. doesn't require
re-fetching).
2024-11-27 15:25:42 +09:00
Salman Alshamrani
dfbccc2144
Knock some sense into the playlists results screen implementation
...
As we're moving towards using the `/playlist/<id>/scores/<id>` endpoint,
the existing playlists results screen classes needed some restructuring.
2024-11-27 01:20:43 -05:00
Dean Herbert
aa3d3a6344
Remove unnecessary local subscription in BeatmapCarousel
...
Not sure why I left this around during the refactor. This is 100%
handled by the `DetachedBeatmapStore`.
Removing this subscription reduces overheads by a huge amount for users
with large beatmap databases. My hypothesis is that subscriptions are
more expensive based on **the number of results matching**. This one
matches almost every beatmap so removing it is a large win.
2024-11-27 14:24:57 +09:00
HenintsoaSky
a477bb7bfe
Renaming of 'StarFountainEnabled'
2024-11-27 07:38:33 +03:00
Dean Herbert
573aaf6637
Merge pull request #27128 from frenzibyte/user-statistics-provider
...
Introduce `UserStatisticsProvider` component and add support for respecting selected ruleset
2024-11-27 13:13:47 +09:00
Salman Alshamrani
9083daf363
Fix epic code failure
...
I wasn't feeling well last night.
2024-11-26 20:04:36 -05:00
HenintsoaSky
16d8b11385
A toggle for star fountains
2024-11-27 00:53:22 +03:00
Salman Alshamrani
3e1b4f4ac5
Rename AllowBackButton to AllowUserExit and rewrite visibility flow structure
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-11-26 16:52:39 -05:00
HenintsoaSky
80a66085a9
rename and remove again
2024-11-27 00:41:02 +03:00
HenintsoaSky
460471e73f
Rename of the setting
2024-11-27 00:27:22 +03:00
HenintsoaSky
df74a177ae
Add option to disable star fountain in gameplay
2024-11-27 00:13:32 +03:00
Joseph Madamba
a1a63608dd
Merge pull request #30865 from ItsShamed/xxx-add-localisation-support-for-menu-tip
...
Add localisation support for menu tip
2024-11-26 12:54:17 -08:00
Joseph Madamba
9173a74552
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip
2024-11-26 12:13:08 -08:00
Joseph Madamba
f04862ea74
Edit one more word not using british english
2024-11-26 12:11:29 -08:00
Bartłomiej Dach
359cb71dd9
Merge pull request #30884 from peppy/fix-spinner-legacy-new-order-
...
Fix classic skin spinner's middle pieces displaying in the wrong order
2024-11-26 14:57:42 +01:00
Bartłomiej Dach
33c2eb1af7
Merge pull request #30881 from peppy/fix-editor-state-leaking
...
Fix hitobjects' samples getting in bad state when changing selection between objects
2024-11-26 13:54:50 +01:00
Bartłomiej Dach
3e373ae85e
Merge pull request #30868 from peppy/ur-perf-fix
...
Improve performance of UR calculations
2024-11-26 13:54:17 +01:00
Dan Balasescu
bd1f978138
Empty commit to fix CI
2024-11-26 21:35:24 +09:00
Dan Balasescu
4c7976bb93
Remove unused using
2024-11-26 21:11:48 +09:00
Dan Balasescu
af0c6fc51b
Add Room.HasEnded helper method
2024-11-26 21:09:28 +09:00
Bartłomiej Dach
c69d36dc96
Remove leftover [Solo] attribute
2024-11-26 12:40:49 +01:00
Bartłomiej Dach
46d1f00590
Fix Beatmap.Countdown not being copied on conversion
2024-11-26 11:39:03 +01:00
Bartłomiej Dach
cf905d0f5c
Merge branch 'master' into beatmap-info-purge
2024-11-26 10:21:16 +01:00
Dean Herbert
312336de24
Fix classic skin spinner's middle pieces displaying in the wrong order
...
Closes https://github.com/ppy/osu/issues/30873 .
See [stable
reference](3ea48705eb/osu
2024-11-26 18:12:28 +09:00
Dean Herbert
bf29e3ae71
Simplify hide code by moving to common method
2024-11-26 18:00:32 +09:00
Dean Herbert
71294c312b
Change point of queueing to avoid loading-from-in-queue
2024-11-26 17:58:50 +09:00
Dean Herbert
98044c108e
Revert "Ensure DrawableMedal loading doesn't ever block on online resources"
...
This reverts commit 8585327858
2024-11-26 17:41:12 +09:00
tsrk.
41c309fb72
chore(MenuTip): update text according to recent changes
...
Signed-off-by: tsrk. <tsrk@tsrk.me>
2024-11-26 09:35:18 +01:00
Dean Herbert
3ecb3b674d
Don't reset state when changing from one selection to another in the editor
...
This was causing state pollution in the new selection. I can't see why
this needs to happen when a selection changes to another.
This fixes https://github.com/ppy/osu/issues/30839 and also the same
issue happening for the new combo toggle.
Tests all seem to pass, and I can't immediately find anything broken,
but YMMV.
2024-11-26 17:33:41 +09:00
Dean Herbert
e0199386a3
Add failing test case showing changing selection in editor affects samples
2024-11-26 17:33:41 +09:00
Dan Balasescu
d3d111de7d
Merge pull request #30832 from peppy/mania-precise-scroll-speed
...
Allow setting osu!mania scroll speed to single decimal precision
2024-11-26 17:30:56 +09:00
Dan Balasescu
943837e3b5
Merge pull request #30878 from peppy/config-pause-hold-thing-of-course
...
Add setting to allow hold-for-pause to still exist
2024-11-26 16:35:35 +09:00
