70985 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dan Balasescu	11a4e3beb4	Merge pull request #31287 from stanriders/change-relax-leniency ... Change `OsuModRelax` hit leniency to be the same as in stable	2024-12-30 21:42:48 +09:00
Dan Balasescu	c56a6ed595	Merge pull request #31348 from bdach/fix-slider-quick-delete ... Fix quick-deleting unselected slider path control point also deleting all selected control points	2024-12-30 21:33:57 +09:00
Dan Balasescu	ab111178d0	Merge pull request #31352 from bdach/collapse-sample-point-indicators-better ... Take custom bank name length into account when collapsing sample point indicators	2024-12-30 21:32:07 +09:00
Bartłomiej Dach	693db097ee	Take custom bank name length into account when collapsing sample point indicators ... Would close https://github.com/ppy/osu/issues/31312. Not super happy with the performance overhead of this, but this is already a heuristic-based implementation to avoid every-frame `.ChildrenOfType<>()` calls or similar, so not super sure how to do better. The `Array.Contains()` check stands out in profiling, but without it the indicators can collapse *too* eagerly sometimes.	2024-12-30 12:04:41 +01:00
Bartłomiej Dach	182f998f9b	Fix quick-deleting unselected slider path control point also deleting all selected control points ... Closes https://github.com/ppy/osu/issues/31308. Logic matches corresponding quick-delete logic in 130802e480/osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs (L307-L316).	2024-12-30 09:44:04 +01:00
Bartłomiej Dach	aa67f87fe9	Add failing test coverage	2024-12-30 09:42:24 +01:00
Bartłomiej Dach	f18114d2fb	Merge pull request #31282 from peppy/fix-volume-key-repeat ... Fix volume adjust key repeat not working as expected	2024-12-30 08:49:35 +01:00
Dean Herbert	10ee2e28c2	Merge pull request #31303 from bdach/pause-on-gameplay-test ... Pause playback when entering gameplay test from editor	2024-12-28 04:41:28 +09:00
Dean Herbert	ac348b8780	Merge pull request #31307 from bdach/id3-tags ... Populate metadata from ID3 tags when changing beatmap audio track in editor	2024-12-28 02:41:49 +09:00
Dean Herbert	1b2a223a5f	Fix failing test scene due to new dependency	2024-12-28 01:02:15 +09:00
Bartłomiej Dach	6a6db5a22b	Populate metadata from ID3 tags when changing beatmap audio track in editor ... - Closes https://github.com/ppy/osu/issues/21189 - Supersedes / closes https://github.com/ppy/osu-framework/pull/5627 - Supersedes / closes https://github.com/ppy/osu/pull/22235 The reason why I opted for a complete rewrite rather than a revival of that aforementioned pull series is that it always felt quite gross to me to be pulling framework's audio subsystem into the task of reading ID3 tags, and I also partially don't believe that BASS is *good* at reading ID3 tags. Meanwhile, we already have another library pulled in that is *explicitly* intended for reading multimedia metadata, and using it does not require framework changes. (And it was pulled in explicitly for use in the editor verify tab as well.) The hard and dumb part of this diff is hacking the gibson such that the metadata section on setup screen actually *updates itself* after the resources section is done doing its thing. After significant gnashing of teeth I just did the bare minimum to make work by caching a common parent and exposing an `Action?` on it. If anyone has better ideas, I'm all ears.	2024-12-27 15:16:03 +01:00
Dean Herbert	a9a5bb2c6a	Remove duplicated block	2024-12-27 21:36:07 +09:00
Bartłomiej Dach	5abad07412	Pause playback when entering gameplay test from editor ... Closes https://github.com/ppy/osu/issues/31290. Tend to agree that this is a good idea for gameplay test at least. Not sure about other similar interactions like exiting - I don't think it matters what's done in those cases, because for exiting timing is in no way key, so I just applied this locally to gameplay test.	2024-12-27 09:08:16 +01:00
Bartłomiej Dach	ed397c8fee	Add failing assertions	2024-12-27 09:04:41 +01:00
StanR	94d56d3584	Change OsuModRelax hit leniency to be the same as in stable	2024-12-26 18:13:09 +05:00
Bartłomiej Dach	fa0d2f4af2	Merge pull request #31277 from kongehund/switch-scroll-direction-beat-snap ... Switch scroll direction for beat snap	2024-12-26 09:25:32 +01:00
Dean Herbert	2a374c0695	Add migration	2024-12-26 15:46:12 +09:00
Dean Herbert	e752531aec	Fix volume adjust key repeat not working as expected ... Regressed in https://github.com/ppy/osu/pull/31146. Closes part of https://github.com/ppy/osu/issues/31267.	2024-12-26 15:05:59 +09:00
kongehund	1f60adbaf1	Switch scroll direction for beat snap ... Matches stable better	2024-12-26 00:35:21 +01:00
Dean Herbert	62e536baf6	Merge pull request #31138 from bdach/mark-as-played ... Implement ability to mark beatmap as played	2024-12-24 21:43:15 +09:00
Dean Herbert	df3b300fff	Merge pull request #31226 from frenzibyte/fix-raw-input-mobile ... Add `Hidden` cursor state flag on non-desktop platforms as well	2024-12-24 21:35:50 +09:00
Bartłomiej Dach	287b880ec7	Merge pull request #31259 from peppy/intro-volume-adjust ... Fix adjusting volume using scroll wheel not working during intro	2024-12-24 10:18:10 +01:00
Bartłomiej Dach	a169bf557d	Merge pull request #31258 from peppy/reduce-dim-seasonal ... Slightly reduce background brightness at main menu when seasonal lighting is active	2024-12-24 10:18:01 +01:00
Dean Herbert	ce1eda7e54	Fix adjusting volume using scroll wheel not working during intro	2024-12-24 17:11:21 +09:00
Dean Herbert	d8686f55f7	Slightly reduce background brightness at main menu when seasonal lighting is active	2024-12-24 17:10:48 +09:00
Bartłomiej Dach	6b56c658b3	Merge pull request #31254 from peppy/fix-invisible-circle-sprites ... Fix some hitcircle sprites missing in certain skins since last release	2024-12-24 09:05:16 +01:00
Bartłomiej Dach	2211a4d505	Merge pull request #31147 from peppy/editor-beat-snap-adjust-scroll ... Change beat snap divisor adjust defaults to be Ctrl+Scroll instead of Ctrl+Shift+Scroll	2024-12-24 09:03:42 +01:00
Bartłomiej Dach	1f90be3fea	Merge branch 'master' into editor-beat-snap-adjust-scroll	2024-12-24 08:21:34 +01:00
Bartłomiej Dach	d9be172647	Add explanatory comment for schema version bump	2024-12-24 08:21:27 +01:00
Dean Herbert	b8d6bba039	Fix legacy hitcircle fallback logic being broken with recent fix ... I was a bit too eager to replace all calls with the new `provider` in dae380b7fa, while it doesn't actually make sense. To handle the case that was trying to be fixed, using the `provider` to check whether the *prefix* version of the circle sprite is available is enough alone. Closes https://github.com/ppy/osu/issues/31200	2024-12-24 16:05:44 +09:00
Dean Herbert	a5d354d753	Update framework	2024-12-24 15:17:10 +09:00
Dean Herbert	362311d040	Merge pull request #31220 from normalid-awa/feature/skin/rename-skin ... Add ability to rename the skin	2024-12-24 14:24:48 +09:00
Dean Herbert	85f5234880	Merge pull request #31238 from frenzibyte/make-featured-artist-setting ... Save "featured artists" filter to user settings and disable toggling on iOS	2024-12-24 14:07:20 +09:00
Dean Herbert	378bef34ef	Change order of skin layout editor button for better visual balance	2024-12-24 13:42:18 +09:00
Dean Herbert	ae9c7e1b35	Adjust layout and remove localisable strings for temporary buttons	2024-12-24 13:17:58 +09:00
Dean Herbert	8762e3fedb	Always show tooltip, and reword to be always applicable	2024-12-24 12:25:18 +09:00
Dean Herbert	282c67d14b	Update resources	2024-12-24 11:59:45 +09:00
Dean Herbert	7e8aaa68ff	Add keywords for intro-related settings	2024-12-24 11:46:39 +09:00
Salman Alshamrani	6b635d588f	Add tooltip	2024-12-23 10:59:06 -05:00
Salman Alshamrani	7e3477f4bb	Remove unnecessary guarding	2024-12-23 10:54:52 -05:00
Salman Alshamrani	050bf9ec60	Keep 'x' symbol visible even while disabled	2024-12-23 10:52:18 -05:00
Dean Herbert	9ff4a58fa3	Add migration to update users which have previous default bindings for beat snap	2024-12-23 22:14:03 +09:00
Dean Herbert	097828ded2	Fix incorrect mouse wheel mappings	2024-12-23 22:07:42 +09:00
Dean Herbert	7b9f776a14	Merge pull request #31206 from peppy/christmas ... Add christmas / seasonal mode	2024-12-23 16:49:38 +09:00
Dean Herbert	f12fffd116	Fix more than obvious test failure ... Please run tests please run tests please run tests.	2024-12-23 14:43:36 +09:00
Dean Herbert	1a7feeb4ed	Use virtual property rather than inline iOS conditional	2024-12-23 14:39:07 +09:00
Salman Alshamrani	fcfab9e53c	Fix spacing	2024-12-22 10:14:52 -05:00
Dean Herbert	0aed625bb8	Rename variable and adjust commentary	2024-12-22 23:58:35 +09:00
Dean Herbert	e716919a07	Remove redundant && true ... Co-authored-by: Susko3 <Susko3@protonmail.com>	2024-12-22 22:57:17 +09:00
Salman Alshamrani	589e187a80	Disable ability to toggle "featured artists" beatmap listing filter in iOS	2024-12-22 07:50:08 -05:00