Dan Balasescu
|
b5746f5f20
|
Merge pull request #20602 from peppy/mania-fix-object-colouring
Fix osu!mania not colours not always updating when switching skins
|
2022-10-07 19:22:55 +09:00 |
|
Dean Herbert
|
52ad766f86
|
Remove manual binding of nested objects in DrawableManiaHitObject
This is now handled by `Column` itself. Leaving the logic here as well
will cause a circular bindable flow and stack overflow.
|
2022-10-07 18:25:55 +09:00 |
|
Dean Herbert
|
4b772643e9
|
Use bindable flow for transfer of accent colour from columns to hit objects
This fixes the case where changing a skin during gameplay runtime does
not correctly convey colour information to off-screen `DrawableHitObject`s.
|
2022-10-07 18:25:08 +09:00 |
|
Dan Balasescu
|
721189b23a
|
Merge branch 'master' into argon-mania-note
|
2022-10-07 17:34:11 +09:00 |
|
Dean Herbert
|
c7405d1c1c
|
Add missing immediate application of AccentColour in DefaultKeyArea
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
|
2022-10-07 17:00:10 +09:00 |
|
Dean Herbert
|
98b578e8e6
|
Remove left-over incorrect fallback logic
This was moved to `ManiaClassicSkinTransformer`.
|
2022-10-07 16:12:27 +09:00 |
|
Dean Herbert
|
6d14ccb8e0
|
Make special key slightly wider
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
e4e4c1b661
|
Add very temporary mania judgement display for argon skin
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
b95743092d
|
Add argon hit explosion
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
258c935574
|
Remove key area background (the column background is enough to work well)
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
f3e3ee81cb
|
Add column and stage background to argon skin
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
59bbbf1c08
|
Improve colours and hit metrics on key area
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
a543222a2b
|
Add ability to pad stage vertically
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
4cb07b8839
|
Specify column widths for argon
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
6c0923ec1a
|
Add argon hold note pieces
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
a10f9ebfa5
|
Update argon colours to roughly match design spec
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
c1cb62cc35
|
Add basic argon note piece
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
f1ea61b1a2
|
Remove unused colour code
|
2022-10-07 15:24:37 +09:00 |
|
Dean Herbert
|
9a92ff1681
|
Fix SourceChanged unbind directionality and add null check
|
2022-10-07 15:24:37 +09:00 |
|
Dean Herbert
|
dee01abab1
|
Add method to get stage from column index
|
2022-10-07 15:24:37 +09:00 |
|
Dean Herbert
|
eea3d5adb8
|
Standardise column index naming and xmldoc
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
0d21c0e49c
|
Remove StageDefinition from configuration lookups
I added this for future usage, but it turns out I can get the
definitions directly from `ManiaBeatmap`.
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
4a127f5d81
|
Fix classic skin colours sourcing from triangles defaults
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
6b79f16461
|
Make Column.AccentColour bindable
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
532d101080
|
Remove unused class
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
276395f1af
|
Fix column colour not updating on skin change
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
3947011baf
|
Fix regression in legacy dual stage handling logic
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
2ae1aef0be
|
Move column initialisation to ctor and fix remaining tests
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
5fe9b953a5
|
Add back triangles column colours via a transformer
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
1a0b953846
|
Remove unnecessary Beatmap parameter in ManiaLegacySkinTransformer
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
5c48d8931a
|
Add StageDefinition to ManiaSkinConfigurationLookup and make column background colour lookup work
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
9c979044dc
|
Move AccentColour assignment to inside Column
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
46c3cfe54d
|
Remove StageDefinition flow in ManiaSkinComponent
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
7796a4c109
|
Cache StageDefinition for consumption (and remove ColumnType)
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
df3ad618e1
|
Move ColumnType to constructor
|
2022-10-07 15:24:36 +09:00 |
|
Dan Balasescu
|
4e6047f23d
|
Merge pull request #20571 from peppy/argon-mania
Add "argon" key area for osu!mania
|
2022-10-07 15:19:18 +09:00 |
|
ekrctb
|
ea4dbc8c0f
|
Fix mania hold note head disappears
|
2022-10-06 19:46:10 +09:00 |
|
Dean Herbert
|
395ab58892
|
Attempt to fix code style infractions
|
2022-10-04 16:17:38 +09:00 |
|
Dean Herbert
|
345430ab39
|
Fix argon hit target area not being aligned correctly
|
2022-10-04 16:16:09 +09:00 |
|
ekrctb
|
15d159a97e
|
Fix tests
|
2022-10-04 16:10:18 +09:00 |
|
Dean Herbert
|
1ffa0afafc
|
Tweak visuals and fix up code quality
|
2022-10-04 16:05:36 +09:00 |
|
ekrctb
|
2aa4d21c75
|
Remove code that is not needed anymore
|
2022-10-04 15:17:14 +09:00 |
|
Dean Herbert
|
36e2f5c512
|
Add argon hit target pieces
|
2022-10-04 14:56:46 +09:00 |
|
Dean Herbert
|
d32eb64561
|
Adjust colour application to stay around a bit longer
|
2022-10-04 14:56:46 +09:00 |
|
Dean Herbert
|
4718f4ac24
|
Add second icon and improve glow effect
|
2022-10-04 14:56:46 +09:00 |
|
Dean Herbert
|
83e7cc1e09
|
Add argon key area
|
2022-10-04 14:56:46 +09:00 |
|
Dean Herbert
|
97207c11f5
|
Add base transformer for osu!mania argon skin
|
2022-10-04 14:56:46 +09:00 |
|
Dan Balasescu
|
1890a66b28
|
Merge pull request #20509 from o-dasher/cleanup-setting-sources
Removes unnecessary setting sources specifications
|
2022-09-28 17:55:42 +09:00 |
|
Dan Balasescu
|
cbed268ac9
|
Merge pull request #20510 from sw1tchbl4d3r/high_bpm_judgements
Clamp `LifetimeStart` of `HitObject`s to their judgement windows
|
2022-09-28 17:49:35 +09:00 |
|
sw1tchbl4d3
|
0cffbb7562
|
Clamp LifetimeStart of HitObject's to their judgement windows
|
2022-09-27 16:54:24 +02:00 |
|