Andrei Zavatski
871bdb9cf7
Reduce string allocations in TimeInfoContainer
2024-02-20 20:31:18 +03:00
Andrei Zavatski
6678c4783b
Fix PlaybackControl string allocations
2024-02-20 19:31:28 +03:00
Dean Herbert
ef413c08f1
Merge pull request #27249 from EVAST9919/editor-alloc
...
Reduce osu editor allocations with many objects selected
2024-02-20 15:06:25 +08:00
Dean Herbert
3ea47e64f0
Merge pull request #27258 from Loreos7/storage-error-localisation
...
Localise storage error popup dialog
2024-02-20 13:37:10 +08:00
Andrei Zavatski
c758640311
Reduce allocations in ComposerDistanceSnapProvider
2024-02-19 20:49:56 +03:00
Mike Will
012d6b7fe1
Change userBeatmapOffsetClock to a FramedOffsetClock
...
Assuming that the global audio offset is set perfectly, such that
any audio latency is fully accounted for, if a specific beatmap
still sounds out of sync, that would no longer be a latency issue.
Instead, it would indicate a misalignment between the beatmap's
track and time codes, the correction for which should be a
virtual-time offset, not a real-time offset.
2024-02-19 09:14:49 -05:00
Dean Herbert
c87bc8b597
Merge pull request #27180 from bdach/better-submission-failure-messaging
...
Add better submission failure messaging
2024-02-19 21:38:23 +08:00
Bartłomiej Dach
ec26ab51d1
Use different wording
2024-02-19 13:56:21 +01:00
Bartłomiej Dach
d7b1e3ba50
Merge pull request #27226 from peppy/no-audio-filter-funny-business
...
Ensure audio filters can't be attached before load (or post-disposal)
2024-02-19 13:01:34 +01:00
Dean Herbert
398eaee5d0
Merge pull request #27238 from bdach/disable-nested-managers-when-skin-editor-open
...
Disable nested input managers on edited screen when skin editor is open
2024-02-19 19:27:26 +08:00
Bartłomiej Dach
f5666185ab
Merge pull request #27239 from peppy/fix-cached-beatmap
...
Fix `WorkingBeatmapCache` caching beatmap in wrong state leading to crash
2024-02-19 12:06:45 +01:00
Bartłomiej Dach
1ca566c6b0
Disable nested input managers on edited screen when skin editor is open
2024-02-19 10:19:25 +01:00
Dean Herbert
7f82f10317
Fix beatmap potentially loading in a bad state
...
Over-caching could mean that a beatmap could load and cause a late
crash. Let's catch it early to avoid such a crash occurring.
2024-02-19 17:18:07 +08:00
Dean Herbert
998d820666
Ensure audio filters can't be attached before load (or post-disposal)
...
Will probably fix https://github.com/ppy/osu/issues/27225 ?
2024-02-19 00:25:01 +08:00
Dean Herbert
6b6a6aea54
Apply NRT to LogoTrackingContainer
2024-02-18 23:35:26 +08:00
Dean Herbert
882f11bf79
Fix logo tracking container being off by one frame
...
This was especially visible at the main menu when running in single thread mode.
2024-02-18 23:19:57 +08:00
Dean Herbert
415a65bf59
Add failing tests for beatmap inconsistencies
2024-02-18 19:32:21 +08:00
Dean Herbert
4d4d69521f
Merge pull request #27114 from EVAST9919/judgements-rework
...
Cache created judgement in `HitObject`
2024-02-18 18:07:58 +08:00
Dean Herbert
9655e8c48a
Adjust xmldoc slightly
2024-02-18 17:54:29 +08:00
Dean Herbert
715236765a
Merge pull request #27206 from EVAST9919/selection-enumerators
...
Reduce allocations during beatmap selection
2024-02-18 10:02:35 +08:00
Dean Herbert
6960f87509
Merge pull request #26895 from vmfunc/ordinal-sorting
...
Consider case sensitivity when sorting beatmaps in song select
2024-02-18 04:05:22 +08:00
Dean Herbert
71afb8881a
Merge pull request #27199 from EVAST9919/link-compiler-alloc
...
Fix `DrawableLinkCompiler` allocations
2024-02-18 04:04:34 +08:00
Dean Herbert
520576a0fd
Merge pull request #27193 from bdach/fix-not-working-metadata-hub-cleanup
...
Fix a few issues in metadata hub's disconnection requested flow
2024-02-18 03:46:02 +08:00
Andrei Zavatski
dd82de473a
Revert BeatmapCarousel changes
2024-02-17 22:42:47 +03:00
Dean Herbert
62a7e315bf
Update framework
2024-02-18 03:11:29 +08:00
Andrei Zavatski
22f5a66c02
Reduce allocations during beatmap selection
2024-02-17 15:46:38 +03:00
Joseph Madamba
7a74eaa2de
Fix star counter decrease animation being delayed when current is over displayed star count
2024-02-16 22:47:38 -08:00
Joseph Madamba
6e8d8b977e
Move ternary inside Math.Max()
2024-02-16 22:47:38 -08:00
Andrei Zavatski
b0f334c39e
Fix DrawableLinkCompiler allocations
2024-02-17 00:45:30 +03:00
Andrei Zavatski
060b01eee8
Make CreateJudgement public again and add remarks
2024-02-16 20:24:02 +03:00
Andrei Zavatski
dd32c0a226
Merge branch 'master' into judgements-rework
2024-02-16 20:08:57 +03:00
Bartłomiej Dach
1049be7d72
Add extended xmldoc to DisconnectRequested()
...
Just expounds on what the previous commit message said.
2024-02-16 13:09:36 +01:00
Bartłomiej Dach
b4aa247032
Do not attempt to stop watching user presence when requested to disconnect
...
First of all, this sort of cleanup isn't really the client's
responsibility, and secondly, at the point the client received this
request to disconnect, *none of its requests will be honored anymore*
(currently the only scenario of this if another client has connected
- the server-side concurrency filter will reject this request).
When disconnection is requested, the only valid thing to do with respect
to talking to the server is to stop doing it.
This will be moved server-side in a follow-up change, although I'm not
even strictly sure that's required - I'd like to think signalr would
know to clean up a disconnecting client from all groups they were in.
2024-02-16 13:08:39 +01:00
Bartłomiej Dach
9fa60b169e
Actually disconnect from metadata hub when requested to
...
Nothing in this override, on in the base implementation, would actually
attempt to disconnect.
2024-02-16 12:58:50 +01:00
Bartłomiej Dach
171270d99c
Fix missing RPC method mapping
...
Thanks, signalr.
2024-02-16 12:58:13 +01:00
Salman Ahmed
583e71634f
Always bring master/music volume to 50%
2024-02-16 11:20:07 +03:00
Salman Ahmed
952c5b0d18
Use Precision.AlmostBigger
2024-02-16 11:13:41 +03:00
Salman Ahmed
9f53185fa9
Revert changes to muted notification action
2024-02-16 10:47:56 +03:00
Salman Ahmed
df40f55c07
Merge branch 'master' into mute_detection
2024-02-16 01:35:02 +03:00
Salman Ahmed
7530b1f362
Adjust comment again
2024-02-16 01:31:52 +03:00
Salman Ahmed
5431781f80
Bring back target volume to 50%
2024-02-16 01:23:26 +03:00
Salman Ahmed
d81b148b09
Remove mention of decibel units in comment
...
Decibels are irrelevant in the volume bindables, as mentioned in PR already.
2024-02-16 01:23:18 +03:00
Salman Ahmed
a9eac5924d
Remove seemingly unnecessary float casts
2024-02-16 01:18:13 +03:00
Dean Herbert
c1d9f53ab4
Merge pull request #27068 from smoogipoo/mania-hd-fi-progression
...
Add progressive coverage for mania's Hidden and FadeIn mods
2024-02-16 01:00:53 +08:00
Dean Herbert
e91d38872d
Update framework
2024-02-15 18:28:59 +08:00
Bartłomiej Dach
898d5ce88b
Show selected submission failure messages even in solo
...
Previously, if a `SubmittingPlayer` instance deemed it okay to proceed
with gameplay despite submission failure, it would silently log all
errors and proceed, but the score would still not be submitted. This
feels a bit anti-user in the cases wherein something is genuinely wrong
with either the client or web, so things like token verification
failures or API failures are now shown as notifications to give the user
an indication that something went wrong at all.
Selected cases (non-user-playable mod, logged out, beatmap is not
online) are still logged silently because those are either known and
expected, or someone is messing with things.
2024-02-15 10:55:08 +01:00
Bartłomiej Dach
95e745c6fb
Use better messaging for selected submission failure reasons
...
These have been cropping up rather often lately, mostly courtesy of
linux users, but not only:
https://github.com/ppy/osu/issues/26840
https://github.com/ppy/osu/issues/27008
https://github.com/ppy/osu/discussions/26962
so this is a proposal for slightly improved messaging for such cases to
hopefully get users on the right track.
The original error is still logged to network log, so there's no
information loss.
2024-02-15 10:51:27 +01:00
Bartłomiej Dach
e10c4c7079
Merge pull request #27176 from peppy/document-classic-mod-no-rank
...
Add inline documentation as to why classic mod is not ranked
2024-02-15 09:22:05 +01:00
Dean Herbert
409dfd33e7
Merge pull request #27178 from Joehuu/truncate-osu-dropdown-items
...
Truncate long dropdown menu item text and show tooltip
2024-02-15 16:11:36 +08:00
Joseph Madamba
3d08bc5605
Truncate long dropdown menu item text and show tooltip
2024-02-14 23:01:51 -08:00
