Bartłomiej Dach
0ac08158e3
Fix transforms from swell progress being cleared on completion by not using transforms
2025-02-12 13:25:42 +01:00
Bartłomiej Dach
96db6964df
Adjust things further
2025-02-12 13:20:04 +01:00
Bartłomiej Dach
231988bc9d
Adjust things to be closer to stable (but not close enough yet)
2025-02-11 15:29:53 +01:00
Bartłomiej Dach
be035538c2
Fix remaining hit counter scaling in the incorrect direction
2025-02-11 14:01:32 +01:00
Nathan Du
ccc446a8ca
code cleanup
2025-02-04 17:48:44 +08:00
Nathan Du
e794389fe8
further adjust swell behavior
...
The outstanding visual issues of the clear animation is fixed. The
HandleUserInput state management is removed as it no longer seems
necessary.
2025-02-01 13:34:52 +08:00
Nathan Du
a62a84a30f
fix code style
2025-01-31 20:48:29 +08:00
Nathan Du
ac17b4065f
change legacy spinner animations to match stable
...
Also removed a few fallbacks pointed out in code review that I don't
understand.
2025-01-31 20:16:28 +08:00
Nathan Du
ad2b469b14
remove spinner-osu.png workaround
...
https://github.com/ppy/osu/issues/22084
2025-01-31 18:52:19 +08:00
Nathan Du
2a5540b392
remove ISkinnableSwell
...
This commit removes ISkinnableSwell for taiko swell animations. In place
of it, an event named UpdateHitProgress is added to DrawableSwell, and
the skin swells are converted to listen to said event and
ApplyCustomUpdateState, like how spinner skinning is implemented for
std.
2025-01-31 18:10:50 +08:00
Nathan Du
4fd8a4dc5a
Merge taiko swell components
...
Per <https://github.com/ppy/osu/pull/21601/files#r1064167756 >, taking a
variation of the "Make all swell main pieces implement
ISkinnableSwellPart" path. Should clean the interface up enough for
further refactors.
2025-01-31 16:55:39 +08:00
Joppe27
e2196e8b9b
Rename methods and skin component + add comments
2025-01-31 10:24:45 +08:00
Joppe27
4a164b7b14
Add legacy taiko swell
2025-01-31 10:24:45 +08:00
Bartłomiej Dach
5668c62446
Fix drum roll editor blueprint size & input handling
2024-11-05 13:12:01 +01:00
Dean Herbert
36b4013fa6
Rename GameplaySkinComponentLookup -> SkinComponentLookup
2024-08-22 18:46:03 +09:00
Dean Herbert
0d6adf160b
Share scale factor with hit target
2024-05-27 14:20:28 +09:00
Joppe27
76f13b21da
Correct scale of taiko-glow element
2024-05-25 23:28:51 +02:00
Dean Herbert
b84457fd15
Merge branch 'master' into constant-taiko-input-drum-width
2024-01-26 17:18:26 +09:00
Dean Herbert
e78f0bc89b
Merge pull request #26631 from frenzibyte/refactor-taiko-playfield-layout
...
Rewrite osu!taiko playfield adjustment container to keep playfield height constant
2024-01-26 17:17:49 +09:00
Dean Herbert
5aa4235c3d
Simplify TaikoLegacyHitTarget container hierarchy
2024-01-25 21:02:22 +09:00
Salman Ahmed
d4fef99e1f
Define constant input drum width for osu!taiko
2024-01-20 01:46:15 +03:00
Salman Ahmed
0c03326eaf
Update remaining usages of playfield height
2024-01-20 01:45:39 +03:00
Salman Ahmed
ce4fd6aca5
Rename DEFAULT_HEIGHT to BASE_HEIGHT
2024-01-19 23:58:58 +03:00
mouzedrift
cbfc6091af
apply proposed changes
2024-01-18 08:22:26 +01:00
mouzedrift
a870f99877
ease out input drum animation and add delay before fading out
2024-01-18 07:19:29 +01:00
Salman Ahmed
bcbb77d383
Fix incorrect assumption in taiko circle piece logic
2023-10-24 02:29:46 +03:00
Salman Ahmed
ab3b51e4a0
Refactor osu!taiko circle piece logic to read better
2023-10-21 00:22:34 +03:00
Bartłomiej Dach
0ae4a0f11f
Adjust gameplay element maximum size limits for backwards compatibility
...
The new limits were chosen by sampling across over 4000 skins. The
methodology for doing so is described in the following gist:
https://gist.github.com/bdach/6228ba41d128b23d1f89142f404108a3
2023-10-05 20:37:10 +02:00
Salman Ahmed
ad86bf2d56
Revert redundant size limitations
...
Already handled by the sprites themselves being resized.
2023-09-21 19:03:59 +03:00
Salman Ahmed
291a91be66
Change extension from retrieval to post-processing instead
2023-09-19 03:40:30 +03:00
Dean Herbert
9d17539778
Add size limitations for taiko drum rolls
2023-09-05 18:01:19 +09:00
Salman Ahmed
d286816ba8
Add limit to taiko hit elements
2023-09-03 02:22:58 +03:00
Bartłomiej Dach
055e4a78f0
Merge branch 'master' into taiko-hitsounding-final-attempt
2023-07-08 18:10:04 +02:00
Dean Herbert
f54eb8d7fa
Move DrumSamplePlayer to be a skinnable component
2023-07-05 18:44:27 +09:00
Dean Herbert
3b9d7af9ee
Fix taiko hit overlay animation timing not accounting for timing section start time
2023-07-05 17:25:31 +09:00
Dean Herbert
2fd535ea20
Apply same immediate transform logic to TaikoLegacyPlayfieldBackgroundRight to fix it sticking during rewind
2022-12-02 17:33:18 +09:00
Dean Herbert
ebc75d40d2
Switch to using immediate transforms to make rewind handle better
2022-12-02 17:32:57 +09:00
Dean Herbert
47855de6ab
Fix multiple issues with transform handling
2022-12-02 16:55:38 +09:00
Joppe27
a7f4325d3c
Revert hacky fade value and fix test
2022-12-01 12:16:58 +01:00
Joppe27
f9a9ab1d9b
Use BeatSyncedContainer and adjust values to be in line with stable
2022-11-30 19:50:47 +01:00
Joppe27
f3fa39f254
Add legacy taiko kiai glow element
2022-11-30 00:44:20 +01:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Bartłomiej Dach
6e9d163c72
Specify canBeNull: true in [Resolved] for now
2022-11-22 20:56:07 +01:00
Bartłomiej Dach
ce7af0df63
Always use current timing point for circle piece animation
...
Using `LifetimeStart` seemed arbitrary and wrong not only in a
compatibility-with-stable sense, but also in a general sanity sense (why
would each object potentially be using a different timing point to
animate?)
2022-11-22 20:39:22 +01:00
Bartłomiej Dach
38f2a27f53
Split animation logic to its own method
...
Also add a guard, to bypass all of it if the foreground layer is not in
fact animatable.
2022-11-22 20:39:05 +01:00
Joppe27
5343f6922c
Add legacy circle piece animations based on combo
2022-11-22 17:22:00 +01:00
Dean Herbert
1aa0e40f2f
Add "Component" prefix to lookup naming
2022-11-09 17:46:43 +09:00
Dean Herbert
c908969d9b
Rename ISkinComponent to ISkinLookup
2022-11-09 17:46:43 +09:00
Dan Balasescu
5dfaf27722
A bit more cleanup
2022-11-02 17:23:45 +09:00
Dean Herbert
bc3382f373
Apply NRT to many taiko classes
2022-11-02 17:15:25 +09:00
