45 Commits

• Always use current culture in ToStandardFormattedString()
  Bartłomiej Dach · 2025-10-24 08:26:01 +02:00
  ae7ba034a7
• Allow NumberFormattingExtensions.ToStandardFormattedString() to accept culture

  I had previously made it invariant in
  https://github.com/ppy/osu/pull/32837, and in another instance of past
  me being an asshole, I can't actually find the reasoning for this at
  this time.
  
  That said, you'd be excused for thinking "why does this matter"? Well,
  this will fix https://github.com/ppy/osu/issues/35381, because that
  failure only occurs when the user's culture is set to one that doesn't
  use a decimal point (.) but rather a decimal comma (,). This messes with
  framework, which uses the *current* culture to check for decimal
  separator rather than invariant:
  
  https://github.com/ppy/osu-framework/blob/d3226a7842487de43a0d989e1bb59a9ebbc479af/osu.Framework/Graphics/UserInterface/TextBox.cs#L106-L111
  
  An alternative would be to change framework instead to always accept the
  invariant decimal separator.
  
  God I hate this culture crap.

  Bartłomiej Dach · 2025-10-22 10:31:12 +02:00
  a29a5ab7e6
• Fix Difficulty Adjust extended mod icon information not showing with extended limits active

  - Closes https://github.com/ppy/osu/issues/33522.
  - Alternative to / closes https://github.com/ppy/osu/pull/33561.

  Bartłomiej Dach · 2025-06-30 12:20:05 +02:00
  28caa03d21
• Don't bother with localised implementation of AdjustedSettingsCount

  I was avoiding using reflection to save on overheads, but it's probably
  not worth it.

  Dean Herbert · 2025-04-30 12:58:40 +09:00
  babccca2bb
• Show singular difficulty adjust modifications inline in mod icons
  Dean Herbert · 2025-04-28 16:58:16 +09:00
  c16514274d
• Change SettingDescription to differentiate between settings and values
  Salman Alshamrani · 2025-03-23 13:43:26 -04:00
  6e635f124a
• Allow AR and CS values below 1.0 for Catch the Beat Difficulty Adjustment mod
  rrex971 · 2023-03-27 20:39:13 +05:30
  9426633a05
• Remove the nullable annotation in the catch ruleset.
  andy840119 · 2022-07-20 20:24:51 +08:00
  53e61c5041
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add missing osu!catch difficulty adjust attributes
  Dean Herbert · 2021-07-11 10:14:42 +09:00
  79d546afa2
• Standardise variables
  Dean Herbert · 2021-07-09 13:24:26 +09:00
  90326f8864
• Use existing reflection methods to avoid manual binding of ExtendedLimits
  Dean Herbert · 2021-07-08 17:49:00 +09:00
  88b00123f6
• Avoid the need for per-settings control classes
  Dean Herbert · 2021-07-08 17:49:00 +09:00
  bd7c334588
• Add back extended limits support
  Dean Herbert · 2021-07-08 17:49:00 +09:00
  a6e94dd491
• Initial storage changes
  Dean Herbert · 2021-07-08 14:28:13 +09:00
  0e4f4a6fde
• Remove unnecessary string interpolation
  smoogipoo · 2021-06-23 17:40:11 +09:00
  6215f2d42b
• Add to tooltip
  smoogipoo · 2021-06-23 17:34:30 +09:00
  7767e2e77f
• Allow catch difficulty adjust to enable hard rock offsets
  ekrctb · 2021-06-23 14:52:41 +09:00
  ad60b9d5a0
• Merge branch 'master' into difficulty-adjustment-extension
  smoogipoo · 2021-02-10 20:42:08 +09:00
  be9b07a4cf
• Transfer flags indicating if settings were changed
  Bartłomiej Dach · 2021-01-06 22:46:46 +01:00
  303cc62ee7
• Add extended limits to difficulty adjustment mod
  smoogipoo · 2020-12-10 00:37:19 +09:00
  ac91f0e270
• use N1 format instead of 0.#
  Liam DeVoe · 2020-03-22 22:54:21 -04:00
  1da590c63f
• remove unnecessary using statements
  Liam DeVoe · 2020-03-22 22:50:52 -04:00
  afe7397d89
• enforce precision for ModDifficultyAdjust and derived classes
  Liam DeVoe · 2020-03-22 21:22:46 -04:00
  67667b3d22
• use string.Empty, use base SettingDescription for [Osu/Catch]ModDifficultyAdjust
  Liam DeVoe · 2020-03-22 18:50:09 -04:00
  63e9b2a299
• simplify array initializationstatement
  Liam DeVoe · 2020-03-20 16:58:02 -04:00
  a440d15620
• remove unnecessary ToString calls
  Liam DeVoe · 2020-03-20 16:53:40 -04:00
  e84b40f8ed
• move overridability to SettingDescription method
  Liam DeVoe · 2020-03-20 16:34:36 -04:00
  cda1efef0b
• Revert "use SettingSource to define IconTooltip format"

  This reverts commit 5a6d8f1932.

  Liam DeVoe · 2020-03-20 16:05:12 -04:00
  7bdbdd25f8
• use SettingSource to define IconTooltip format
  Liam DeVoe · 2020-03-20 12:47:17 -04:00
  5a6d8f1932
• don't use ToString, proper indent level
  Liam DeVoe · 2020-03-19 00:06:55 -04:00
  7a0a633ef9
• show mod settings in ModIcon tooltip
  Liam DeVoe · 2020-03-18 23:43:26 -04:00
  18bf7c913b
• Add index constants for cross-class safety
  Dean Herbert · 2020-02-13 14:07:37 +09:00
  53b62816f8
• Simplify ordering by using only numbers, add xmldoc
  voidedWarranties · 2020-02-10 16:21:49 -08:00
  ca237fd987
• Switch numerical consts to an enum
  voidedWarranties · 2020-02-09 21:37:40 -08:00
  ea521b466f
• Naming consistency with osu!web
  voidedWarranties · 2020-02-09 20:36:54 -08:00
  137181017b
• Allow specifying order to SettingSource
  voidedWarranties · 2020-02-09 20:11:37 -08:00
  88a56d00bf
• Lock user adjusted difficulty settings when changing beatmap
  Dean Herbert · 2019-12-27 19:05:17 +09:00
  2c8879f0fb
• Fix code inspections
  Dean Herbert · 2019-12-25 15:20:10 +09:00
  911dc2d98d
• Rename method to be more appropriate

  Also adds xmldoc.

  Dean Herbert · 2019-12-25 15:20:04 +09:00
  52ba0cd816
• make HP and OD generic and instantiate CS and AR to modes that need it
  unknown · 2019-12-22 16:45:32 +08:00
  fe73b9f8d3
• make ModDifficultyAdjust abstract
  unknown · 2019-12-20 18:30:23 +08:00
  08b477ed52
• make ModDifficultyAdjust generic
  unknown · 2019-12-12 21:14:26 +08:00
  002a125b4a
• fix appveyor issues
  unknown · 2019-12-11 20:12:29 +08:00
  b0cf44c3be
• add difficulty adjustment mods
  unknown · 2019-12-11 19:43:16 +08:00
  b795532aa5