Bartłomiej Dach
9b2740f8a4
Fix score submission test failures due to checking audio playback validity (again)
...
As seen in https://github.com/ppy/osu/actions/runs/7607899979/job/20716013982?pr=26662#step:5:75
In https://github.com/ppy/osu/pull/26484 , I went "well if I'm moving the
enabling of validation of playback rate to `SubmittingPlayer` context,
then surely I can remove the local override in the test scene, right?"
Reader: Apparently I did not notice that `FakeImportingPlayer :
TestPlayer : SoloPlayer : SubmittingPlayer`. So no, I could not remove
the local override in the test scene.
You could probably attempt to conjure up some excuse about deep
inheritance hierarchies here but nah. Really just a failure to read
on my behalf as usual.
2024-01-22 11:15:42 +01:00
Bartłomiej Dach
b7f0102461
Merge pull request #26662 from peppy/fix-player-crash
...
Fix potential null reference in player screen transition handling
2024-01-22 11:07:16 +01:00
Dean Herbert
47e9846315
Adjust slider tick / end miss animations to be less busy
2024-01-22 18:48:48 +09:00
Bartłomiej Dach
77ef12ebb0
Merge branch 'master' into frame-stable-catchup-zoom
2024-01-22 10:37:06 +01:00
Bartłomiej Dach
daa9279a23
Merge pull request #26607 from peppy/replay-seek-single-frame
...
Add ability to step forward/backwards single frames when watching replays
2024-01-22 10:36:13 +01:00
Dean Herbert
dd24b15c90
Merge pull request #26599 from frenzibyte/fix-storyboard-sprites-3
...
Fix storyboard animations stripping path directory on skin lookup
2024-01-22 18:27:08 +09:00
Dean Herbert
319af2d0c6
Merge branch 'master' into fix-storyboard-sprites-3
2024-01-22 18:03:24 +09:00
Dean Herbert
cd551b1abd
Fix star fountains sometimes resetting visually
...
Addresses https://github.com/ppy/osu/discussions/26622 .
2024-01-22 18:01:21 +09:00
Dean Herbert
993e733fce
Merge pull request #26598 from frenzibyte/fix-storyboard-sprites-2
...
Remove handling for non-legacy texture lookup paths in `LegacySkin`
2024-01-22 17:50:55 +09:00
Bartłomiej Dach
1ac682e2c9
Merge branch 'master' into replay-seek-single-frame
2024-01-22 09:36:15 +01:00
Bartłomiej Dach
af5e6700af
Merge pull request #26606 from peppy/frame-stable-update-while-paused
...
Allow seeking while paused
2024-01-22 09:35:52 +01:00
Dean Herbert
29f04d0b42
Merge pull request #26659 from frenzibyte/editor-fix-slider-repeat
...
Fix slider sometimes not updating anchor position of nested objects
2024-01-22 17:21:25 +09:00
Dean Herbert
3dd18c777a
Remove a couple more overrides
2024-01-22 17:00:35 +09:00
Dean Herbert
f6fa965252
Merge pull request #26661 from frenzibyte/fix-mouse-blueprint
...
Fix blueprint container not handling right clicks correctly while moving a blueprint
2024-01-22 16:53:54 +09:00
Bartłomiej Dach
cd9cb7d6c8
Merge branch 'master' into frame-stable-update-while-paused
2024-01-22 08:52:15 +01:00
Bartłomiej Dach
493d495992
Merge pull request #26605 from peppy/simplify-gameplay-pause
...
Simplify gameplay pause sequence
2024-01-22 08:49:08 +01:00
Dean Herbert
62965549e7
Merge pull request #26660 from EVAST9919/carousel-alloc
...
Reduce allocation overhead in `BeatmapCarousel`
2024-01-22 16:47:28 +09:00
Dean Herbert
3e5fe66e58
Fix potential null reference in player screen transition handling
...
See https://github.com/ppy/osu/actions/runs/7607677219/job/20715418536?pr=26660 .
2024-01-22 16:37:56 +09:00
Bartłomiej Dach
2262c34178
Merge pull request #26617 from peppy/update-framework
...
Update framework
2024-01-22 08:17:43 +01:00
Dean Herbert
1f0ad5cff2
Apply same fix in more places
2024-01-22 15:56:16 +09:00
Dean Herbert
74f05a5c4b
Use container itself rather than ScrollContent
2024-01-22 15:54:24 +09:00
Salman Ahmed
2bd9cd5d34
Fix blueprint container not handling right clicks correctly while moveing an element
2024-01-22 04:39:08 +03:00
Andrei Zavatski
cec4f670d1
Reduce allocation overhead in BeatmapCarousel
2024-01-22 03:12:23 +03:00
Salman Ahmed
57b2d018a9
Fix slider sometimes not updating relative anchor position
2024-01-22 02:07:32 +03:00
Salman Ahmed
bab14dce31
Add failing test case
2024-01-22 02:07:09 +03:00
Dean Herbert
3b7a47aded
Merge branch 'master' into update-framework
2024-01-21 13:49:44 +09:00
Dean Herbert
02369139b3
Remove FillFlow overhead of argon counters
2024-01-21 13:22:58 +09:00
Dean Herbert
b588715d21
Merge pull request #26647 from EVAST9919/triangles-masking
...
Enable masking for `Triangles` backgrounds where possible
2024-01-21 12:20:40 +09:00
Dean Herbert
18d16018d3
Fix failing tests due to pooling safety changes
2024-01-21 12:17:16 +09:00
Andrei Zavatski
1393f52b2b
Rename Masking to ClampToDrawable
2024-01-21 05:20:42 +03:00
Dean Herbert
a69fd8198d
Update framework and other nuget packages
...
- Moq held back because dicks
- NUnit held back because large API changes (trivial but effort)
- SignalR held back due to api deprecations
2024-01-21 11:00:53 +09:00
Andrei Zavatski
e003ecb593
Change default masking value to true
2024-01-21 04:57:48 +03:00
Dean Herbert
2dedead1d1
Allow debug instances to coexist alongside release instances
2024-01-21 10:56:55 +09:00
Dean Herbert
1999e772f6
Fix FollowPointConnection pool filling up when follow points are hidden
...
Closes https://github.com/ppy/osu/issues/26642 .
I think this applied to all pooling cases here.
2024-01-21 10:31:27 +09:00
Andrei Zavatski
6ba3546be5
Enable masking in RoundedButton
2024-01-21 02:28:14 +03:00
Andrei Zavatski
60f7b4ea2f
Enable masking in DrawableRank
2024-01-21 02:25:29 +03:00
Andrei Zavatski
421ae73715
Enable masking in DrawableCarouselBeatmap
2024-01-21 02:21:09 +03:00
Andrei Zavatski
087d0f03a4
Enable masking in toolbar
2024-01-21 02:15:48 +03:00
Andrei Zavatski
a3703d657a
Enable masking in popup dialog
2024-01-21 02:12:49 +03:00
Andrei Zavatski
3ad3b052df
Enable masking is osu logo
2024-01-21 02:10:36 +03:00
Dean Herbert
1e44ba6d23
Merge pull request #26636 from EVAST9919/triangles-batch
...
Remove local vertex batching from triangles backgrounds
2024-01-20 23:35:27 +09:00
Andrei Zavatski
45effdb6df
Remove local vertex batching from triangles backgrounds
2024-01-20 08:41:34 +03:00
Dean Herbert
e669e28dc9
Merge pull request #26626 from Joehuu/fix-changelog-stream-user-count
...
Fix changelog stream user count only accounting for latest build
2024-01-19 14:11:59 +09:00
Joseph Madamba
3eeefd5b7e
Fix changelog stream user count only accounting for latest build
2024-01-18 16:15:52 -08:00
Bartłomiej Dach
e24074f239
Merge pull request #26587 from peppy/fix-tournament-panel-load
...
Fix tournament beatmap backgrounds occasionally not loading
2024-01-18 14:54:37 +01:00
Bartłomiej Dach
3853f63b74
Merge pull request #26567 from peppy/cusor-scale-rate
...
Fix cursor scale animation not matching stable on classic skins
2024-01-18 13:59:49 +01:00
Bartłomiej Dach
5123186c23
Merge pull request #26618 from frenzibyte/fix-revert-to-default-epic-fail
...
Fix revert-to-default button appearing on disabled settings regardless of value
2024-01-18 13:35:01 +01:00
Dean Herbert
0383bdf6a1
Add bindings for stepping backward/forward
2024-01-18 20:38:25 +09:00
Dean Herbert
c50534c819
Move seek/step logic into ReplayPlayer
2024-01-18 20:38:15 +09:00
Salman Ahmed
b97c3ac9ee
Fix revert-to-default button appearing on disabled settings regardless of value
2024-01-18 14:24:49 +03:00
