1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-22 12:07:23 +08:00
osu-lazer/osu.Game
Bartłomiej Dach 9ce2c1f49c
Exclude video events from being accounted for when calculating storyboard time bounds
Closes https://github.com/ppy/osu/issues/25263.

In some circumstances, stable allows skipping twice if a particularly
long storyboarded intro is being displayed:

    https://github.com/peppy/osu-stable-reference/blob/master/osu!/GameModes/Play/Player.cs#L1728-L1736

`AllowDoubleSkip` is calculated thus:

    3ea48705eb/osu!/GameModes/Play/Player.cs#L1761-L1770

and `leadInTime` is calculated thus:

    3ea48705eb/osu!/GameModes/Play/Player.cs#L1342-L1351

The key to watch out for here is `{first,last}EventTime`. `EventManager`
will calculate it on-the-fly as it adds storyboard elements:

    3ea48705eb/osu!/GameplayElements/Events/EventManager.cs#L253-L256

However, this pathway is only used for sprite, animation, sample,
and break events. Video and background events use the following pathway:

    https://github.com/peppy/osu-stable-reference/blob/master/osu!/GameplayElements/Events/EventManager.cs#L368

Note that this particular overload does not mutate either bound.
Which means that for the purposes of determining where a storyboard
starts and ends temporally, a video event's start time is essentially
ignored.

To reflect that, add a clause that excludes video events from
calculations of `{Earliest,Latest}EventTime`.
2023-10-27 22:24:17 +02:00
..
Audio Add basic implementation of argon osu!taiko hitsounds (volume / flourish / strong) 2023-07-05 18:44:27 +09:00
Beatmaps Merge pull request #25167 from peppy/fix-circle-radius 2023-10-20 20:59:53 +02:00
Collections Remove drag handles from manage collections dialog for now 2023-10-16 15:51:18 +09:00
Configuration Persist the state of "show speed changes" between editor sessions 2023-10-17 16:01:02 +09:00
Database Merge pull request #24794 from bdach/score-encoding-cleanup 2023-10-28 02:29:56 +09:00
Extensions Merge branch 'master' into score-encoding-cleanup 2023-10-26 09:04:05 +02:00
Graphics Do not revert to default value when double-clicking disabled slider 2023-10-26 12:11:26 +02:00
Input Add ability to quick retry using Ctrl-R 2023-10-26 21:26:26 +09:00
IO Fix various other inspections 2023-10-17 17:48:51 +09:00
IPC Handle osu:// scheme links via IPC in desktop game 2022-06-20 21:26:22 +02:00
Localisation Merge pull request #25105 from bdach/multiple-keys-one-binding 2023-10-13 20:01:33 +09:00
Models Remove usages of [ExcludeFromDynamicCompile] 2023-05-08 18:12:56 +09:00
Online Fix SoloScoreInfo not copying over legacy score ID when converting to ScoreInfo 2023-10-26 15:09:34 +02:00
Overlays Remove nullable disable 2023-10-23 13:29:46 +03:00
Performance Automated pass 2023-06-24 01:00:03 +09:00
Properties Automated pass 2023-06-24 01:00:03 +09:00
Replays Show smoke in replays 2022-09-18 17:55:06 -07:00
Rulesets Fix catch distance snap provider not hiding slider properly 2023-10-26 15:46:32 +02:00
Scoring Delete ScoreInfo.HasReplay as no longer needed 2023-10-27 12:39:54 +02:00
Screens Merge pull request #24794 from bdach/score-encoding-cleanup 2023-10-28 02:29:56 +09:00
Skinning Merge pull request #24794 from bdach/score-encoding-cleanup 2023-10-28 02:29:56 +09:00
Storyboards Exclude video events from being accounted for when calculating storyboard time bounds 2023-10-27 22:24:17 +02:00
Tests Merge pull request #25157 from peppy/spinner-anti-cheese-final 2023-10-24 08:13:32 +02:00
Updater use fa_download for updates instead of fa_upload 2023-07-16 15:21:15 -04:00
Users Add note about CountryCode being at parity with osu_countries 2023-10-25 13:03:03 +09:00
Utils Enable sentry "global mode" as per recommendation 2023-08-24 03:23:18 +09:00
.editorconfig Add localisation length hinting 2022-04-28 19:26:28 +09:00
BackgroundDataStoreProcessor.cs Update score conversion to consider legacy multiplier 2023-10-02 16:56:15 +09:00
FodyWeavers.xml More realm analytic disables 2023-07-20 17:51:33 +09:00
osu!.res
osu.Game.csproj Fix iOS AOT compilation failure due to SharpCompress library upgrade 2023-10-26 17:42:28 +09:00
OsuGame.cs Add LegacyOnlineID handling to places that definitely need it 2023-10-16 11:20:02 +02:00
OsuGameBase_Importing.cs Automated pass 2023-06-24 01:00:03 +09:00
OsuGameBase.cs Disable decoupling for OsuGameBase's beatmap implementation 2023-09-22 12:49:25 +09:00
PerformFromMenuRunner.cs Partial everything 2022-11-27 00:00:27 +09:00