1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 08:02:54 +08:00
osu-lazer/osu.Game/Screens/Play
Bartłomiej Dach 898d5ce88b
Show selected submission failure messages even in solo
Previously, if a `SubmittingPlayer` instance deemed it okay to proceed
with gameplay despite submission failure, it would silently log all
errors and proceed, but the score would still not be submitted. This
feels a bit anti-user in the cases wherein something is genuinely wrong
with either the client or web, so things like token verification
failures or API failures are now shown as notifications to give the user
an indication that something went wrong at all.

Selected cases (non-user-playable mod, logged out, beatmap is not
online) are still logged silently because those are either known and
expected, or someone is messing with things.
2024-02-15 10:55:08 +01:00
..
Break Fix valueText being replaced even if current is not binding to anything 2023-08-02 09:40:22 -07:00
HUD Update R# + fix inspections 2024-02-02 21:00:28 +09:00
PlayerSettings Merge pull request #26591 from peppy/offset-awareness 2024-01-22 14:59:31 +01:00
ArgonKeyCounter.cs Use left aligned text for non-rotate key counter 2023-11-06 16:32:12 +09:00
ArgonKeyCounterDisplay.cs Refactor KeyCounterDisplay to use autosize 2023-11-12 17:19:25 +09:00
BeatmapMetadataDisplay.cs Refactor IWorkingBeatmap.Background to GetBackground() 2023-06-08 16:19:32 +09:00
BreakOverlay.cs Make ScoreProcessor.Rank read-only 2024-01-04 17:13:24 +09:00
BreakTracker.cs Partial everything 2022-11-27 00:00:27 +09:00
ComboEffects.cs Replace various local implementations of rewinding checks with new property 2023-07-07 15:21:24 +09:00
DimmableStoryboard.cs Partial everything 2022-11-27 00:00:27 +09:00
EpilepsyWarning.cs Partial everything 2022-11-27 00:00:27 +09:00
FailAnimationContainer.cs Use AliveEntries where we don't need startTime order 2024-02-03 19:54:08 +03:00
FailOverlay.cs Don't show buttons on fail overlay when player interaction is disabled 2023-11-27 12:25:24 +09:00
GameplayClockContainer.cs Remove test guarantee of audio time not advancing 2024-01-18 20:06:53 +09:00
GameplayClockExtensions.cs Rename GameplayAdjustments -> AdjustmentsFromMods 2022-09-08 17:14:06 +09:00
GameplayMenuOverlay.cs Fix using "Back" binding at spectator fail screen not working 2023-12-28 20:14:18 +09:00
GameplayOffsetControl.cs Disable positional interaction for now 2023-12-24 03:00:51 +09:00
GameplayState.cs Add a gameplay configuration flag to disable fail animation 2024-01-04 17:13:24 +09:00
HotkeyExitOverlay.cs Automated pass 2023-06-24 01:00:03 +09:00
HotkeyRetryOverlay.cs Automated pass 2023-06-24 01:00:03 +09:00
HUDOverlay.cs Move cast to local function and make direct cast 2024-01-26 12:55:36 +09:00
IGameplayClock.cs Expose rewinding state of IGameplayClocks 2023-07-06 19:08:42 +09:00
ILocalUserPlayInfo.cs Automated pass 2023-06-24 01:00:03 +09:00
MasterGameplayClockContainer.cs Remove "pause rate adjust" flow 2024-01-18 14:21:02 +09:00
OffsetCorrectionClock.cs Remove "pause rate adjust" flow 2024-01-18 14:21:02 +09:00
PauseOverlay.cs Fix using "Back" binding at spectator fail screen not working 2023-12-28 20:14:18 +09:00
Player.cs Fix potential null reference in player screen transition handling 2024-01-22 16:37:56 +09:00
PlayerConfiguration.cs Add a gameplay configuration flag to disable fail animation 2024-01-04 17:13:24 +09:00
PlayerLoader.cs Migrate BeatmapOffsetControl to use session static directly 2023-12-27 19:19:27 +01:00
PlayerTouchInputDetector.cs Fix touch device not always activating when it should 2024-01-16 17:12:40 +01:00
ReplayPlayer.cs Revert keyboard seek speed change 2024-01-22 21:47:38 +09:00
ReplayPlayerLoader.cs Automated pass 2023-06-24 01:00:03 +09:00
ResumeOverlay.cs Partial everything 2022-11-27 00:00:27 +09:00
RoomSubmittingPlayer.cs Add additional gameplay metadata to room score request 2024-02-10 17:20:17 +09:00
SaveFailedScoreButton.cs Prevent ExportReplay being spammed on fail by being held down 2023-12-20 08:41:16 -08:00
ScreenSuspensionHandler.cs Partial everything 2022-11-27 00:00:27 +09:00
ScreenWithBeatmapBackground.cs Fix song select potentially updating background parameters when not the current screen 2023-02-16 18:45:22 +09:00
SkipOverlay.cs Fix various other inspections 2023-10-17 17:48:51 +09:00
SoloPlayer.cs Show selected submission failure messages even in solo 2024-02-15 10:55:08 +01:00
SoloSpectatorPlayer.cs Add visualisation of when a spectated player fails 2023-11-24 14:44:57 +09:00
SoloSpectatorScreen.cs Add extra test coverage and handle case where still at loading screen 2023-11-24 15:05:39 +09:00
SpectatorPlayer.cs move creation of PlaybackSettings to ReplayPlayer 2024-01-12 15:12:02 +08:00
SpectatorPlayerLoader.cs Automated pass 2023-06-24 01:00:03 +09:00
SpectatorResultsScreen.cs Mark ResultsScreen.Score as nullable 2024-01-29 16:43:26 +09:00
SquareGraph.cs Fix some new nullable inspections 2023-10-30 15:10:10 +09:00
SubmittingPlayer.cs Show selected submission failure messages even in solo 2024-02-15 10:55:08 +01:00