1
0
mirror of https://github.com/ppy/osu.git synced 2025-03-11 02:17:19 +08:00
Bartłomiej Dach 65a62d5440
Attempt to preserve sample control point bank when encoding beatmap
This was reported internally in
https://discord.com/channels/90072389919997952/1259818301517725707/1343470899357024286.
The issue described was that sample specifications on control points in
stable disappeared after the beatmap was updated from lazer.

The reason why the sample specifications were getting dropped is that
they got lost in the logic that attempts to translate per-hitobject
samples that lazer has back into stable "green line" type control
points. That process only attempted to preserve volume and custom sample
bank, but did not keep the standard bank - likely because it's kind of
superfluous information *for correct sample playback of the objects*, as
the samples get encoded again for each object individually. However
dropping this information makes for a subpar editing experience.

The choice of which sample to pick the bank from is sort of arbitrary
and I'm not sure if there's a correct one to pick. Intuitively picking
the normal sample's bank (if there is one) seems most correct.
2025-02-25 15:39:35 +01:00
..
2024-12-06 16:40:28 +09:00
2024-12-03 14:17:14 +01:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-07-11 20:18:54 +02:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2024-12-03 14:17:14 +01:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-08 19:11:48 +02:00