1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 23:42:55 +08:00
osu-lazer/osu.Game/Screens/Edit
Bartłomiej Dach 4dd225fdc8
Fix compose blueprint container not unsubscribing from event
Closes https://github.com/ppy/osu/issues/28938.

This is related to reloading the composer on timing point changes in
scrolling rulesets. The lack of unsubscription from this would cause
blueprints to be created for disposed composers via the
`hitObjectAdded()` flow.

The following line looks as if a sync load should be forced on a newly
created placement blueprint:

    da4d37c4ad/osu.Game/Screens/Edit/Compose/Components/ComposeBlueprintContainer.cs (L364)

however, it is not the case if the parent
(`placementBlueprintContainer`) is disposed, which it would be in this
case. Therefore, the blueprint stays `NotLoaded` rather than `Ready`,
therefore it never receives its DI dependencies, therefore it dies on
an `EditorBeatmap` nullref.
2024-07-19 08:32:36 +02:00
..
Components Fix summary timeline timing points having x position applied twice 2024-07-16 18:32:54 +09:00
Compose Fix compose blueprint container not unsubscribing from event 2024-07-19 08:32:36 +02:00
Design Enable nullability for design screen 2023-01-14 02:24:48 +03:00
GameplayTest Fix editor player crashing with UR counter present in skin 2024-07-08 11:14:32 +02:00
Setup Just give in to silly code quality inspection 2024-07-10 23:02:19 +09:00
Timing Fix incorrect editor screen padding 2024-07-16 18:20:33 +09:00
Verify Rewrite IssueTable to use virtualised list 2024-06-26 10:40:02 +02:00
BackgroundDimMenuItem.cs Use existing strings 2023-01-15 14:39:34 +03:00
BeatmapEditorChangeHandler.cs Change the way initial state saving works in EditorChangeHandler to be closer to first change 2023-02-07 16:22:51 +09:00
BindableBeatDivisor.cs Change name and description of force parameter in SetArbitraryDivisor 2024-01-25 05:12:54 -05:00
BottomBar.cs Merge pull request #28788 from bdach/timeline-redesign 2024-07-12 10:58:59 +02:00
ClipboardContent.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
CreateNewDifficultyDialog.cs Localise create/save dialog 2023-01-15 01:50:47 +03:00
DeleteDifficultyConfirmationDialog.cs make ResetConfirmDialog properly utilise its parent's logic 2023-03-05 20:57:26 +01:00
Editor.cs Fix incorrect editor screen padding 2024-07-16 18:20:33 +09:00
EditorBeatmap.cs Enforce IBeatmap.Breaks to be sorted chronologically 2024-07-08 16:06:38 +03:00
EditorBeatmapProcessor.cs Do not regenerate breaks unless meaningful change to object start/end times is detected 2024-07-10 11:42:25 +02:00
EditorBeatmapSkin.cs Enable NRT in EditorBeatmapSkin 2024-02-23 14:52:44 +01:00
EditorChangeHandler.cs Add RestoreState() to IEditorChangeHandler 2024-06-11 11:31:30 +02:00
EditorClipboard.cs Automated pass 2023-06-24 01:00:03 +09:00
EditorClock.cs Fix CurrentTimeAccurate being inaccurate if seeking smoothly in the same frame and a transform is already active 2024-07-08 13:30:11 +02:00
EditorLoader.cs Fix editor not updating ruleset when switching difficulty 2024-07-04 14:06:36 +03:00
EditorRoundedScreenSettings.cs Automated pass 2023-06-24 01:00:03 +09:00
EditorRoundedScreenSettingsSection.cs Partial everything 2022-11-27 00:00:27 +09:00
EditorScreen.cs Move workaround to subscreen 2024-05-24 10:35:33 +02:00
EditorScreenMode.cs Localise part of editor 2023-01-15 01:50:47 +03:00
EditorScreenWithTimeline.cs Match mania editor playfield time range with timeline zoom 2024-07-10 17:36:39 +02:00
EditorSkinProvidingContainer.cs Partial everything 2022-11-27 00:00:27 +09:00
EditorState.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
ExternalEditScreen.cs Add error logging on failure to begin/end external edit 2024-07-11 09:54:12 +02:00
HitAnimationsMenuItem.cs Automated pass 2023-06-24 01:00:03 +09:00
IEditorChangeHandler.cs Add RestoreState() to IEditorChangeHandler 2024-06-11 11:31:30 +02:00
LegacyEditorBeatmapPatcher.cs Add patcher support for breaks 2024-06-19 10:22:14 +02:00
ManualBreakPeriod.cs Make (Manual)BreakPeriod a class again 2024-06-19 14:53:09 +02:00
PromptForSaveDialog.cs Localise create/save dialog 2023-01-15 01:50:47 +03:00
ReloadEditorDialog.cs Attempt full editor reload on key count change 2024-06-11 11:31:49 +02:00
SaveRequiredPopupDialog.cs Simplify save dialogs 2024-07-11 12:15:17 +09:00
TableHeaderText.cs Rewrite ControlPointTable to use virtualised list 2024-06-26 10:40:02 +02:00
TransactionalCommitComponent.cs Change the way initial state saving works in EditorChangeHandler to be closer to first change 2023-02-07 16:22:51 +09:00
WaveformOpacityMenuItem.cs Move timeline toggle controls to "view" menu 2024-06-17 10:16:40 +02:00