Dean Herbert 645518f5bd Fix external edit filename sanitising unintentionally dropping folder separators (#34945) ...

* Add failing test coverage showing external edits not working with folders

* Fix external edit filename sanitising unintentionally dropping folder separators

Closes https://github.com/ppy/osu/issues/34929.

645518f5bd · 2025-09-07 21:47:20 +09:00

History

..

BackgroundDataStoreProcessor.cs

Fix copy-paste fail in log message

2025-08-25 13:43:03 +02:00

BeatmapExporter.cs

Change .olz to use UTF-8 encoding

2024-04-30 21:40:04 +08:00

BeatmapLookupCache.cs

Apply NRT in MemoryCachingComponent subclasses too

2023-06-09 13:47:35 +02:00

BeatmapStore.cs

Remove BeatmapCarousel testing backdoor

2024-12-11 16:28:51 +09:00

ExternalEditOperation.cs

More xmldoc across new methods and classes

2024-07-10 18:34:48 +09:00

ICanAcceptFiles.cs

Automated pass

2023-06-24 01:00:03 +09:00

IHasFiles.cs

Manual fixes to reduce warnings to zero

2023-06-24 01:52:53 +09:00

IHasGuidPrimaryKey.cs

Automated pass

2023-06-24 01:00:03 +09:00

IHasNamedFiles.cs

Automated pass

2023-06-24 01:00:03 +09:00

IHasOnlineID.cs

Automated #nullable processing

2022-06-17 16:37:17 +09:00

IHasPrimaryKey.cs

Automated pass

2023-06-24 01:00:03 +09:00

IHasRealmFiles.cs

Remove IScoreInfo : IHasNamedFiles inheritance

2023-10-26 14:58:33 +02:00

IModelDownloader.cs

Automated #nullable processing

2022-06-17 16:37:17 +09:00

IModelFileManager.cs

Automated pass

2023-06-24 01:00:03 +09:00

IModelImporter.cs

Remove redundant public specfications in interfaces

2025-05-26 17:14:41 +09:00

IModelManager.cs

Automated pass

2023-06-24 01:00:03 +09:00

ImportParameters.cs

Fix skin editor freezing game if opened during active gameplay

2023-10-27 14:34:30 +02:00

ImportProgressNotification.cs

Partial everything

2022-11-27 00:00:27 +09:00

ImportTask.cs

Bring back disposal of stream after copy-out to MemoryStream

2023-09-14 19:36:35 +02:00

INamedFile.cs

Automated #nullable processing

2022-06-17 16:37:17 +09:00

INamedFileInfo.cs

Automated pass

2023-06-24 01:00:03 +09:00

INamedFileUsage.cs

Automated #nullable processing

2022-06-17 16:37:17 +09:00

IPostNotifications.cs

Remove redundant public specfications in interfaces

2025-05-26 17:14:41 +09:00

ISoftDelete.cs

Remove redundant nullable suppression directives

2023-06-07 08:20:41 +03:00

LegacyArchiveExporter.cs

Fix formatting

2024-04-30 21:47:03 +08:00

LegacyBeatmapExporter.cs

Implement special exporter intended specifically for submission flows

2025-02-05 14:01:37 +01:00

LegacyBeatmapImporter.cs

Fix legacy beatmap importer not always handling nested paths correctly

2023-10-03 16:01:17 +09:00

LegacyCollectionImporter.cs

Fix re-importing existing collections not correctly adding new items

2022-08-16 16:43:05 +09:00

LegacyExporter.cs

Revert unnecessary complexity

2024-12-11 01:03:55 -05:00

LegacyImportManager.cs

Update HasFlag usages

2024-07-03 00:19:04 +09:00

LegacyModelImporter.cs

Move ImportParameters to better home

2022-12-13 21:41:26 +09:00

LegacyScoreExporter.cs

Mark exporter extensions as untranslatable

2023-05-06 19:42:28 +02:00

LegacyScoreImporter.cs

Path.GetExtension() will not get null

2023-02-19 02:56:53 +09:00

LegacySkinExporter.cs

Use UTF-8 encoding when exporting skin archives

2025-06-03 13:54:54 +02:00

LegacySkinImporter.cs

create a task to export to avoid block main thread

2022-11-17 01:08:06 +09:00

Live.cs

Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0

2022-12-16 18:16:26 +09:00

MemoryCachingComponent.cs

Add debounce to difficulty calculation operations in churn scenarios

2025-05-19 16:16:33 +09:00

MissingBeatmapNotification.cs

Fix presenting score potentially dying due to deleted beatmap

2025-04-24 08:47:08 +02:00

ModelDownloader.cs

Switch IsImportant to init property isntead of virtual

2025-01-22 16:41:26 +09:00

ModelManager.cs

Fix skins containing subdirectories breaking on external edit on windows

2025-07-03 08:16:51 +02:00

OnlineLookupCache.cs

Apply NRT to MemoryCachingComponent classes

2023-06-09 19:00:05 +09:00

RealmAccess.cs

Fix comment

2025-07-22 09:44:35 +02:00

RealmArchiveModelImporter.cs

Fix external edit filename sanitising unintentionally dropping folder separators (#34945)

2025-09-07 21:47:20 +09:00

RealmDetachedBeatmapStore.cs

Fix thread safety when calling BeatmapStore.GetBeatmapSets

2025-04-16 15:53:20 +09:00

RealmExtensions.cs

Fill out xmldoc and adjust inline commentary

2023-08-16 09:40:46 +02:00

RealmFileStore.cs

Reference property via nameof rather than hardcoding

2024-01-09 11:49:42 +01:00

RealmLive.cs

Add helper method for safer realm Find<T>

2023-08-16 15:37:09 +09:00

RealmLiveUnmanaged.cs

Automated #nullable processing

2022-06-17 16:37:17 +09:00

RealmObjectExtensions.cs

Add support for grouping beatmaps by collections

2025-08-01 16:23:26 +09:00

RealmResetEmptySet.cs

Merge branch 'master' into upgrade-packages

2025-01-08 01:23:28 +09:00

StandardisedScoreMigrationTools.cs

Fix one remaining method call

2024-11-29 21:21:05 +09:00

TooManyDownloadsNotification.cs

Partial everything

2022-11-27 00:00:27 +09:00

UserLookupCache.cs

Use lookup request in user lookup cache

2024-10-08 14:05:27 +02:00