1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-13 15:27:30 +08:00
osu-lazer/osu.Game
Bartłomiej Dach 0d2a47167c
Fix crash on calculating playlist duration when rate-changing mods are present
Regressed in https://github.com/ppy/osu/pull/28399.

To reproduce, enter a playlist that has an item with a rate-changing mod
(rather than create it yourself).

This is happening because `APIRuleset` has `CreateInstance()`
unimplemented:

    b4cefe0cc2/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs (L159)

and only triggers when the playlist items in question originate from
web.

This is why it is bad to have interface implementations throw outside of
maybe mock implementations for tests. `CreateInstance()` is a scourge
elsewhere in general, we need way less of it in the codebase (because
while convenient, it's also problematic to implement in online contexts,
and also expensive because reflection).
2024-06-25 11:28:10 +02:00
..
Audio Adjust AudioFilter to framework-side changes 2024-06-18 07:30:46 +02:00
Beatmaps Merge pull request #28444 from bdach/scrolling-ruleset-editor-reloads 2024-06-20 15:15:26 +09:00
Collections Update framework 2024-05-23 01:21:12 +08:00
Configuration Move timeline toggle controls to "view" menu 2024-06-17 10:16:40 +02:00
Database Merge branch 'master' into total-score-without-mods-once-more 2024-05-27 15:16:58 +02:00
Extensions Fix date failing to display on leaderboard for some scores with weird datetimes 2024-01-14 13:52:39 +01:00
Graphics Adjust calls to GetContainingInputManager() 2024-06-18 07:41:19 +02:00
Input Fix scale control key binding breaking previous defaults 2024-06-24 09:46:23 +08:00
IO Update naming of enum fields in ObjType 2024-05-01 17:24:53 +03:00
IPC Handle osu:// scheme links via IPC in desktop game 2022-06-20 21:26:22 +02:00
Localisation Move timeline toggle controls to "view" menu 2024-06-17 10:16:40 +02:00
Models Use native query to avoid huge overheads when cleaning up realm files 2024-01-09 15:37:29 +09:00
Online Fix crash on calculating playlist duration when rate-changing mods are present 2024-06-25 11:28:10 +02:00
Overlays Adjust calls to GetContainingInputManager() 2024-06-18 07:41:19 +02:00
Performance Expose high performance session state 2024-04-16 10:04:38 +08:00
Properties Make medal overlay respect overlay disable via activation mode 2024-02-20 16:31:31 +01:00
Replays Show smoke in replays 2022-09-18 17:55:06 -07:00
Rulesets Merge branch 'master' into hit-animations 2024-06-23 04:32:47 +09:00
Scoring Merge branch 'master' into negative-frame-handling 2024-05-29 13:14:59 +09:00
Screens Fix crash on calculating playlist duration when rate-changing mods are present 2024-06-25 11:28:10 +02:00
Skinning Adjust transitions 2024-06-07 17:04:16 +08:00
Storyboards Implement toggling visibility of pass and fail storyboard layers 2024-06-14 13:59:02 +02:00
Tests Fix test failures due to automatic break generation kicking in 2024-06-19 11:32:08 +02:00
Updater Warn about not using an official "deployed" build 2024-03-21 00:47:45 +09:00
Users Fix nullability inspection 2024-05-10 23:26:43 +08:00
Utils Fix code quality and null handling 2024-06-07 00:01:50 +08:00
.editorconfig Add localisation length hinting 2022-04-28 19:26:28 +09:00
FodyWeavers.xml More realm analytic disables 2023-07-20 17:51:33 +09:00
osu!.res And then everything became one 2017-09-19 16:06:58 +09:00
osu.Game.csproj Update resources 2024-06-22 22:01:05 +08:00
OsuGame.cs Merge branch 'master' into footer-v2-become-global 2024-06-08 14:13:05 +03:00
OsuGameBase_Importing.cs Automated pass 2023-06-24 01:00:03 +09:00
OsuGameBase.cs Revert "Temporary rollback of framework / SDL3" 2024-05-22 16:29:39 +08:00
PerformFromMenuRunner.cs Partial everything 2022-11-27 00:00:27 +09:00