1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 19:33:01 +08:00
osu-lazer/osu.Game/Online
Bartłomiej Dach 0d2a47167c
Fix crash on calculating playlist duration when rate-changing mods are present
Regressed in https://github.com/ppy/osu/pull/28399.

To reproduce, enter a playlist that has an item with a rate-changing mod
(rather than create it yourself).

This is happening because `APIRuleset` has `CreateInstance()`
unimplemented:

    b4cefe0cc2/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs (L159)

and only triggers when the playlist items in question originate from
web.

This is why it is bad to have interface implementations throw outside of
maybe mock implementations for tests. `CreateInstance()` is a scourge
elsewhere in general, we need way less of it in the codebase (because
while convenient, it's also problematic to implement in online contexts,
and also expensive because reflection).
2024-06-25 11:28:10 +02:00
..
API Remove using statement 2024-05-30 17:45:32 +09:00
Chat Move dialog strings to more common class name 2024-05-31 11:46:32 +09:00
Leaderboards Merge branch 'master' into LeaderBoardScore_clean 2024-06-07 22:42:49 +03:00
Metadata Add client/server models & operations for "daily challenge" feature 2024-05-17 10:58:08 +02:00
Multiplayer Fix room status not updating when password is changed while inside the room 2024-05-03 11:37:09 +02:00
Notifications/WebSocket Fix ruleset medals not displaying due to deserialisation failure 2024-03-11 21:34:10 +01:00
Placeholders Fix various other inspections 2023-10-17 17:48:51 +09:00
Rooms Fix crash on calculating playlist duration when rate-changing mods are present 2024-06-25 11:28:10 +02:00
Solo Move away from Solo namespace 2024-02-29 01:21:17 +03:00
Spectator Fix SpectatorClient holding references to Player 2024-04-03 17:32:02 +09:00
BeatmapDownloadTracker.cs Bring realm library up-to-date 2023-07-06 13:37:43 +09:00
DevelopmentEndpointConfiguration.cs Remove no longer relevant changes 2024-01-29 09:05:03 +01:00
DownloadState.cs Fix playlist items showing download button briefly during initial local presence checks 2022-09-08 17:10:45 +09:00
DownloadTracker.cs Partial everything 2022-11-27 00:00:27 +09:00
EndpointConfiguration.cs Update endpoints to final production endpoints 2024-01-30 18:40:17 +09:00
HubClient.cs Rename StartAsync -> ConnectAsync 2022-11-02 11:44:16 +09:00
HubClientConnector.cs Centralise and improve messaging around online state 2023-11-21 15:15:46 +09:00
IHubClientConnector.cs Implement client-side disconnection flow 2023-11-21 15:15:45 +09:00
ILinkHandler.cs Add and use ILinkHandler interface 2022-06-20 20:04:21 +02:00
IStatefulUserHubClient.cs Add extended xmldoc to DisconnectRequested() 2024-02-16 13:09:36 +01:00
OnlineStatusNotifier.cs Handle forced logouts due to password change too 2024-01-26 10:53:27 +01:00
OnlineViewContainer.cs Update APIState checks 2023-11-16 20:39:23 +09:00
PersistentEndpointClient.cs Add/adjust xmldocs 2022-11-02 13:16:34 +09:00
PersistentEndpointClientConnector.cs Use staggered exponential backoff when retrying in PersistentEndpointClientConnector 2024-02-06 15:40:30 +01:00
PollingComponent.cs Partial everything 2022-11-27 00:00:27 +09:00
ProductionEndpointConfiguration.cs Remove no longer relevant changes 2024-01-29 09:05:03 +01:00
ScoreDownloadTracker.cs Add LegacyOnlineID handling to places that definitely need it 2023-10-16 11:20:02 +02:00
SignalRDerivedTypeWorkaroundJsonConverter.cs Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0 2022-12-16 18:16:26 +09:00
SignalRUnionWorkaroundResolver.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
SignalRWorkaroundTypes.cs Simplify UserActivity for serialisability over the wire 2023-12-06 18:52:26 +01:00
UserStatisticsUpdate.cs Move away from Solo namespace 2024-02-29 01:21:17 +03:00
UserStatisticsWatcher.cs Move away from Solo namespace 2024-02-29 01:21:17 +03:00