1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 08:23:00 +08:00
osu-lazer/osu.Game/Beatmaps
Bartłomiej Dach 05bd912a21
Revert internal access modifier application
Unfortunately breaks a few classes (which is fixable), and also breaks
Moq/Castle dynamic proxies (which is unfortunate).

Relevant error:

    System.TypeLoadException : Method 'GetPanelBackground' in type 'Castle.Proxies.IWorkingBeatmapProxy' from assembly 'DynamicProxyGenAssembly2, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.
    Stack Trace:
        at System.Reflection.Emit.TypeBuilder.CreateTypeNoLock()
        at System.Reflection.Emit.TypeBuilder.CreateTypeInfo()
        at Castle.DynamicProxy.Generators.Emitters.AbstractTypeEmitter.BuildType()
        at Castle.DynamicProxy.Generators.BaseInterfaceProxyGenerator.GenerateType(String typeName, INamingScope namingScope)
        at Castle.DynamicProxy.Generators.BaseProxyGenerator.<>c__DisplayClass13_0.<GetProxyType>b__0(CacheKey cacheKey)
        at Castle.Core.Internal.SynchronizedDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
        at Castle.DynamicProxy.Generators.BaseProxyGenerator.GetProxyType()
        at Castle.DynamicProxy.DefaultProxyBuilder.CreateInterfaceProxyTypeWithoutTarget(Type interfaceToProxy, Type[] additionalInterfacesToProxy, ProxyGenerationOptions options)
        at Castle.DynamicProxy.ProxyGenerator.CreateInterfaceProxyTypeWithoutTarget(Type interfaceToProxy, Type[] additionalInterfacesToProxy, ProxyGenerationOptions options)
        at Castle.DynamicProxy.ProxyGenerator.CreateInterfaceProxyWithoutTarget(Type interfaceToProxy, Type[] additionalInterfacesToProxy, ProxyGenerationOptions options, IInterceptor[] interceptors)
        at Moq.CastleProxyFactory.CreateProxy(Type mockType, IInterceptor interceptor, Type[] interfaces, Object[] arguments) in C:\projects\moq4\src\Moq\Interception\CastleProxyFactory.cs:line 50

In theory it would be possible to fix this via application of

    [assembly: InternalsVisibleTo("DynamicProxyGenAssembly2")]

onto the `osu.Game` assembly, but I think this would be bad precedent.
2023-06-08 15:23:09 +02:00
..
ControlPoints Merge branch 'master' into sample-set-controls 2023-05-24 14:03:04 +09:00
Drawables Refactor IWorkingBeatmap.Background to GetBackground() 2023-06-08 16:19:32 +09:00
Formats Merge branch 'master' into sample-set-controls 2023-05-24 14:03:04 +09:00
Legacy Remove redundant nullable suppression directives 2023-06-07 08:20:41 +03:00
Timing Remove various simple obsoletions 2022-10-28 13:20:58 +09:00
APIFailTimes.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
Beatmap.cs Fix GetMostCommonBeatLength returning zero in case of not timing points 2023-05-08 17:09:08 +09:00
BeatmapConverter.cs Fix control points not being cloned when running beatmap conversion 2022-11-01 17:42:09 +09:00
BeatmapDifficulty.cs Rename slider multiplier variable back for now 2023-05-09 16:58:19 +09:00
BeatmapDifficultyCache.cs Partial everything 2022-11-27 00:00:27 +09:00
BeatmapImporter.cs Rename slider multiplier variable back for now 2023-05-09 16:58:19 +09:00
BeatmapInfo.cs Rename variable and ensure timestamp is updated even when not saving 2023-06-06 15:11:31 +09:00
BeatmapInfoExtensions.cs Added maintainability patch by bdach 2023-03-06 16:20:36 +01:00
BeatmapManager.cs Remove usages of [ExcludeFromDynamicCompile] 2023-05-08 18:12:56 +09:00
BeatmapMetadata.cs Remove usages of [ExcludeFromDynamicCompile] 2023-05-08 18:12:56 +09:00
BeatmapMetadataInfoExtensions.cs Added maintainability patch by bdach 2023-03-06 16:20:36 +01:00
BeatmapModelDownloader.cs Add ImportAsUpdate method to IModelImporter to avoid otehr changes 2022-07-26 15:49:04 +09:00
BeatmapOnlineChangeIngest.cs Do not look up metadata for locally-modified beatmaps on save 2023-04-11 23:14:35 +02:00
BeatmapOnlineStatus.cs Add localisation support for local modification strings 2022-08-02 16:30:14 +09:00
BeatmapPanelBackgroundTextureLoaderStore.cs Fix bad math 2023-06-08 14:19:34 +02:00
BeatmapProcessor.cs Move combo information updating to an interface level helper method 2023-05-17 17:26:19 +09:00
BeatmapSetHypeStatus.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
BeatmapSetInfo.cs Remove usages of [ExcludeFromDynamicCompile] 2023-05-08 18:12:56 +09:00
BeatmapSetInfoExtensions.cs Match class name to file 2022-08-10 19:53:40 +09:00
BeatmapSetNominationStatus.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
BeatmapSetOnlineAvailability.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
BeatmapSetOnlineCovers.cs Fix tournament population failure when beatmap is not found on server 2022-09-01 22:03:01 +09:00
BeatmapSetOnlineGenre.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
BeatmapSetOnlineLanguage.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
BeatmapSetOnlineNomination.cs Move and rename nomination response model to singular 2023-01-07 10:54:48 -08:00
BeatmapStatistic.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
BeatmapStatisticIcon.cs Partial everything 2022-11-27 00:00:27 +09:00
BeatmapUpdater.cs Centralise beatmap playable duration and bounds lookups 2023-05-25 17:32:48 +09:00
BeatmapUpdaterMetadataLookup.cs Remove usages of [ExcludeFromDynamicCompile] 2023-05-08 18:12:56 +09:00
BeatmapUserSettings.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
BeatSyncProviderExtensions.cs Replace parantheses with nullable-bool equality operation 2022-08-03 20:11:08 +03:00
CountdownType.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
DifficultyRating.cs Remove redundant nullable suppression directives 2023-06-07 08:20:41 +03:00
DifficultyRecommender.cs Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0 2022-12-16 18:16:26 +09:00
DummyWorkingBeatmap.cs Refactor IWorkingBeatmap.Background to GetBackground() 2023-06-08 16:19:32 +09:00
FlatFileWorkingBeatmap.cs Refactor IWorkingBeatmap.Background to GetBackground() 2023-06-08 16:19:32 +09:00
FramedBeatmapClock.cs Partial everything 2022-11-27 00:00:27 +09:00
IBeatmap.cs Fix spelling 2023-05-25 17:33:41 +02:00
IBeatmapConverter.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
IBeatmapDifficultyInfo.cs Rename slider multiplier variable back for now 2023-05-09 16:58:19 +09:00
IBeatmapInfo.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
IBeatmapMetadataInfo.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
IBeatmapOnlineInfo.cs Add more properties to IBeatmapOnlineInfo 2022-06-27 16:07:15 +09:00
IBeatmapProcessor.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
IBeatmapResourceProvider.cs Mark relevant components as internal 2023-06-08 21:01:05 +09:00
IBeatmapSetInfo.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
IBeatmapSetOnlineInfo.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
IBeatSyncProvider.cs Convert interface methods to extension methods 2022-08-03 20:07:55 +09:00
IWorkingBeatmap.cs Revert internal access modifier application 2023-06-08 15:23:09 +02:00
IWorkingBeatmapCache.cs Remove unnecessary invalidation handling flow 2022-06-30 17:13:26 +09:00
MetadataLookupScope.cs Do not look up metadata for locally-modified beatmaps on save 2023-04-11 23:14:35 +02:00
MetadataUtils.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
StarDifficulty.cs Guard against NaN star difficulty results 2022-06-29 21:02:29 +09:00
WorkingBeatmap.cs Crop and disable mipmaps on beatmap panel backgrounds 2023-06-08 16:51:07 +09:00
WorkingBeatmapCache.cs Crop and disable mipmaps on beatmap panel backgrounds 2023-06-08 16:51:07 +09:00