1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 10:12:54 +08:00
Commit Graph

1838 Commits

Author SHA1 Message Date
OliBomby
71a96e8be2 Remove SV from DrumRoll 2023-08-13 21:47:13 +02:00
Bartłomiej Dach
6d018c08af
Rename Apply{Vertical -> Horizontal}Centering to match common understanding 2023-07-28 22:09:28 +02:00
Dean Herbert
deba6e2508 Fix osu!taiko editor playfield missing a piece
Regressed with recent centering changes in https://github.com/ppy/osu/pull/24220
2023-07-27 02:24:10 +09:00
Bartłomiej Dach
7e98d319d8
Use update-invariant way of checking for second press on same frame
Fixes the same issue that 970ea50269 did,
but with no `AlwaysPresent` usage.
2023-07-25 20:07:03 +02:00
chayleaf
970ea50269 fix alive hitobjects blocking hits in taiko with hd 2023-07-20 23:20:35 +07:00
Bartłomiej Dach
041e818892
Fix nested hits not being hittable if cut off by parent object ending 2023-07-15 18:44:47 +02:00
Bartłomiej Dach
9e960894c2
Add inline commentary about OnKilled() override 2023-07-15 18:22:04 +02:00
chayleaf
3e91d30825 move StrongNestedHit OnKilled to DrawableStrongNestedHit 2023-07-15 22:33:16 +07:00
chayleaf
7f957d3fbe Fix some taiko maps not finishing in some conditions
I don't know how to reproduce this issue in a test, so no tests for now.
Nonetheless, this fixes the issue for me at least on one map:
https://osu.ppy.sh/beatmapsets/1899665#taiko/3915653

This workaround is similar to #16475 (the test from that commit got
eventually removed for some reason).
2023-07-15 20:24:40 +07:00
Bartłomiej Dach
632077319f
Fix taiko statistics table not using 2-column layout 2023-07-13 20:06:53 +02:00
Bartłomiej Dach
16540d69d5
Merge pull request #24206 from peppy/results-screen-misc
Fix some minor issues with results screen
2023-07-13 19:49:49 +02:00
Dean Herbert
9ad63bae37 Add missing heading for statistics section in results screen 2023-07-13 18:50:52 +09:00
Dean Herbert
259ac6d427 Fix osu!taiko swells eating input after already being judged 2023-07-13 13:32:20 +09:00
Bartłomiej Dach
7be5e0e978
Implement back-and-forth conversion of ModScoreV2 and LegacyMods 2023-07-09 16:15:21 +02:00
Bartłomiej Dach
ba0cd7a3f2
Fix flourish sample not playing if strong hits are hit early 2023-07-08 19:22:32 +02:00
Bartłomiej Dach
fee56ac6d2
Use new IGameplayClock.IsRewinding member 2023-07-08 18:29:49 +02:00
Bartłomiej Dach
055e4a78f0
Merge branch 'master' into taiko-hitsounding-final-attempt 2023-07-08 18:10:04 +02:00
Dean Herbert
a76cd9b0e6
Update osu.Game.Rulesets.Taiko/UI/DrumSamplePlayer.cs
Co-authored-by: Jamie Taylor <me@nekodex.net>
2023-07-08 00:44:26 +09:00
Dean Herbert
d72765b6f8
Merge pull request #24114 from peppy/editor-save-local-score-management
Ensure scores always have the correct linked `BeatmapInfo`
2023-07-07 15:40:54 +09:00
Dean Herbert
8b5d5c9ae2 Fix rewinding causing incorrectly stronged non-strong hits 2023-07-07 15:13:25 +09:00
Dean Herbert
755b82a308 Implement flourish trigger source via base class 2023-07-07 14:54:49 +09:00
Dean Herbert
9bdc80a749 Move flourish playback to own trigger source 2023-07-07 14:46:36 +09:00
Dean Herbert
6bfbcca2fd Move VolumeAwareHitSampleInfo to own file 2023-07-07 14:45:33 +09:00
Dean Herbert
48f27ff340 Move trigger source to own file
Having such a large nested class inside a small top level class is VERY
confusing.
2023-07-07 14:31:14 +09:00
Dean Herbert
d4c252ddf9 Revert cancelling logic changes based on review feedback 2023-07-07 14:28:57 +09:00
Dean Herbert
0b5a3d6a91
Merge pull request #24120 from peppy/fix-taiko-animation-timing
Fix taiko hit overlay animation timing not accounting for timing section start time
2023-07-07 13:05:20 +09:00
Dean Herbert
5af4aa8741 Avoid strong hits cutting off other strong hits 2023-07-06 14:05:49 +09:00
Dean Herbert
9ff6b3fcd3 Merge branch 'master' into editor-save-local-score-management 2023-07-06 12:28:44 +09:00
Bartłomiej Dach
a87a631c50
Merge branch 'master' into taiko-hitsounding-final-attempt 2023-07-05 22:15:32 +02:00
Bartłomiej Dach
afc0c4f3c2
Merge pull request #24088 from peppy/taiko-hitsounding-drum-sample-player
Move all remaining osu!taiko sample playback logic out of `DrawableHitObject`s
2023-07-05 21:57:49 +02:00
Dean Herbert
8f61f5e4c6 Cache Playfield for the sake of tests
I'm open to an alternative. Name it.
2023-07-05 18:44:27 +09:00
Dean Herbert
289f916cd7 Remove outdated TODO 2023-07-05 18:44:27 +09:00
Dean Herbert
759cd5aec7 Warm up pool with argon-specific drum samples 2023-07-05 18:44:27 +09:00
Dean Herbert
f086908831 Don't attempt to play drum samples when rewinding 2023-07-05 18:44:27 +09:00
Dean Herbert
16f1a7694d Add time-based flourish support 2023-07-05 18:44:27 +09:00
Dean Herbert
c72ebcfd53 Fix skin fallback not working as expected 2023-07-05 18:44:27 +09:00
Dean Herbert
010262c764 Change strong hit sample handling to be user input based, not hit object based 2023-07-05 18:44:27 +09:00
Dean Herbert
a9587fd1aa Move strong hit handling to DrumSamplePlayer and separte trigger sources 2023-07-05 18:44:27 +09:00
Dean Herbert
27af07b74b Add basic implementation of argon osu!taiko hitsounds (volume / flourish / strong) 2023-07-05 18:44:27 +09:00
Dean Herbert
beed390031 Add balance adjust to base implementation of DrumSampleTriggerSource 2023-07-05 18:44:27 +09:00
Dean Herbert
ae86fc736a Add argon-specific DrumSamplePlayer 2023-07-05 18:44:27 +09:00
Dean Herbert
f54eb8d7fa Move DrumSamplePlayer to be a skinnable component 2023-07-05 18:44:27 +09:00
Dean Herbert
9a7bf1bedd Fix reversed order of sample return 2023-07-05 18:44:01 +09:00
Dean Herbert
3b9d7af9ee Fix taiko hit overlay animation timing not accounting for timing section start time 2023-07-05 17:25:31 +09:00
Dean Herbert
1629024111 ILegacyScoreProcessor -> ILegacyScoreSimulator 2023-07-04 17:32:54 +09:00
Dean Herbert
d74b1e148d Make ScoreInfo.BeatmapInfo nullable 2023-07-04 14:50:34 +09:00
Dean Herbert
571dbf5ab8 Adjust logic to avoid creating List<> each playback 2023-06-30 15:42:58 +09:00
Dean Herbert
c98abf1723 More correctly handle StrongNestedHitObjects 2023-06-30 15:38:17 +09:00
Dean Herbert
e87cf6d256 Move all remaining osu!taiko sample playback logic out of DrawableHitObjects 2023-06-30 15:21:34 +09:00
Dan Balasescu
c6ad184d94 Move Ruleset method to ILegacyRuleset interface 2023-06-29 17:24:37 +09:00