62006 Commits

This Branch

This Branch

All Branches

• Refactor GameplaySampleTriggerSource test to not be realtime dependent
  Dean Herbert · 2023-02-16 17:58:44 +09:00
  979c079f8b
• Apply NRT to GamepleSampleTriggerSource tests
  Dean Herbert · 2023-02-16 17:58:44 +09:00
  9d02a2ef0e
• Always create ResumeOverlay, with UseResumeOverlay flag only affecting whether it is displayed or not
  Dean Herbert · 2023-02-16 15:47:20 +09:00
  ce9ef3bc3c
• Merge branch 'master' into hide-resume-overlay
  Dean Herbert · 2023-02-16 15:42:14 +09:00
  7afdcb9383
• Rename left-over skinnable naming in SerialisedDrawableExtensions
  Dean Herbert · 2023-02-16 15:34:41 +09:00
  81dcc105a9
• Standardise all local SkinComponentsContainerLookup variables to containerLookup
  Dean Herbert · 2023-02-16 15:33:56 +09:00
  76f7accd13
• Reword xmldoc on ISerialisableDrawable to make less skin-centric
  Dean Herbert · 2023-02-16 15:31:35 +09:00
  eea0cd3cf8
• Reword and fix typos in some new xmldoc

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-02-16 15:27:30 +09:00
  0b25f7baeb
• Add clipboard dependency to SkinEditor specific tests

  This is usually provided by the `SkinEditorOverlay`, which is not always
  present in tests.

  Dean Herbert · 2023-02-16 15:24:38 +09:00
  2fbaf88a3c
• Merge pull request #22292 from ekrctb/maximum-judgement-offset-in-hit-object

  Move MaximumJudgementOffset to HitObject

  Bartłomiej Dach · 2023-02-16 00:52:35 +01:00
  87901bc8b1
• Merge branch 'master' into maximum-judgement-offset-in-hit-object
  Bartłomiej Dach · 2023-02-16 00:15:51 +01:00
  c315113fde
• feat: implement new design of key counter
  tsrk · 2023-02-15 22:18:02 +00:00
  74e7cc2056
• reafactor: simplify type checking
  tsrk · 2023-02-15 22:06:35 +00:00
  e9dcc257b4
• style: nullable pass on KeyCounterDisplay
  tsrk · 2023-02-15 22:06:10 +00:00
  b0a2e69f95
• refactor: rename trigger classes

  Makes it better to understand their purpose

  tsrk · 2023-02-15 21:46:13 +00:00
  076eb81b21
• style(KeyCounter): rename (Un)lit methods to (Un)light
  tsrk · 2023-02-15 21:41:41 +00:00
  a644fae364
• fix(KeyCounter): don't override Handle

  This caused the Keyboard inputs to register twice, which is not what we
  want.

  tsrk · 2023-02-15 21:41:41 +00:00
  df0633858c
• refactor: rename Trigger class to InputTrigger
  tsrk · 2023-02-15 21:41:36 +00:00
  157bba7830
• Merge branch 'master' into skinnable-clean-up-documentation
  Bartłomiej Dach · 2023-02-15 21:26:11 +01:00
  768eea1ea8
• Merge pull request #22647 from peppy/remove-target-component-container

  Simplify and rename `SkinnableTargetComponentsContainer`

  Bartłomiej Dach · 2023-02-15 21:25:49 +01:00
  1d5d34ba0e
• Move logic to Export method
  Cootz · 2023-02-15 22:43:43 +03:00
  387a6f1330
• Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
  Cootz · 2023-02-15 22:29:38 +03:00
  fb06a77e2b
• fix applied
  Cootz · 2023-02-15 22:15:44 +03:00
  1f586c129c
• Merge pull request #22646 from peppy/fix-skin-export-matching-directory

  Fix exports failing if a directory exists with the proposed filename

  Bartłomiej Dach · 2023-02-15 19:04:15 +01:00
  455fb7789c
• Make skin editor clipboard shared between screens and skins to allow moving elements over
  Dean Herbert · 2023-02-15 19:35:37 +09:00
  925deb7ca5
• Fix clipboard changes not batching as undo steps
  Dean Herbert · 2023-02-15 19:35:22 +09:00
  bc83b0c264
• Fix components having incorrect default positions
  Dean Herbert · 2023-02-15 19:34:42 +09:00
  bcf2555545
• Add basic skin editor clipboard implementation
  Dean Herbert · 2023-02-15 19:28:42 +09:00
  d653335b6f
• Change GameplaySkinComponentLookup's generic to always be an enum

  And document the class better.

  Dean Herbert · 2023-02-15 18:48:14 +09:00
  08ed174f61
• Rename SkinnableTargetContainer to SkinComponentsContainer

  Also use full `SkinComponentsContainerLookup` instead of the sub-type.
  This will potentially be useful once we bring in per-ruleset targets.

  Dean Herbert · 2023-02-15 18:37:41 +09:00
  a92e42bb84
• Move extension methods closer to serialisation classes
  Dean Herbert · 2023-02-15 18:37:41 +09:00
  b1cf6d83d8
• Move the lookup type out of ISserialisableDrawableContainer
  Dean Herbert · 2023-02-15 18:37:41 +09:00
  e61d2d571c
• Rename ISkinnableTarget to ISerialisableDrawableContainer
  Dean Herbert · 2023-02-15 18:37:41 +09:00
  a7b47f6503
• Rename ISkinnableDrawable to ISerialisableDrawable
  Dean Herbert · 2023-02-15 18:37:41 +09:00
  d159d6b970
• Add further documentation to skin classes
  Dean Herbert · 2023-02-15 18:23:19 +09:00
  8cb5a51aa7
• Rename SkinnableDrawableInfo to SerialisedDrawableInfo
  Dean Herbert · 2023-02-15 18:23:19 +09:00
  856efd9fd9
• Rename SkinnableInfo to SkinnableDrawableInfo
  Dean Herbert · 2023-02-15 18:23:17 +09:00
  9e651a7ca2
• Move SkinnableInfo to better namespace
  Dean Herbert · 2023-02-15 18:23:10 +09:00
  6010dde86e
• Merge remote-tracking branch 'origin/bubble_mod_implementation_clean' into bubble_mod_implementation_clean
  mk56-spn · 2023-02-15 10:05:00 +01:00
  d413b69f55
• Remove dysfunctional slider colouring
  mk56-spn · 2023-02-15 10:04:50 +01:00
  8fc35b159f
• Remove BubbleInfo struct and consume DrawableOsuHitObjects directly
  mk56-spn · 2023-02-15 10:00:46 +01:00
  297963b461
• Fix test container lookup failure
  Dean Herbert · 2023-02-15 17:47:34 +09:00
  d9b4d932c9
• Invert pointless nested if statement
  mk56-spn · 2023-02-15 09:37:47 +01:00
  1d1c794ccf
• make transform duration for bubble a method instead of a variable
  mk56-spn · 2023-02-15 09:33:18 +01:00
  e9a7d90273
• Make colouring for bubble more intuitive and remove unnecessary alpha assignment
  mk56-spn · 2023-02-15 09:30:56 +01:00
  82292d6162
• Apply NRT to TestSceneBeatmapSkinFallbacks
  Dean Herbert · 2023-02-15 17:30:21 +09:00
  ca75f0ec77
• Simplify and rename SkinnableTargetComponentsContainer
  Dean Herbert · 2023-02-15 17:30:21 +09:00
  8bbd00822c
• Fix skin export failing if a directory exists with the proposed filename
  Dean Herbert · 2023-02-15 16:11:16 +09:00
  e71dfd7555
• Correct timings to match stable exactly + don't fade with hidden
  Adam · 2023-02-15 01:02:54 -06:00
  5e774a28d8
• Merge branch 'master' into maximum-judgement-offset-in-hit-object
  Dean Herbert · 2023-02-15 14:48:15 +09:00
  da8ab7143b