62006 Commits

This Branch

This Branch

All Branches

• Fix SkinnableLighting showing up as a user placeable component
  Dean Herbert · 2023-02-17 18:24:05 +09:00
  675e5b81f3
• Add ability to retrieve serialisable drawables for specific rulesets
  Dean Herbert · 2023-02-17 18:24:05 +09:00
  2267aa1ac2
• Ensure skin default component layouts only apply to global layout for now
  Dean Herbert · 2023-02-17 18:24:05 +09:00
  ffb99364b9
• Fix selection on the edge of blueprints (in the new inflation area) failing
  Dean Herbert · 2023-02-17 18:19:46 +09:00
  6c61c5f4a8
• Improve visuals of skin blueprint
  Dean Herbert · 2023-02-17 18:19:46 +09:00
  16d94b4ea2
• fix: compilation
  tsrk · 2023-02-17 09:17:11 +00:00
  8830e06588
• style(KeyCounterDisplay): remove type check
  tsrk · 2023-02-17 09:09:56 +00:00
  c94e647e21
• Update SkinDeserialisationTest to work with new serialisation structure
  Dean Herbert · 2023-02-17 16:22:48 +09:00
  9793774377
• Change serialisation format of skin layouts to allow more flexibility

  Also adds per-ruleset storage for each container type.

  Dean Herbert · 2023-02-17 14:19:19 +09:00
  6b3652f567
• Always return a non-null container for SkinComponentsContainerLookups
  Dean Herbert · 2023-02-17 14:19:19 +09:00
  9685fb2114
• Add optional ruleset identifier to SkinComponentsContainerLookup
  Dean Herbert · 2023-02-17 14:19:19 +09:00
  4cc6664dc7
• Add xmldoc around SkinComponentsContainerLookup
  Dean Herbert · 2023-02-17 14:18:05 +09:00
  1a63ca9ece
• I don't know what .ots is but let's not use random file extension that make no sense
  Dean Herbert · 2023-02-17 13:46:27 +09:00
  372b6b794c
• More constants and assert fixes
  Dean Herbert · 2023-02-17 13:46:27 +09:00
  8ef3fb26e0
• Simplify test storage by removing nested storage
  Dean Herbert · 2023-02-17 13:43:42 +09:00
  86d110e893
• Mark test as fixture
  Dean Herbert · 2023-02-17 13:39:31 +09:00
  4560ae6b02
• Move long filename to fixture level
  Dean Herbert · 2023-02-17 13:39:24 +09:00
  99236f0ae8
• Expose constant publicly rather than reexposing business
  Dean Herbert · 2023-02-17 13:34:19 +09:00
  8c772a723f
• Rename max length variable to make sense (it's a filename limit, not path)
  Dean Herbert · 2023-02-17 13:33:22 +09:00
  96b1498932
• Tidy up new test method code quality
  Dean Herbert · 2023-02-17 13:30:00 +09:00
  415220a447
• style(KeyCounter): rename IsLit to IsActive
  tsrk · 2023-02-17 00:56:17 +00:00
  d0e8d65766
• fix(TestSceneOsuTouchInput): missing Value call
  tsrk · 2023-02-17 00:13:45 +00:00
  6193aeed12
• Add triangles to ModSelectColumn
  Andrei Zavatski · 2023-02-17 03:09:32 +03:00
  a84f20bf32
• refactor: make FillFlowContainer read-only
  tsrk · 2023-02-16 23:17:47 +00:00
  e3ca751027
• style(KeyCounter): rename methods and arguments

  As for the second suggestion in
  https://github.com/ppy/osu/pull/22654#discussion_r1109047998,
  I went with the first one as only one Trigger actually uses this
  argument for rewinding.

  tsrk · 2023-02-16 23:15:03 +00:00
  c61fac578c
• Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
  Cootz · 2023-02-17 01:51:24 +03:00
  810712386d
• Fix inspectCode issues
  Cootz · 2023-02-17 01:50:24 +03:00
  f4038a49a1
• Improve naming
  Cootz · 2023-02-17 01:46:15 +03:00
  1d8b348e4c
• Add more test cases
  Cootz · 2023-02-17 01:44:45 +03:00
  6cb00cd42f
• Enable fading when hidden only hides appreach circles
  Adam · 2023-02-16 16:31:42 -06:00
  e06502085e
• refactor(KeyCounter): address bindables issues

  `IsCounting` is back being an auto-property.
  `countPresses` is now encapsulated and being exposed as an
  `IBindable<int>` via `CountPresses`

  tsrk · 2023-02-16 22:20:34 +00:00
  ddd6c1a1c6
• refactor(KeyCounter): remove circularity
  tsrk · 2023-02-16 21:59:39 +00:00
  6340730427
• Merge pull request #22338 from Pasi4K5/hide-resume-overlay

  Hide `ResumeOverlay` when `OsuModAutopilot` is enabled

  Bartłomiej Dach · 2023-02-16 22:22:19 +01:00
  9f9893d93a
• Merge branch 'master' into revert-result-in-playfield
  Bartłomiej Dach · 2023-02-16 21:54:29 +01:00
  3ee046000e
• Merge branch 'master' into hide-resume-overlay
  Bartłomiej Dach · 2023-02-16 21:33:23 +01:00
  66e9bb2581
• Merge pull request #22645 from peppy/adjust-song-select-background-dim

  Adjust song select background dimming to be more evenly applied

  Bartłomiej Dach · 2023-02-16 21:27:27 +01:00
  bba1722725
• Revert ResumeOverlay setter accessibility change
  Bartłomiej Dach · 2023-02-16 21:26:01 +01:00
  b8084a15eb
• Merge branch 'master' into adjust-song-select-background-dim
  Bartłomiej Dach · 2023-02-16 20:52:36 +01:00
  0186062246
• Remove redundant conditional access qualifier

  It is impossible for the callback passed to `ApplyToBackground()` to
  receive a null reference. See `OsuScreen.ApplyToBackground()` - if the
  background to call the callback on were `null`, then an
  `InvalidOperationException` would be thrown instead.

  Bartłomiej Dach · 2023-02-16 20:47:51 +01:00
  ad5132ed41
• Merge branch 'master' into fix-taiko-drum-nested-sample-detection
  Bartłomiej Dach · 2023-02-16 19:43:02 +01:00
  2fdf1fd876
• Merge pull request #22658 from peppy/gameplay-sample-trigger-source-test-fix

  Refactor `GameplaySampleTriggerSource` test to not be realtime dependent

  Bartłomiej Dach · 2023-02-16 19:39:18 +01:00
  7d86f49fce
• Add one more assert to keep coverage from previous implementation
  Bartłomiej Dach · 2023-02-16 19:02:51 +01:00
  5bdc5dfadd
• Improve code slightly
  Cootz · 2023-02-16 16:42:07 +03:00
  6819a45a1b
• Add tests
  Cootz · 2023-02-16 16:26:57 +03:00
  f1da213bea
• Apply NRT to SerialisedDrawableInfo
  Dean Herbert · 2023-02-16 20:01:59 +09:00
  cb7df7282b
• Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
  Cootz · 2023-02-16 13:22:11 +03:00
  3057ccb635
• Code cleanup pass:

  Make bubble transform logic more sane.
  
  Extract bubble `getPosition()` method.
  
  Address poorly named variables.

  mk56-spn · 2023-02-16 11:12:30 +01:00
  d5bc8e2941
• Fix song select potentially updating background parameters when not the current screen
  Dean Herbert · 2023-02-16 18:45:22 +09:00
  394d368f16
• Fix GameplaySampleTriggerSource not considering nested objects when determining the best sample to play
  Dean Herbert · 2023-02-16 18:21:33 +09:00
  affa9507a1
• Add test coverage of GameplaySampleTriggerSource not considering nested objects
  Dean Herbert · 2023-02-16 18:21:33 +09:00
  b59ec551f6