1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 17:33:03 +08:00
Commit Graph

47 Commits

Author SHA1 Message Date
Bartłomiej Dach
3501b7c22b
Fix some more nullability inspections 2023-08-09 21:32:46 +02:00
Dean Herbert
4e83245acf Apply nullability to all remaining tests where it wasn't applied 2023-08-10 00:24:57 +09:00
Dean Herbert
6549ca5304 Revert some usages of AsNonNull() in tests
We generally prefer `!` when it is unambiguous usage (ie. direct access).
2023-08-10 00:20:37 +09:00
cdwcgt
8a06914438
remove #nullable disable in tournament 2023-07-29 22:25:06 +09:00
Dean Herbert
0ab0c52ad5 Automated pass 2023-06-24 01:00:03 +09:00
Dan Balasescu
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
Dean Herbert
19e0b9085c Remove redundant parameters 2022-10-29 00:24:33 +09:00
Dean Herbert
29f504ecc0 Remove obsoleted tournament migration flow 2022-10-28 13:04:56 +09:00
Dean Herbert
59d3cc52c4 Avoid leaving left-over files after test run completes 2022-07-26 15:08:18 +09:00
Dan Balasescu
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dean Herbert
218642c300 Update unsafe file write usages 2022-05-16 18:05:27 +09:00
Dean Herbert
a7a7584d3e Add test coverage ensuring ruleset ID is correct after bracket read
Historically, tournament client may have written incorrect `OnlineID`
values. We wanted to use `ShortName` to re-fetch the ruleset. This test
ensures this flow is working correctly.
2022-03-31 18:39:58 +09:00
Dean Herbert
86c844bd58 Update remaining usages of GetSuitableHost in template projects 2022-01-25 14:15:29 +09:00
Dean Herbert
dd2caea694 Update GetSuitableHost usages in line with new HostOptions 2022-01-25 13:52:02 +09:00
Dean Herbert
014c840d80 Fix incorrect thread usage of ruleset in tournament DataLoadTest 2022-01-18 13:29:24 +09:00
Dean Herbert
12c3e56881 Fix IPCLocationTest not waiting for load of component
As seen at
https://github.com/ppy/osu/runs/4731480384?check_suite_focus=true.
2022-01-07 19:01:06 +09:00
Dean Herbert
be02c3f9f8 Fix a couple of remaining cases of tests not using the new temporary file location for storage 2021-12-24 20:17:47 +09:00
Dean Herbert
4b88e257e5 Update usages of CleanRunHeadlessGameHost to match new signature 2021-12-24 20:17:34 +09:00
Dean Herbert
ba05a0a383 Centralise specification of bracket.json filename 2021-12-03 16:04:11 +09:00
Bartłomiej Dach
87d6a743dd
Migrate custom tournament client assets to uppercased directories
It has transpired that on filename-case-sensitive filesystems, the
tournament client does not consistently handle custom asset paths.
Videos and mods could only be looked up from `videos` and `mods`
directories (lowercase), while flags could only be looked up from the
`Flags` directory (uppercase).

A complicating circumstance is that default country flags, coming from
osu-resources, also depend on the flag lookup being uppercased.

To attempt to clean up the handling as much as it appears to be
possible, automatically move user-supplied lowercase directories to
uppercase.
2021-11-28 16:36:19 +01:00
Dan Balasescu
0cf5a738dc
Remove unused using 2021-11-23 16:32:44 +09:00
Dean Herbert
4624977b77 Fix tournament tests potentially using data left over from previous runs 2021-11-23 14:38:37 +09:00
Dean Herbert
f1499641f3 Rename all usages of APIBeatmap to beatmap in tournament namespace 2021-10-27 18:42:48 +09:00
Dean Herbert
3130616300 Update tournament components to use APIBeatmap directly 2021-10-27 18:26:44 +09:00
Dean Herbert
7c99193ada Add tournament LadderInfo serialisation tests 2021-10-25 16:49:33 +09:00
smoogipoo
d1b0dd1f6b Fix GameHosts being run on TPL threads 2021-10-12 17:13:36 +09:00
Dean Herbert
0b8ca667a9 Add failing test coverage of loading with an unavailable ruleset 2021-07-30 01:53:25 +09:00
Dean Herbert
5c5e33f4d7 Split out common logic for tournament game host tests 2021-07-30 01:53:08 +09:00
Dean Herbert
7f7cf0b927 Fix potential failure during cleanup of files in migration tests 2021-07-06 15:08:00 +09:00
Dean Herbert
8bcb4d13fb Fix multiple tests eating host exceptions 2021-06-29 17:21:09 +09:00
Dean Herbert
88035f73e0 Fix incorrect wait logic in IPC location test
Not really willing to put more effort into fixing this one. Should do the job.
2021-03-30 14:23:49 +09:00
Shivam
2d344ae6ff wait for IPC to be populated in the test
Did not see this when locally running test until after a couple of subsequent runs.
2021-03-29 16:16:50 +02:00
Shivam
6c5a10a744 Add missing license header 2021-03-29 15:27:25 +02:00
Shivam
badf5ee4a2 Fix stable.json file directory location due to the change of how TournamentStorage works 2021-03-29 15:03:10 +02:00
smoogipoo
7fa5fd5647 Update usages of config with framework changes 2021-03-17 16:10:16 +09:00
Dean Herbert
9c566e7ffb Update tests to use correct parameters of CleanRunGameHost 2020-10-19 15:34:46 +09:00
Shivam
0cddb85f1b Move storageconfig set and saving to migrate method 2020-06-28 15:27:50 +02:00
Shivam
d82d901542 Reuse custom_tournament where it was still used as a literal 2020-06-25 20:36:55 +02:00
Shivam
839f197111 Change type from TournamentStorage to Storage in tests 2020-06-24 02:37:59 +02:00
Shivam
0ca8c961c8 Remove string interpolation & unnecessary test setup 2020-06-24 00:05:30 +02:00
Shivam
08759da3a7 Move drawings.ini out of config subfolder 2020-06-22 12:41:43 +02:00
Shivam
eec1e9ef4d Remove unnecessary comments and added file check for tournament.ini on test start 2020-06-22 12:22:59 +02:00
Shivam
56a40e616b Add drawings to the migration test 2020-06-11 20:11:44 +02:00
Shivam
222ac86304 Add newlines at the end of the file 2020-06-11 15:52:14 +02:00
Shivam
603054f521 Remove unused property and reuse tournamentBasePath 2020-06-11 15:47:21 +02:00
Shivam
883185d349 Add a comment to describe what's going on before the headless game starts 2020-06-11 15:18:21 +02:00
Shivam
18a9e5a0a6 Add NonVisual tests for custom tournaments
Can test the default directory from a clean instance, it can test a custom directory and can execute migration from an instance using the older directory setup.
2020-06-11 13:57:29 +02:00