Dean Herbert
818fac6ac8
Make realm a non-drawable component to better order disposal
...
Until now, the `RealmContextFactory` would be disposed as part of the
drawable hierarchy. This is too early, as it may be being used by higher
level components (like `ConfigManager`s, see #15115 ) that perform final
operations after the drawables have been disposed.
Seems to make sense moving this out of the drawable hierarchy and in
line with how we were doing things with EF.
2021-10-15 13:58:16 +09:00
Dan Balasescu
1e15b5a5a0
Merge pull request #15113 from peppy/rounded-button-colour-provider
...
Change `RoundedButton` to source from overlay colour provider
2021-10-15 13:52:52 +09:00
Dan Balasescu
290f816cd3
Merge pull request #15114 from peppy/fix-import-notification-test
...
Fix startup import test waiting on potentially incorrect notification type
2021-10-15 13:52:39 +09:00
Dean Herbert
e47ccbd08a
Fix realm transactional overhead when rapidly changing RulesetConfigManager values
2021-10-15 13:50:26 +09:00
smoogipoo
80dfd11c90
Remove unnecessary extra task
...
Further testing shows continuations also run before the .Wait() returns.
2021-10-15 13:28:02 +09:00
Dean Herbert
c9d8645341
Fix startup import test waiting on potentially incorrect notification type
2021-10-15 13:26:31 +09:00
Jason Won
538d980072
Rename Mod
2021-10-15 00:22:57 -04:00
Dean Herbert
d2e5c36780
Merge pull request #15112 from bdach/slider-refresh
...
Refresh appearance and use colour provider theming in sliders and checkboxes
2021-10-15 12:59:26 +09:00
Dean Herbert
7ab028576e
Change RoundedButton to source from overlay colour provider
2021-10-15 12:54:19 +09:00
Dean Herbert
f73e505ee6
Further adjustments to glow to be less bright on settings overlay
2021-10-15 12:35:19 +09:00
Jason Won
2dfc42dd53
revert interpolation changes + fix cursor trail
2021-10-14 23:34:43 -04:00
Dean Herbert
e1ac5fbed9
Remove externally exposed Expanded state and change behaviour and visuals surrounding it
2021-10-15 12:13:42 +09:00
Dean Herbert
ec5c967e71
Add test coverage of SettingsCheckbox
2021-10-15 12:13:24 +09:00
Dean Herbert
35d776078c
Ensure sliderbar nub stays glowing while dragging an adjustment
2021-10-15 11:51:08 +09:00
Dean Herbert
be3b88a5c3
Adjust glow to look good
2021-10-15 11:48:19 +09:00
Dean Herbert
b15137ecdc
Add test coverage of slider bars with colour provider applied
2021-10-15 11:48:08 +09:00
Dean Herbert
3a25bdaf3d
Merge branch 'master' into slider-timeline-velcotiy-adjust-v2
2021-10-15 11:18:37 +09:00
Dean Herbert
874d722820
Merge branch 'master' into fix-editor-difficulty-name-update
2021-10-15 11:14:45 +09:00
Dean Herbert
02d29097a2
Switch away from metadata screen before making any changes in test logic
2021-10-15 11:14:03 +09:00
Jason Won
23b50a054b
address comments
2021-10-14 20:50:47 -04:00
Dean Herbert
1eb406ad32
Merge pull request #15108 from smoogipoo/ci-only-failed-tests
2021-10-15 09:13:41 +09:00
Bartłomiej Dach
ed2f9dd443
Adjust settings slider spacings
2021-10-15 00:31:06 +02:00
Bartłomiej Dach
a10a7e7903
Refresh nub/slider appearance and use overlay theming
2021-10-15 00:31:05 +02:00
Jason Won
6b1534f5a6
Add "ghost" mod for osu
2021-10-14 18:30:55 -04:00
smoogipoo
4e315b14b8
List only failed suites/tests
2021-10-15 00:25:59 +09:00
smoogipoo
eed8fa8d69
Expand comment a bit
2021-10-15 00:20:45 +09:00
smoogipoo
e6ee360511
Fix intermittent multiplayer tests
2021-10-15 00:10:39 +09:00
Dan Balasescu
79d9aa7383
Merge pull request #15100 from peppy/fix-multiplayer-sounds-during-gameplay
...
Fix multiplayer components updating when not alive
2021-10-14 23:44:03 +09:00
Dean Herbert
ad0732484f
Just wait for metadata section to be loaded
2021-10-14 22:12:38 +09:00
Dean Herbert
9d54285b2e
Merge branch 'master' into fix-multiplayer-sounds-during-gameplay
2021-10-14 21:34:04 +09:00
Dean Herbert
a62058923f
Merge pull request #15101 from peppy/fix-add-once-usages
...
Fix incorrect usages of `Scheduler.AddOnce`
2021-10-14 21:12:00 +09:00
Dean Herbert
a31f5ca326
Update framework
2021-10-14 20:13:55 +09:00
Dean Herbert
06249c4ab2
Fix incorrect usages of Scheduler.AddOnce
2021-10-14 17:52:19 +09:00
Dean Herbert
0d86dab80a
Fix multiplayer components updating when not alive
...
Should close https://github.com/ppy/osu/issues/15092 .
- [ ] Depends on https://github.com/ppy/osu-framework/pull/4826 .
2021-10-14 17:37:10 +09:00
smoogipoo
901f107b2e
Merge branch 'master' into slider-timeline-velcotiy-adjust-v2
2021-10-14 17:25:51 +09:00
Dan Balasescu
fb9c3fe72e
Merge pull request #14619 from peppy/no-more-difficulty-control-points-info
...
Move `DifficultyControlPoint`s to be specified at a per-`HitObject` level
2021-10-14 17:24:32 +09:00
Dan Balasescu
88255f2517
Merge pull request #15097 from peppy/fix-gameplay-second-freq-ramp-on-fail
...
Fix gameplay audio ramping down in frequency a second time at the end of the fail sequence
2021-10-14 17:22:29 +09:00
Dan Balasescu
98b5587622
Merge pull request #15096 from peppy/fix-gameplay-flow-test-failures
...
Fix multiplayer gameplay flow test scene failures due to button not being ready
2021-10-14 17:22:09 +09:00
smoogipoo
0fd5fa17c0
Add more thorough check
2021-10-14 16:50:38 +09:00
Dean Herbert
1212b08672
Fix gameplay audio ramping down in frequency a second time at the end of the fail sequence
2021-10-14 16:45:34 +09:00
Dean Herbert
8a4c0c0ac8
Lock one more case of usage
2021-10-14 16:22:43 +09:00
Dean Herbert
119e9ad83e
Fix multiplayer gameplay flow test scene failures due to button not being ready
2021-10-14 15:58:42 +09:00
Dean Herbert
060bb1afbd
Add locking around async beatmap (task) retrieval
2021-10-14 15:39:53 +09:00
Dean Herbert
464bcd2b24
Merge pull request #15070 from bdach/dropdown-refresh
...
Refresh dropdown appearance & add themed variant to settings sidebar
2021-10-14 14:40:58 +09:00
Dean Herbert
2e0a2a28ab
Check mutations at each point in the process (and also check artist/title)
2021-10-14 14:40:20 +09:00
Dean Herbert
4ed794e434
Throw and log instead of silently failing on type/instance creation failure
2021-10-14 14:24:36 +09:00
Dean Herbert
364fa068b3
Add non-null check to appease inspection
2021-10-14 14:20:34 +09:00
Dean Herbert
ccc8012fd4
Mark non-localisable strings
2021-10-14 14:16:39 +09:00
Dean Herbert
3964e5c448
Fix test failure due to retyped class
2021-10-14 14:11:12 +09:00
Dean Herbert
e0babe4b79
Add global logging of WorkingBeatmap changes
2021-10-14 14:07:43 +09:00
