48948 Commits

This Branch

This Branch

All Branches

• Remove no longer required property
  Salman Ahmed · 2022-02-16 03:23:02 +03:00
  f7edf25d4c
• Merge branch 'master' into osu-distance-spacing
  Salman Ahmed · 2022-02-15 02:30:44 +03:00
  f6302fcff9
• Merge pull request #16574 from frenzibyte/expandable-controls

  Abstractify `ExpandingButtonContainer` and support contraction of settings controls

  Dean Herbert · 2022-02-15 08:29:55 +09:00
  4c8018a675
• Remove test coverage of "shift" hotkey behaviour
  Salman Ahmed · 2022-02-15 02:29:09 +03:00
  cbc8f7ff90
• Remove e.ShiftPressed handling for now

  Broken on macOS, will be handled differently later on as discussed.

  Salman Ahmed · 2022-02-15 02:21:53 +03:00
  868dcd20f5
• Update failing snap test scenes
  Salman Ahmed · 2022-02-15 02:21:53 +03:00
  500322ff21
• Add test case for distance spacing hotkeys scrolling behaviour
  Salman Ahmed · 2022-02-15 02:21:53 +03:00
  9504942cfd
• Expose distance spacing in IPositionSnapProvider for updating distance grid

  Alternate method is to expose a `SnapDistancesChanged` event in
  `IPositionSnapProvider` instead, but I chose this way as an analogue to
  `IBeatSnapProvider.BeatDivisor`, which might even make sense to be
  exposed as `BindableBeatDivisor` instead of caching that separately.

  Salman Ahmed · 2022-02-15 02:21:53 +03:00
  528dc03b8c
• Add "distance spacing" multiplier for osu! ruleset

  While osu!catch also implements a distance snap grid, it doesn't rely on
  `GetBeatSnapDistanceAt` (unlike osu!), therefore it can't have the
  "distance spacing" multiplier yet.

  Salman Ahmed · 2022-02-15 02:21:53 +03:00
  19ee05c232
• Fix test regression due to mouse overlapping settings overlay
  Dean Herbert · 2022-02-15 02:54:45 +09:00
  db74a226c0
• Reduce expansion delay on ExpandingButtonContainer

  Felt too long.

  Dean Herbert · 2022-02-14 18:08:17 +09:00
  e324287f79
• Remove unused using statement
  Dean Herbert · 2022-02-14 18:01:56 +09:00
  3aa5908de8
• Move files to UI namespace
  Dean Herbert · 2022-02-14 17:51:39 +09:00
  b9d9fc56af
• Merge branch 'master' into expandable-controls
  Dean Herbert · 2022-02-14 16:57:45 +09:00
  80ba06b0e3
• Merge pull request #16856 from PercyDan54/relax-ignore-zero-length-spinner

  Ignore short spinners for Relax mod

  Dan Balasescu · 2022-02-14 14:36:46 +09:00
  fdddeb7ed2
• Don't override previous value

  Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>

  PercyDan · 2022-02-12 11:15:03 +08:00
  639d813d06
• Simplify code
  PercyDan54 · 2022-02-12 10:06:43 +08:00
  053f41d755
• Ignore short spinners for relax mod
  PercyDan54 · 2022-02-12 09:28:50 +08:00
  2ed3d58531
• Merge pull request #16853 from peppy/test-coverage-carousel-visual-state

  Add test coverage checking carousel panel visual state after ruleset filter change

  Dan Balasescu · 2022-02-11 17:32:39 +09:00
  154460845b
• Merge pull request #16854 from peppy/combine-score-submission-request-implementation

  Standardise and combine base implementation of score submission requests

  Dan Balasescu · 2022-02-11 17:31:55 +09:00
  8b05b35b8c
• Remove unnecessary this. prefix
  Dean Herbert · 2022-02-11 16:21:49 +09:00
  28bbf34b14
• Merge pull request #16850 from frenzibyte/readonly-pinned-scores

  Add read-only pinned scores view in user profile overlay

  Dan Balasescu · 2022-02-11 16:15:46 +09:00
  43f1044987
• Standardise and combine base implementation of score submission requests

  These share too much yet have very different constructor signatures and
  property exposure. Just a clean-up pass as I begin to look at replay
  submission.

  Dean Herbert · 2022-02-11 15:53:47 +09:00
  beb3731c0b
• Merge pull request #16852 from frenzibyte/ruleset-grouping-order

  Standardise grouping and ordering of `IRulesetInfo`/`RulesetInfo`s

  Dean Herbert · 2022-02-11 15:43:43 +09:00
  09d29892c9
• Update pinned score container header to use localised title
  Salman Ahmed · 2022-02-11 09:22:09 +03:00
  ccd6648961
• Add test coverage checking carousel panel visual state after ruleset filter change
  Dean Herbert · 2022-02-11 15:21:01 +09:00
  f012f64fd1
• Revert "Fix failing test case"

  This reverts commit c29cc78853.

  Dean Herbert · 2022-02-11 15:19:55 +09:00
  f049f175d5
• Update resources
  Salman Ahmed · 2022-02-11 09:12:02 +03:00
  b06caf2bf7
• Introduce private APIRuleset for online ID equality comparison
  Salman Ahmed · 2022-02-11 08:27:01 +03:00
  92e22c57a7
• Fix failing test case
  Salman Ahmed · 2022-02-11 04:44:54 +03:00
  c29cc78853
• Standardise ordering/grouping of IRulesetInfo/RulesetInfos
  Salman Ahmed · 2022-02-11 04:27:11 +03:00
  6f0e32826c
• Consider OnlineIDs during ruleset equality if available

  Required for `APIBeatmap`s, which provide `Ruleset` instances with `OnlineID` available only.
  
  Also consistent with the comparer implementation.

  Salman Ahmed · 2022-02-11 04:26:58 +03:00
  26839f6ad8
• Update pointless CompareTo implementation once again
  Salman Ahmed · 2022-02-11 04:17:30 +03:00
  1b729e891d
• Allow IRulesetInfos of same type to be comparable

  At first I was planning on making `CompareTo` implemented at
  `IRulesetInfo` itself and shared across classes, but turns out it only
  implements it explicitly and not allow direct `IRulesetInfo.Equals`
  calls.
  
  It messed with my head enough that I decided to just let each class have
  its own implementation and only allow same type.

  Salman Ahmed · 2022-02-11 04:03:23 +03:00
  9574bc1382
• Add score container for pinned scores in ranks section
  Salman Ahmed · 2022-02-10 21:32:18 +03:00
  4f7003928a
• Update API models with score pinning changes
  Salman Ahmed · 2022-02-10 21:23:38 +03:00
  9cd88ec2b8
• Merge pull request #16849 from peppy/update-resources
  Salman Ahmed · 2022-02-10 20:34:44 +03:00
  481003fe38
• Update resources
  Dean Herbert · 2022-02-11 01:49:52 +09:00
  2939bc4644
• Merge pull request #16827 from smoogipoo/spectator-state-rework

  Add user state to SpectatorState, allowing multiplayer to continue to results

  Dean Herbert · 2022-02-11 01:48:47 +09:00
  eda213e4de
• Merge pull request #16844 from peppy/migration-delete-fail-gracefully

  Allow game folder migration to fail gracefully when cleanup cannot completely succeed

  Dan Balasescu · 2022-02-10 22:41:36 +09:00
  015ec0b88a
• Update tests
  Dean Herbert · 2022-02-10 19:35:28 +09:00
  19cb8cb03a
• Allow game folder migration to fail gracefully when cleanup cannot completely succeed
  Dean Herbert · 2022-02-10 19:30:26 +09:00
  44f2d8a448
• Merge pull request #16842 from peppy/migration-error-output

  Fix migration errors not outputting the call stack to logs

  Dan Balasescu · 2022-02-10 16:31:14 +09:00
  7081c418dd
• Fix migration errors not outputting the call stack to logs
  Dean Herbert · 2022-02-10 15:50:03 +09:00
  88bb9d4237
• Merge pull request #16838 from peppy/update-fastlane-souyuz

  Update fastlane to latest release

  Dan Balasescu · 2022-02-10 15:01:30 +09:00
  4dab42362e
• Remove unused using
  Dan Balasescu · 2022-02-10 14:22:08 +09:00
  ebd105422f
• Simplify disposal
  Dan Balasescu · 2022-02-10 14:21:51 +09:00
  f7fb7825cc
• Remove allowance of null dependency
  Dan Balasescu · 2022-02-10 14:21:50 +09:00
  a3896a8ebd
• Update fastlane to latest release

  This pulls in the fix from souyuz to allow us to bring things up-to-date
   again (see https://github.com/voydz/souyuz/pull/36#event-6033249116).
  
  Have tested builds locally to work as expected.

  Dean Herbert · 2022-02-10 12:12:14 +09:00
  f47748591a
• Merge pull request #16832 from hlysine/ruleset-templates-improvements
  Dean Herbert · 2022-02-10 01:38:08 +09:00
  b9655dd1d2