67033 Commits

This Branch

This Branch

All Branches

• Menial cleanups
  Bartłomiej Dach · 2024-05-22 15:52:57 +02:00
  f7ca18b52e
• Added tests for difficulty clamping
  Aurelian · 2024-05-22 13:26:00 +02:00
  f3cae73e2e
• Changed allowed mania keys, and reverted 0af32c5
  Aurelian · 2024-05-22 11:37:55 +02:00
  b25987ffe7
• Moved DIfficulty Clamping to occur after the file has been parsed

  This is to handle potential issues with the ruleset being parsed after circle size has been parsed.

  Aurelian · 2024-05-21 10:15:53 +02:00
  1127a69359
• Clamped Difficulty Ranges to [0,10]
  Aurelian · 2024-05-20 16:23:16 +02:00
  db8b72eb37
• Added a minimum value for the scale calculated by the CS value.
  Aurelian · 2024-05-18 07:45:01 +02:00
  0af32c5d4b
• Merge pull request #28198 from frenzibyte/remove-warnaserror-from-local-builds

  Remove `TreatWarningsAsErrors` flags from local builds for developer convenience

  Dan Balasescu · 2024-05-18 13:40:11 +09:00
  9532725eb7
• Remove TreatWarningsAsErrors flags from local builds for developer convenience
  Salman Ahmed · 2024-05-18 06:38:25 +03:00
  2027d481ee
• Merge pull request #28191 from bdach/fix-mismatching-localisation-xmldoc

  Fix xmldoc mismatches in localisation files

  Bartłomiej Dach · 2024-05-17 09:22:55 +02:00
  badda23dde
• Merge branch 'master' into fix-mismatching-localisation-xmldoc
  Bartłomiej Dach · 2024-05-17 08:47:14 +02:00
  e604a99053
• Bump once more
  Dan Balasescu · 2024-05-17 11:15:17 +09:00
  2f9d74286d
• Merge pull request #28190 from bdach/fix-duped-translation-keys

  Fix duplicated localisation key in `DeleteConfirmationContentStrings`

  Dan Balasescu · 2024-05-17 11:03:15 +09:00
  06d6df95de
• Merge pull request #28193 from bdach/what-is-discord-doing

  Fix discord arbitrarily refusing to work on "too short" strings

  Dan Balasescu · 2024-05-17 11:01:36 +09:00
  a2e67ee699
• Fix discord arbitrarily refusing to work on "too short" strings

  Closes https://github.com/ppy/osu/issues/28192.

  Bartłomiej Dach · 2024-05-16 18:24:51 +02:00
  a3dfd99f7d
• Fix xmldoc mismatches in localisation files

  This is enforced by the localisation analyser after
  https://github.com/ppy/osu-localisation-analyser/pull/62, but it appears
  the analyser was never actually bumped game-side after that change and
  I'm not super sure why, as there does not appear to be a reason to _not_
  do that. So this commit does it.

  Bartłomiej Dach · 2024-05-16 17:39:27 +02:00
  f2f03f08cb
• Fix duplicated localisation key in DeleteConfiormationContentStrings

  Noticed via `osu-resources` build warnings.
  
  There are also a few other warnings about
  https://github.com/ppy/osu/pull/27472. Seems something in crowdin
  innards may still be exporting those strings even though they have been
  fixed already. Not sure how to address that.
  
  Probably need these to be detected via static analysis at this point
  since it's happened again. Might look into the feasibility of making
  that happen.

  Bartłomiej Dach · 2024-05-16 14:49:56 +02:00
  5dd64a7c86
• Merge pull request #28186 from bdach/revert-wide-columns-on-mobile
  Dean Herbert · 2024-05-16 19:15:35 +08:00
  f9fd1b957f
• Do not change mania column width on mobile platforms

  - Closes https://github.com/ppy/osu/issues/25852
  - Reverts https://github.com/ppy/osu/pull/25336 /
    https://github.com/ppy/osu/pull/25777
  
  With the columns not being directly touchable anymore after
  https://github.com/ppy/osu/pull/28173 I see very little point to this
  continuing to exist.

  Bartłomiej Dach · 2024-05-16 08:21:52 +02:00
  97de73b99c
• Add inline comment explaining LifetimeEnd set for future visitors
  Dean Herbert · 2024-05-15 14:17:28 +08:00
  a3960bf715
• Merge pull request #28173 from peppy/mania-touch-input-revised

  Add more usable osu!mania touch input system

  Bartłomiej Dach · 2024-05-14 19:28:48 +02:00
  d52dffefbc
• Merge pull request #28170 from peppy/fix-catch-dho-performance

  Set a rudimentary lifetime end to improve seek performance in scrolling rulesets

  Bartłomiej Dach · 2024-05-14 19:27:40 +02:00
  7c1640e124
• Remove redundant cast
  Bartłomiej Dach · 2024-05-14 18:41:15 +02:00
  3d190f7e88
• Merge pull request #28174 from peppy/load-while-logo-drag

  Continue loading even when osu! logo is being dragged at loading screen

  Bartłomiej Dach · 2024-05-14 18:39:03 +02:00
  dae1686e7b
• Continue loading even when osu! logo is being dragged at loading screen

  Closes https://github.com/ppy/osu/issues/28130.

  Dean Herbert · 2024-05-14 23:54:07 +08:00
  cff865b556
• Merge pull request #28171 from bdach/present-score-different-hashes

  Use hash rather than online ID as primary lookup key when presenting score

  Dean Herbert · 2024-05-14 23:39:54 +08:00
  c31b503f2a
• Merge pull request #28172 from bdach/nrt-results-classes

  Apply NRT to results-related components

  Dean Herbert · 2024-05-14 23:01:24 +08:00
  d74be8b920
• Remove touch mod addition to mania

  Feels a bit pointless? I dunno.

  Dean Herbert · 2024-05-14 22:38:31 +08:00
  f781dc3300
• Update tests in line with new structure
  Dean Herbert · 2024-05-14 22:34:05 +08:00
  636e200471
• Tidy class and change to be a VisibilityContainer similar to taiko implementation
  Dean Herbert · 2024-05-14 22:34:05 +08:00
  5c9a90cb40
• Rename touch area class to match existing usage (see taiko)
  Dean Herbert · 2024-05-14 22:34:05 +08:00
  390557634a
• Move out of playfield so touch overlay is not affected by playfield position
  Dean Herbert · 2024-05-14 22:34:05 +08:00
  12e98fe55d
• Apply NRT to results statistics displays
  Bartłomiej Dach · 2024-05-14 15:21:12 +02:00
  ee9144c3bd
• Apply NRT to RankText
  Bartłomiej Dach · 2024-05-14 15:21:05 +02:00
  414f023817
• Apply NRT to RankBadge
  Bartłomiej Dach · 2024-05-14 15:20:56 +02:00
  b937b94bd2
• Apply NRT to AccuracyCircle
  Bartłomiej Dach · 2024-05-14 15:20:47 +02:00
  ced1c79490
• Apply NRT to ContractedPanelTopContent
  Bartłomiej Dach · 2024-05-14 15:20:36 +02:00
  e7721b073c
• Apply NRT to SimpleStatisticTable
  Bartłomiej Dach · 2024-05-14 15:20:26 +02:00
  8e16b57d09
• Apply NRT to SimpleStatisticsItem
  Bartłomiej Dach · 2024-05-14 15:20:17 +02:00
  237ae8b46a
• Apply NRT to PerformanceBreakdownChart
  Bartłomiej Dach · 2024-05-14 15:20:07 +02:00
  2f2257f6ce
• Apply NRT to ScorePanel
  Bartłomiej Dach · 2024-05-14 15:19:58 +02:00
  77a7f475ee
• Apply NRT to StatisticsPanel
  Bartłomiej Dach · 2024-05-14 15:19:46 +02:00
  10a8e84046
• Apply NRT to ScorePanelList
  Bartłomiej Dach · 2024-05-14 15:19:43 +02:00
  cb49147d1e
• Hook up touch device mod
  Dan Balasescu · 2024-05-14 19:14:58 +08:00
  a761a7bced
• Add opacity setting
  Dan Balasescu · 2024-05-14 19:14:50 +08:00
  e3f2e1ba08
• Hook up input manager
  Dan Balasescu · 2024-05-14 19:14:50 +08:00
  39337f5189
• Add mania touch overlay

  Adjust default anchor/origin

  Dan Balasescu · 2024-05-14 19:14:50 +08:00
  ef40197713
• Remove existing per-column touch input
  Dan Balasescu · 2024-05-14 19:10:14 +08:00
  4f6777a0a1
• Use hash rather than online ID as primary lookup key when presenting score

  Something I ran into when investigating
  https://github.com/ppy/osu/issues/28169.
  
  If there are two scores with the same online ID available in the
  database - for instance, one being recorded locally, and one recorded by
  spectator server, of one single play - the lookup code would use online
  ID first to find the score and pick any first one that matched. This
  could lead to the wrong replay being refetched and presented / exported.
  
  (In the case of the aforementioned issue, I was confused as to whether
  after restarting spectator server midway through a play and importing
  the replay saved by spectator server after the restart, I was seeing a
  complete replay with no dropped frames, even though there was nothing in
  the code that prevented the frame drop. It turns out that I was getting
  presented the locally recorded replay instead all along.)
  
  Instead, jiggle the fallback preference to use hash first.

  Bartłomiej Dach · 2024-05-14 11:16:50 +02:00
  03a279a48d
• Add failing test case
  Bartłomiej Dach · 2024-05-14 11:13:06 +02:00
  7f3fde2a25
• Set a rudimentary lifetime end to improve seek performance in scrolling rulesets
  Dean Herbert · 2024-05-14 05:02:08 +08:00
  cfb2c8272b