h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-13 04:32:57 +08:00
Code Issues Releases Wiki Activity

Menial cleanups

Browse Source
This commit is contained in:
Bartłomiej Dach 2024-05-22 15:52:57 +02:00
parent f3cae73e2e
commit f7ca18b52e
No known key found for this signature in database
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
osu.Game/Beatmaps/Formats/LegacyBeatmapDecoder.cs
View File

@ -105,18 +105,18 @@ namespace osu.Game.Beatmaps.Formats
}
/// <summary>
/// Clamp Difficulty settings to be within the normal range.
/// Ensures that all <see cref="BeatmapDifficulty"/> settings are within the allowed ranges.
/// See also: https://github.com/peppy/osu-stable-reference/blob/0e425c0d525ef21353c8293c235cc0621d28338b/osu!/GameplayElements/Beatmaps/Beatmap.cs#L567-L614
/// </summary>
private void applyDifficultyRestrictions(BeatmapDifficulty difficulty)
{
difficulty.DrainRate = Math.Clamp(difficulty.DrainRate, 0, 10);
//If the mode is not Mania, clamp circle size to [0,10]
if (beatmap.BeatmapInfo.Ruleset.OnlineID != 3)
difficulty.CircleSize = Math.Clamp(difficulty.CircleSize, 0, 10);
//If it is Mania, it must be within [1,18] - copying what stable does https://github.com/ppy/osu/pull/28200#discussion_r1609522988
//The lower bound should be 4, but there are ranked maps that are lower than this.
else
difficulty.CircleSize = Math.Clamp(difficulty.CircleSize, 1, 18);
// mania uses "circle size" for key count, thus different allowable range
difficulty.CircleSize = beatmap.BeatmapInfo.Ruleset.OnlineID != 3
? Math.Clamp(difficulty.CircleSize, 0, 10)
: Math.Clamp(difficulty.CircleSize, 1, 18);
difficulty.OverallDifficulty = Math.Clamp(difficulty.OverallDifficulty, 0, 10);
difficulty.ApproachRate = Math.Clamp(difficulty.ApproachRate, 0, 10);