1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-30 12:37:24 +08:00
Commit Graph

56664 Commits

Author SHA1 Message Date
Dan Balasescu
e4fb9119b3
Merge pull request #21060 from peppy/rename-target-practice
Rename mod "Target" to "Target Practice"
2022-11-01 20:38:15 +09:00
Dan Balasescu
3fa529c27a
Merge pull request #21059 from peppy/fix-combo-colour-application
Fix `DrawableHitObject.AccentColour` not being updated if object entry is not attached
2022-11-01 20:21:17 +09:00
Dan Balasescu
947e6d41c0
Merge pull request #21056 from peppy/fix-argon-explosion-size
Fix argon hit circle outer gradient getting smaller each state application
2022-11-01 20:03:22 +09:00
Dan Balasescu
fcf0ad2b99
Merge pull request #21057 from peppy/fix-accent-colour-change-performance-osu-argon
Fix large transform retention when adjusting accent colour of hitobject during pause
2022-11-01 20:00:48 +09:00
Dean Herbert
cd8dc9b17b Rename "Target" to "Target Practice" 2022-11-01 19:47:20 +09:00
Dean Herbert
f014acfc8d Fix DrawableHitObject.AccentColour not being updated if object entry is not attached 2022-11-01 19:34:53 +09:00
Dean Herbert
ff60eebe21 Fix large transform retention when adjusting accent colour of hitobject during pause 2022-11-01 19:12:59 +09:00
Dean Herbert
c179f0bb52 Fix argon hit circle outer gradient getting smaller each state application 2022-11-01 18:31:30 +09:00
Dean Herbert
ddb3d8326e
Merge pull request #21054 from smoogipoo/adjust-mod-multipliers
Adjust target and hold off mod multipliers
2022-11-01 18:12:56 +09:00
Dan Balasescu
37407293aa Adjust target and hold off mod multipliers 2022-11-01 17:57:20 +09:00
Dean Herbert
978d15955c Fix control points not being cloned when running beatmap conversion
Closes #20994.

I haven't considered how this affects performance of difficulty
calculation or otherwise. Seems like a sane initial fix which we can
iterate on going forward.

I've tested using the scenario in the linked issue.

I'm not going to add test coverage because
[BeatmapConversionTest](https://github.com/ppy/osu/blob/master/osu.Game/Tests/Beatmaps/BeatmapConversionTest.cs)
should correctly cover this scenario once we are serialising control
points as well.
2022-11-01 17:42:09 +09:00
Dean Herbert
17b435db35
Merge pull request #21050 from peppy/fix-safe-area-initial-state
Fix notch toggle not applying correctly after restart
2022-11-01 17:20:17 +09:00
Dean Herbert
29bc653d24 Remove incorrect double multiplication and add missing test coverage 2022-11-01 17:17:54 +09:00
Dean Herbert
d15585153d Fix breadcrumb display in directory selector overlapping new "show hidden" button
Closes #21034.
2022-11-01 17:07:59 +09:00
Dean Herbert
8280605e92 Fix notch toggle not applying correctly after restart 2022-11-01 16:31:09 +09:00
Dean Herbert
d807d9d822 Add failing test covering snap calculations with SV applied 2022-11-01 16:22:48 +09:00
Dean Herbert
e8b7914295 Add test coverage of new parameter 2022-11-01 15:13:05 +09:00
Dean Herbert
2a88409dfe Fix time snap of sliders not matching when SV is not 1.0x
This regressed with https://github.com/ppy/osu/pull/20850 because the
function was used in other places which expect it to factor slider
velocity into the equation.

Rather than reverting, I've added a new argument, as based on the method
naming alone it was hard to discern whether SV should actually be
considered.

The reason for the change in #20850 was to avoid the SV coming in from a
reference object which may not have a correct SV in the first place. In
such cases, passing `false` to the function will give the expected
behaviour.
2022-11-01 15:12:58 +09:00
Dan Balasescu
00bd77ce76
Merge pull request #21045 from peppy/improve-ruleset-load-fail-message
Improve messaging when ruleset load fails
2022-11-01 14:36:40 +09:00
Dean Herbert
706adfb28c Improve messaging when ruleset load fails 2022-11-01 13:57:34 +09:00
Dean Herbert
8a37649097
Merge branch 'master' into socket-client 2022-10-31 16:00:14 +09:00
Dean Herbert
4213abfc46 Adjust testflight cleanup interval to 30 days
Been using this for a while but haven't committed it.
2022-10-31 12:55:23 +09:00
Dean Herbert
3f17c206d2 Update fastlane and dependencies 2022-10-31 12:49:50 +09:00
Dean Herbert
9ea2bd84bd
Merge pull request #21018 from andy840119/reuse-the-function-in-timeline-class
Reuse function in the timeline class
2022-10-30 23:49:02 +09:00
Bartłomiej Dach
93c3bc6550
Merge pull request #21020 from peppy/fix-pause-button-interaction
Fix hold to pause button not working when HUD is hidden
2022-10-30 14:23:18 +01:00
Dean Herbert
1035b5fb19 Fix hold to pause button not working when HUD is hidden 2022-10-30 21:38:45 +09:00
Dean Herbert
8399261c77 Add failing test showing hold for menu not working when HUD is hidden 2022-10-30 21:38:31 +09:00
Dean Herbert
f5e11343c2 Apply nullability to HUD test scene 2022-10-30 21:25:31 +09:00
Dean Herbert
aa9604c49e
Merge pull request #21014 from Joehuu/fix-toolbar-clock-visual-bug
Fix toolbar visual bug when toggling clock displays
2022-10-30 18:32:14 +09:00
andy840119
a753369d3e Reuse function TimeAtPosition() and PositionAtTime(). 2022-10-30 17:21:50 +08:00
Joseph Madamba
d56786b5ff Fix toolbar visual bug when toggling clock displays 2022-10-29 15:25:16 -07:00
Bartłomiej Dach
933d1d549b
Merge pull request #20983 from peppy/safe-area-toggle
Add setting to allow forcing the game to draw over notches / cameras
2022-10-29 13:49:17 +02:00
Bartłomiej Dach
71d87489ab
Merge branch 'master' into safe-area-toggle 2022-10-29 13:19:44 +02:00
Bartłomiej Dach
96436b065a
Merge pull request #20948 from nullium21/fix-filename-char-filtering
Only use alphanumeric + some special characters in filenames
2022-10-29 13:19:27 +02:00
Bartłomiej Dach
f775741d65
Merge branch 'master' into fix-filename-char-filtering 2022-10-29 12:42:10 +02:00
Bartłomiej Dach
09b676ec20
Merge pull request #20993 from peppy/improve-argon-bananas
Improve osu!catch "argon" skin bananas
2022-10-29 12:41:53 +02:00
Bartłomiej Dach
87fc5be562
Merge branch 'master' into improve-argon-bananas 2022-10-29 12:09:24 +02:00
Dean Herbert
8c9250285f Revert incorrect removal default value (causing a new warning) 2022-10-29 18:09:27 +09:00
Dean Herbert
a985151e31 Fix incorrect constant 2022-10-29 18:07:17 +09:00
ansel
9df96aab38 Remove local popover containers 2022-10-28 22:17:45 +03:00
ansel
295c40581b Add a global popover container 2022-10-28 20:18:11 +03:00
Dean Herbert
19e0b9085c Remove redundant parameters 2022-10-29 00:24:33 +09:00
Dean Herbert
223cb5f497
Merge pull request #20997 from mk56-spn/RemoveUnusedButton
Delete unused button "CircularButton.cs"
2022-10-29 00:21:49 +09:00
D.Headley
21d68bfb84 Delete unused button 2022-10-28 16:40:21 +02:00
Dean Herbert
0c25658805 Update framework 2022-10-28 21:58:38 +09:00
Dean Herbert
40efa1603b Adjust metrics to make banana lens flares look better 2022-10-28 19:35:50 +09:00
Dean Herbert
e87b541c58 Add fade to banana's lighting as it approaches the catcher
This also avoids using the `UprightScalingContainer` (and allows for
scale adjust in the process).
2022-10-28 18:29:59 +09:00
Dean Herbert
f46a9d683a Fix null reference in headless tests 2022-10-28 18:07:25 +09:00
Dean Herbert
66ed77ac91 Rename and add documentation to function 2022-10-28 18:04:28 +09:00
Dean Herbert
92167afaab
Merge pull request #20842 from frenzibyte/fix-input-sections-in-tests
Fix input settings not displaying in visual test browser
2022-10-28 17:27:15 +09:00