39530 Commits

This Branch

This Branch

All Branches

• Reword import dialogs.

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Lucas A · 2021-05-17 12:55:58 +02:00
  f60dbbfbbd
• Reword StableDirectoryLocationDialog.

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Lucas A · 2021-05-17 12:55:58 +02:00
  e15e8068d3
• Fix code inspections and remove now unused code.
  Lucas A · 2021-05-17 12:55:58 +02:00
  dabe8bd4c7
• Reword ImportFromStablePopup and display the popup regardless of whether a stable install is detected.
  Lucas A · 2021-05-17 12:55:58 +02:00
  a7b740fd1d
• Bring back injected dependency incorrectly marked as unused.
  Lucas A · 2021-05-17 12:55:58 +02:00
  8ba50b1854
• Add StableDirectoryLocationDialog
  Lucas A · 2021-05-17 12:55:57 +02:00
  481b0a0125
• Order imports depending on beatmap imports if any is running.
  Lucas A · 2021-05-17 12:55:57 +02:00
  325a689d65
• Hook up StableImportManager.
  Lucas A · 2021-05-17 12:55:57 +02:00
  851e33fd15
• Add StableImportManager
  Lucas A · 2021-05-17 12:55:56 +02:00
  5d5b1e1f0e
• Merge pull request #12781 from Game4all/directory-select-screen

  Implement a directory selection screen

  Dean Herbert · 2021-05-17 17:23:00 +09:00
  7921930a92
• Merge branch 'master' into directory-select-screen
  Dan Balasescu · 2021-05-17 17:22:03 +09:00
  d75ef160e8
• Expose method to adjust header text, not whole drawable
  Dean Herbert · 2021-05-17 16:41:46 +09:00
  baa4089364
• Merge pull request #12834 from Henry-YSLin/flip-mod

  Added "invert" mod for taiko

  Dean Herbert · 2021-05-17 12:47:05 +09:00
  de2900bc7c
• Merge pull request #12464 from PercyDan54/playlist-unicode

  Add support for original language metadata display on playlist items

  Dan Balasescu · 2021-05-17 12:25:35 +09:00
  22f75ce271
• Renamed TaikoModFlip to TaikoModSwap
  Henry Lin · 2021-05-17 11:04:01 +08:00
  f34637ea9c
• Revert "Renamed TaikoModFlip to TaikoModInvert"

  This reverts commit 5972e43bc2.

  Henry Lin · 2021-05-17 10:59:56 +08:00
  c4ae70a827
• Merge branch 'master' into playlist-unicode
  Dan Balasescu · 2021-05-17 11:47:10 +09:00
  ce7c503e6e
• Merge pull request #12811 from PercyDan54/hidden-code-cleanup

  Remove obsolete methods in `ModHidden` and apply few touches

  Dean Herbert · 2021-05-16 22:07:45 +09:00
  a32f1ef35a
• Renamed TaikoModFlip to TaikoModInvert
  Henry Lin · 2021-05-16 12:51:40 +08:00
  5972e43bc2
• Remove unused using statements
  Dean Herbert · 2021-05-16 13:21:19 +09:00
  422a3b76b6
• Move new mod to end to avoid reordering
  Dean Herbert · 2021-05-16 13:21:06 +09:00
  cbc2a38b59
• Separate Flip and Random
  Henry Lin · 2021-05-16 12:03:03 +08:00
  3d83741a23
• Trimmed trailing white space
  Henry Lin · 2021-05-16 11:28:11 +08:00
  da13be6dd0
• Added "flip" mod for taiko
  Henry Lin · 2021-05-16 11:16:12 +08:00
  3519398a22
• Merge pull request #12833 from Henry-YSLin/master
  Dean Herbert · 2021-05-16 12:12:20 +09:00
  9010cd0839
• Change "judgment" to "judgement"
  Henry Lin · 2021-05-16 10:17:04 +08:00
  a91f2d3dba
• Merge pull request #12717 from frenzibyte/player-loader-star-rating

  Add star rating to the beatmap metadata in player loading screen

  Dean Herbert · 2021-05-15 18:25:58 +09:00
  2021.515.0 50a3775a22
• Remove null conditional

  Shouldn't guard against that here.

  Salman Ahmed · 2021-05-15 10:00:05 +03:00
  34d1490754
• Merge branch 'master' into player-loader-star-rating
  Dean Herbert · 2021-05-15 15:39:57 +09:00
  dc56250a3c
• Merge pull request #12747 from frenzibyte/current-star-rating

  Allow changing current star difficulty of a `StarRatingDisplay`

  Dean Herbert · 2021-05-15 15:39:39 +09:00
  94b7e89ac0
• Merge pull request #12759 from Naxesss/beatmap-verifier-context

  Encapsulate check arguments in context object

  Dean Herbert · 2021-05-15 15:39:12 +09:00
  bdcb1a624e
• Duplicate implementions
  PercyDan54 · 2021-05-15 11:55:50 +08:00
  166974506e
• Revert "Remove empty override"

  This reverts commit a86a4bab91.

  PercyDan54 · 2021-05-15 11:45:14 +08:00
  6e5c4ed7c6
• Rename startTime in parameters
  PercyDan54 · 2021-05-15 11:26:16 +08:00
  63ac430386
• Merge pull request #12805 from peppy/add-user-id-beatmap-metadata

  Add database tracking of beatmap creator `user_id`s

  Dean Herbert · 2021-05-15 09:03:52 +09:00
  7632b8621e
• Merge pull request #12801 from peppy/null-assignment-warning-enable

  Switch null assignment to non-nullable entity warnings on

  Dean Herbert · 2021-05-15 09:03:03 +09:00
  cb9db0da0a
• Merge branch 'master' into null-assignment-warning-enable
  Bartłomiej Dach · 2021-05-15 01:08:34 +02:00
  7665bdfbbb
• Ignore skin component json data if deserialisation fails instead

  Crashing was not really the best thing to do there given the preceding
  code that already allowed a few continues in case of a missing file.

  Bartłomiej Dach · 2021-05-15 01:08:11 +02:00
  69fc072429
• Ignore possible nulls from stream reader in IPC

  Any failures will be caught. They're not logged, but they also weren't
  before. Error handling can be improved at a future date, this series of
  changes is primarily intending to unblock a new inspection.

  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  ae71389ebe
• Ignore possible nulls in NotifyCollectionChangedArgs

  Safe to access by the virtue of the preceding case labels on
  `args.Action`.  And they're in test code anyways.

  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  d581e0a252
• Ignore possible null in multiplayer test

  A null value will fail the test anyhow.

  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  e62e473bb2
• Ignore possible path-related nulls

  They're all in test code anyway, so any issue there will cause a test to
  fail.

  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  b51d038088
• Ignore possible null from JsonConvert.DeserializeObject()

  Nothing better can be done if a `null` is indeed returned.

  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  fa6b5515b7
• Ignore possible null in GetResponseString()

  A null there indicates a deserialisation error and therefore due to the
  catch block immediately succeeding the changed line everything will
  continue to work as intended.

  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  5b2b701915
• Ignore possible nulls in Type.GetType() calls

  They're mostly used in extensibility scenarios, so everything happens in
  runtime. There is no better resolution than to crash with a null
  reference exception.

  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  628e7a71ed
• Mark access to exception if task faulted as safe

  There are seemingly no C#-side compile-time guarantees that it is safe,
  but if the task's state is `Faulted` (as is checked right before), the
  exception cannot be null as per the documentation.

  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  43c73f9583
• Remove list null-checks in LogoTrackingContainer test

  If the null-checks were tripped, the test would crash anyway. It is not
  possible to call `.Any()` and get a valid result instead of an exception
  on a null reference.

  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  f2d0f7db99
• Pass placeholder hitobject instead of null
  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  483e0dd943
• Remove bogus InternalChildren null-check

  `InternalChildren` can't viably be `null`, and if it were, we have
  bigger problems. The removed null-check was triggering false-positive
  inspections further down.

  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  f716fb0968
• Use conditional nullability attribute

  As it turns out, C# 8 provides an attribute that allows annotating that
  an `out` parameter's nullability depends on the method's return value,
  which is exactly what is desired here.

  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  c9facf70f9